Hi Yosry,
Everything looks fine to me. Except intermediate feature test failure. May
be @committers can try on their machine.
==
FAIL: runTest
(pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest)
Tests the path
Any more suggestions or comments on the patch?
On Tue, Aug 13, 2019 at 2:55 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
>
>
> On Tue, Aug 13, 2019 at 5:35 PM Yosry Muhammad wrote:
>
>> Please find attached an updated patch with a small modification to the
>> feature test.
Is it always the same error when it fails?
On Tue, Aug 13, 2019 at 1:50 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> The test cases fails intermittently. It passes sometimes.
>
> On Tue, Aug 13, 2019 at 5:15 PM Yosry Muhammad wrote:
>
>> Hi Aditya,
>>
>> The test passes on
On Tue, Aug 13, 2019 at 5:35 PM Yosry Muhammad wrote:
> Please find attached an updated patch with a small modification to the
> feature test. This makes sure the first history element is selected and
> focused before trying to move through entries using the down arrow key.
> When the test
Hi Aditya,
The test passes on my computer, is there anything I could try to reproduced
the failure?
By looking at the error, I suspect clicking the down arrow key on your
machine did not move to the next history entry during the test. Does
clicking the down arrow normally go to the next history
The test cases fails intermittently. It passes sometimes.
On Tue, Aug 13, 2019 at 5:15 PM Yosry Muhammad wrote:
> Hi Aditya,
>
> The test passes on my computer, is there anything I could try to
> reproduced the failure?
>
> By looking at the error, I suspect clicking the down arrow key on your
