[RM#3605] View Data: Deleting N number of rows makes first N number of rows disable

2019-08-14 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where using view data, when we try to delete N row, it will make the first N row from the grid disabled, you try to double click on the cell and try to update the value of that row it will not open the editor. *Steps:* 1) Create a simple table as shown in

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Yosry Muhammad
Great! thanks everyone. On Wed, Aug 14, 2019, 10:08 AM Akshay Joshi wrote: > Hi Yosry > > > On Tue, Aug 13, 2019 at 6:33 PM Yosry Muhammad wrote: > >> Any more suggestions or comments on the patch? >> > > I am reviewing it. > >> >> On Tue, Aug 13, 2019 at 2:55 PM Aditya Toshniwal < >>

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
Hi Yosry On Tue, Aug 13, 2019 at 6:33 PM Yosry Muhammad wrote: > Any more suggestions or comments on the patch? > I am reviewing it. > > On Tue, Aug 13, 2019 at 2:55 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Tue, Aug 13, 2019 at 5:35 PM Yosry

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
Hi Yosry I am still facing following issues: - No icons for already saved(before applying your patch) query in query history. Is this expected? - Internal queries are visible even if toggle switch is set to "No". Following are the steps to reproduce: - Create a table with

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
Hi Yosry I have found following issues: - Jasmine test cases are failing. - Browser error when applying the patch and open the query tool. Previously saved queries are there: - [image: Screenshot 2019-08-14 at 3.21.21 PM.png] - Toggle Switch should have text "Yes/No" as we already

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Yosry Muhammad
Hi, On Wed, Aug 14, 2019 at 12:03 PM Akshay Joshi wrote: > Hi Yosry > > I have found following issues: > >- Jasmine test cases are failing. >- Browser error when applying the patch and open the query tool. >Previously saved queries are there: >- [image: Screenshot 2019-08-14 at

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
On Wed, Aug 14, 2019 at 3:53 PM Yosry Muhammad wrote: > Hi, > > On Wed, Aug 14, 2019 at 12:03 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Yosry >> >> I have found following issues: >> >>- Jasmine test cases are failing. >>- Browser error when applying the patch and

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Yosry Muhammad
Hi, On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad wrote: > Please find an updated patch with the mentioned issue fixed. I am sorry > you spent so much time reviewing this and finding bugs. > > On Wed, Aug 14, 2019 at 2:34 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Yosry