Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

2018-05-14 Thread Aditya Toshniwal
Hi Hackers, Please hold on with the patch. Will send the updated patch soon. Apologies. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, May 14, 2018 at 12:52 PM, Aditya Toshniwal <

[pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

2018-05-14 Thread Aditya Toshniwal
Hi Hackers, PFA patch for upgrading jQuery version to 3.3.1 from current version 1.12.4. Patch includes replacing deprecated functions of jquery to latest one. Kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain

Re: JS Test error on Windows

2018-05-11 Thread Aditya Toshniwal
and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Fri, Apr 27, 2018 at 5:34 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, Apr 27, 2018 at 10:49 AM, Murtuza Zabuawala <murtuza.z

Re: JS Test error on Windows

2018-05-11 Thread Aditya Toshniwal
"\/" with "\\" and it worked. But then this will not work on Unix, and so changed it to [\\\/]+ taking both styles. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Fri, May 11, 2018 at 3:05 PM

[pgAdmin4][RM#3298] Query tool shortcut issue

2018-05-08 Thread Aditya Toshniwal
Hi Hackers, PFA patch for query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Also, corrected couple of dropdown HTML codes. Request you to kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions

Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-18 Thread Aditya Toshniwal
Hi Hackers, PFA updated patch for RM#3295. The patch is to fix the issue in firefox also. Kindly review. Please try in firefox also. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Wed, May 9,

Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-18 Thread Aditya Toshniwal
changed the code to focus its parent div(#container) which have the tabindex="0" attribute. I have added the comments in code also. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Fri, M

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-15 Thread Aditya Toshniwal
Hi Dave, I suggest check which keyboard you are using, US or UK. If UK, try with US keyboard.(might work) Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, May 15, 2018 at 11:35 AM, Ak

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-15 Thread Aditya Toshniwal
On Tue, May 15, 2018 at 6:05 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal <aditya.toshniwal@ > enterprisedb.com> wrote: > >> Hi Dave, >> >> I suggest check which keyboard you are using, US or U

[pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

2018-05-16 Thread Aditya Toshniwal
Hi Hackers, PFA patch to allow server port number below 1024 till 1 in Create Server dialog. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" diff --git a/web/pgadmin/browser/server_groups/servers

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-05-22 Thread Aditya Toshniwal
Thank you Victoria, Anthony. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, May 22, 2018 at 7:15 PM, Victoria Henry <vhe...@pivotal.io> wrote: > Hi Aditya, > > We ma

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

2018-05-23 Thread Aditya Toshniwal
extracting id directly, class, but none of them were present in the object. I can try adding data-test-selector to the HTML5 tag, if it works then will send the updated patch. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

2018-05-23 Thread Aditya Toshniwal
Hi, No luck with data-test-selector. :( I added data-test-selector to html tags. I get undefined for .data('test-selector') as well as for .attr('data-test-selector'). Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

2018-05-23 Thread Aditya Toshniwal
and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, May 14, 2018 at 1:23 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please hold on with the patch. Wi

[pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-05-22 Thread Aditya Toshniwal
milestones https://github.com/psycopg/psycopg2/milestone/4 Also fixed a small glitch for sql editor connection status check. Kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM32

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-05-22 Thread Aditya Toshniwal
@class, 'open')]") File "/root/.pyenv/versions/pgadmin36/lib/python3.6/site-packages/selenium/webdriver/support/wait.py", line 80, in until raise TimeoutException(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: Thanks and Regards, Aditya To

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-06 Thread Aditya Toshniwal
x will be considered as a plain string. INSERT INTO sql_ascii (data) VALUES (E'[Invalid UTF-8] Blob: \xf4\xa5\xa3\xa5'); Kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, Jun

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-06 Thread Aditya Toshniwal
move them too ? It would be nicer to not to leave behind a single js. Kindly let me know your views on this. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Sat, Jun 2, 2018 at 12:47 AM, Vict

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-11 Thread Aditya Toshniwal
Hi Harshal, On Mon, Jun 11, 2018 at 6:37 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > On Mon, Jun 11, 2018 at 6:02 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> This is regarding RM3294 which I am working on, where

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-14 Thread Aditya Toshniwal
ache_version will increase to current epoch time. New tab polling can check if the version has increased and can update ​its preferences along with prefcache_version. ​Please let me know if any suggestions.​ > Thanks > Victoria & Joao > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-18 Thread Aditya Toshniwal
8 at 2:33 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jun 15, 2018 at 2:08 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote:

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-14 Thread Aditya Toshniwal
Hi Hackers, PFA updated patch. On Thu, Jun 7, 2018 at 4:41 PM, Dave Page wrote: > Hi > > On Thu, Jun 7, 2018 at 12:05 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave, >> >> >> On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: >> >>

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-14 Thread Aditya Toshniwal
I am sorry I missed the attachment. :( PFA. On Thu, Jun 14, 2018 at 11:34 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA updated patch. > > On Thu, Jun 7, 2018 at 4:41 PM, Dave Page wrote: > >> Hi >> >> On Thu,

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-15 Thread Aditya Toshniwal
Hi Dave, On Fri, Jun 15, 2018 at 2:08 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> I am sorry I missed the attachment. :( >> PFA. >> > > It looks like the encoding names are getting mun

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-10 Thread Aditya Toshniwal
moving js files, why not this too. > Sincerely, > > Victoria > ​ > > > > On Thu, Jun 7, 2018 at 12:35 AM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Victoria, >> >> On Wed, Jun 6, 2018 at 8:55 PM, Victoria Henry wrote: >> >>> Hi

RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-11 Thread Aditya Toshniwal
properly on different browsers. Request you to kindly suggest if you any better idea. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-05-30 Thread Aditya Toshniwal
Thanks > Victoria && Joao > > On Wed, May 30, 2018 at 3:06 AM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch after all the permutations, combinations for encoding >> for SQL_ASCII database. Also fixed a small glitc

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-05-30 Thread Aditya Toshniwal
min4 error. You need to change client_encoding to the appropriate. After changing client_encoding using command - set client_encoding='XYZ', it will give not give error. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain ab

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-03 Thread Aditya Toshniwal
Hi Hackers, PFA the updated patch on this. I have tried to add test cases to check for different encoding database. In the test run, it will create a database, fire a query for a string, check if we get the output and drops the database. Kindly review. Thanks and Regards, Aditya Toshniwal

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

2018-06-04 Thread Aditya Toshniwal
Missed the attachment. Apologies :( PFA. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, Jun 4, 2018 at 3:12 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: >

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-04 Thread Aditya Toshniwal
Hi Hackers, Please ignore previous patch. Fixed some linter issues. PFA updated patch. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, Jun 4, 2018 at 10:53 AM, Aditya Toshniwal <

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-04 Thread Aditya Toshniwal
Hi On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Aditya, > >> >> >> There is no change related to notifications in this patch. >> The below code is minor fix related to connection status of sql editor. >> Can you please share the code

[pgAdmin4][patch] sqleditor connection status minor patch

2018-06-04 Thread Aditya Toshniwal
and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py index 013e4dc..a9460dd 100644 --- a/web/pgadmin/tools/sqleditor/__init_

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-05 Thread Aditya Toshniwal
Hi Hackers, PFA updated patch. The sqleditor change is sent separately and removed from current patch as suggested. The test cases were running fine when the module was specified using --pkg but were failing in complete run. Fixed that. Kindly review. Thanks and Regards, Aditya Toshniwal

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-05 Thread Aditya Toshniwal
know why that was added. Will remove the set call and will send you the updated patch if everything works fine. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, Jun 5, 2018 at 6:05 PM, Dave P

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-05 Thread Aditya Toshniwal
Hi On Tue, Jun 5, 2018 at 6:25 PM, Dave Page wrote: > > > On Tue, Jun 5, 2018 at 1:49 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave, >> >> The problem of SQL ASCII is solved with the patch, and not related to >> setting the client enc

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-05 Thread Aditya Toshniwal
Also, there are limitations in psycopg2 as well related to encoding, which makes it even more difficult to make behaviour similar to pgAdmin3 as there are encodings and decodings done at pyscopg2 end also. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-05 Thread Aditya Toshniwal
Hi Dave, On Tue, Jun 5, 2018 at 4:56 PM, Dave Page wrote: > Hi > > On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch. The sqleditor change is sent separately and removed >> from current pat

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-06 Thread Aditya Toshniwal
d be nicer to not to leave >> behind a single js. > > I'm not sure what you mean. Could you point to an example of a single js > file? > Sure. I did not find moving web/pgadmin/tools/datagrid/static/js/datagrid.js. Please correct me if I am missing anything. > > Sincerely,

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-07 Thread Aditya Toshniwal
Hi Dave, On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: > Hi > > On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch as the previous one was not working as expec

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-04 Thread Aditya Toshniwal
simulate the failure on some other machines. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, Jun 4, 2018 at 8:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: >

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-06-29 Thread Aditya Toshniwal
Hi Dave, On Fri, Jun 29, 2018 at 9:30 PM, Dave Page wrote: > Hi > > On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch. >> > > This seems to work for the most part, however

[pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie

2018-07-02 Thread Aditya Toshniwal
value will still be generated but nothing will be stored at the backend. Also, I have separated the garbage collection code in current ping service to a new url /misc/cleanup. /misc/ping will be purely for is alive check. Request you to kindly review. -- Thanks and Regards, Aditya Toshniwal

[pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.

2018-05-03 Thread Aditya Toshniwal
of $.ajax call. The XHR is passed and handled in the function itself. Please note that I have used JSON.parse and not $.parseJSON as it will be deprecated in jQuery 3.x and thus removing many $.parseJSON calls. Request you to kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer

Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie

2018-07-03 Thread Aditya Toshniwal
essions$ On Mon, Jul 2, 2018 at 8:29 PM, Dave Page wrote: > Hi > > I'm not in a position to test at the moment, but can you confirm this will > work if the root of pgAdmin is at (for example) /pgadmin? So the actual > root is /pgadmin/misc/ping ? > > On Mon, Jul 2, 2018 at 1:35

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-20 Thread Aditya Toshniwal
Hi Dave, Attached is the updated patch. (Playing with encodings is not at all fun :( ) On Tue, Jun 19, 2018 at 2:23 AM, Dave Page wrote: > Hi > > On Mon, Jun 18, 2018 at 2:14 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-21 Thread Aditya Toshniwal
Hi Hackers, PFA patch to make SQL ASCII related changes compatible with Python 2.6. Dictionary comprehension is not supported in Python 2.6. On Thu, Jun 21, 2018 at 6:27 PM, Dave Page wrote: > Thanks - patch applied! > > On Wed, Jun 20, 2018 at 3:17 PM, Aditya Toshniwal enterpr

[pgAdmin4][RM2136] Include "?" on all routes that are loaded

2018-07-26 Thread Aditya Toshniwal
dly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM2136.patch Description: Binary data

Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded

2018-08-02 Thread Aditya Toshniwal
This is done. - The value of the INTERNAL_VERSION_PARAM can be 'ver' or 'v' instead of > 'intver'. > Value set 'ver' for now. We can always change it later and thats why made it configurable. > > Except above the patch looks good to me. > > Thanks, > Khushboo >

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-25 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch with few more fixes of existing dashboard. Fixed dashboard reloading even if subnodes under a dashboard or server selected. On Tue, Jul 24, 2018 at 9:01 PM, Dave Page wrote: > Thanks, applied. > > On Tue, Jul 24, 2018 at 2:11 PM, Aditya

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

2018-08-15 Thread Aditya Toshniwal
> > > On Wed, Aug 15, 2018 at 1:17 PM, Dave Page wrote: > >> Hi >> >> On Tue, Aug 14, 2018 at 6:41 PM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated pat

[pgAdmin4][patch] Correct handling of URL param values when striping version number

2018-08-16 Thread Aditya Toshniwal
Hi Hackers, Attached is minor patch to correctly handle "values" in web/pgadmin/__init__.py -> strip_version_number which can be None in some cases and will cause exception when None . -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

2018-08-16 Thread Aditya Toshniwal
u, Aug 16, 2018 at 10:42 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave/Hackers, >> >> Please find attached the updated patch. >> >> On Thu, Aug 16, 2018 at 1:45 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu

Re: [pgAdmin 4 - Bug #3556] Slash "/" in server group breaks table contents

2018-08-16 Thread Aditya Toshniwal
product - we are very happy to use it and have a > big benefit out of it. > > /Jan > > > > Den 16-08-2018 kl. 13:36 skrev redm...@postgresql.org: > > Issue #3556 <https://redmine.postgresql.org/issues/3556#change-12959> has > been updated by Aditya Toshniwal. > &g

[pgAdmin4][RM3561] Can't edit Sort/Filter Options after losing database connection

2018-08-21 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix filter dialog issue where it was not opening at all when server is disconnected. The patch will make filter button behaviour similar to Execute query button and will ask to connect. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB

Re: [pgAdmin4][Patch]: Fixed Feature #3503 and RM #3347

2018-08-21 Thread Aditya Toshniwal
" and " >*--column-inserts*",added validation. > > Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

2018-08-28 Thread Aditya Toshniwal
) Found one bug where changing the preferences of Debugger to open in new tab was not working. Debugger opened in same tab. This is fixed. Kindly review. On Mon, Aug 27, 2018 at 7:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the upda

Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

2018-08-29 Thread Aditya Toshniwal
> /home/khushboo/Projects/pgadmin4/web/pgadmin/static/bundle/codemirror.js > 20:28 error Strings must use singlequote quotes > 22:53 error Strings must use singlequote quotes > > Thanks, > Khushboo > > On Wed, Aug 29, 2018 at 11:10 AM, Aditya Toshniwal &l

[pgAdmin4][RM3558] Sort/Filter dialog editing is broken

2018-08-20 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the cursor size issue where the cursor size is very small even if text is larger. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

2018-08-27 Thread Aditya Toshniwal
> > I have also added some feature test for auto complete. Attached is the > patch please review it. > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

2018-08-26 Thread Aditya Toshniwal
rrent tree state will be saved. > - On Reload, while opening the server, the stored path will be populated. > - On closing the node the saved will be updated accordingly. > - Jasmine test cases are included. > > > Thanks, > Khushboo > -- Thanks and Regards, Aditya Toshni

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

2018-08-27 Thread Aditya Toshniwal
Hi Akshay, Attached is the patch to make autocomplete changes python 2.6 compatible. Please note, this patch should be applied over your patch. On Mon, Aug 27, 2018 at 2:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Did a basic testing. Looks g

Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

2018-08-27 Thread Aditya Toshniwal
with the required changes. Thank you Ashesh. On Mon, Aug 27, 2018 at 6:16 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to make debugger scroll automatically to current > active line and scroll along with StepIn/StepOut.

[pgAdmin4][RM3554] Debugger scroll issue for long procedures

2018-08-27 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to make debugger scroll automatically to current active line and scroll along with StepIn/StepOut. Previously, we had to manually scroll. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "

Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

2018-08-27 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch which also includes code changes to avoid reloading same proc/function again in case of a recursive call. On Mon, Aug 27, 2018 at 6:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please hold on

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Aditya Toshniwal
Adding to previous mail, I have removed shadow from graph lines and increased resolution for better visibility and fixed few issues related to graphs. On Tue, Jul 24, 2018 at 4:09 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Aditya Toshniwal
modules. The changes are on the JS side and so patch does not have any test cases included. Kindly review. On Thu, Jul 5, 2018 at 4:09 PM, Dave Page wrote: > Thanks - patch applied! > > On Wed, Jul 4, 2018 at 10:19 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Ha

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Aditya Toshniwal
Hi, Attached is the updated patch. On Tue, Jul 24, 2018 at 4:32 PM, Dave Page wrote: > Hi > > On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the second part of the changes for making preference

Re: [pgAdmin4][RM3462] PG11: Support INCLUDE indexes

2018-07-18 Thread Aditya Toshniwal
Hi Dave, On Wed, Jul 18, 2018 at 6:07 PM, Dave Page wrote: > Hi > > On Wed, Jul 18, 2018 at 12:12 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to support INCLUDE clause for indexes which is >> added fr

[pgAdmin4][RM3462] PG11: Support INCLUDE indexes

2018-07-18 Thread Aditya Toshniwal
and small fix in SQL Editor module where the test case ExtractSQLFromNetworkParametersTest was failing for me due on Python 2.7. ​Kindly review.​ -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

[pgAdmin4][RM3514] Bullets and tooltips for charts

2018-09-05 Thread Aditya Toshniwal
hboard. Possible test cases added. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM3514.patch Description: Binary data

Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-10 Thread Aditya Toshniwal
that of >>>>> the >>>>> tabset control buttons which I'd argue are semantically different in >>>>> purpose). >>>>> >>>> >>>>Fixed. Please find attached patch file. >>>> >>> >>> Almost

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Aditya Toshniwal
Hi Hackers, On Tue, Jul 10, 2018 at 3:37 PM, Dave Page wrote: > Hi > > On Tue, Jul 10, 2018 at 10:36 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the fix. It is again related to changed made for RM3294, the >> font siz

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Aditya Toshniwal
Hi, On Tue, Jul 10, 2018 at 4:24 PM, Dave Page wrote: > I think you forgot the patch :-/ > ​Apologies. I know this is annoying :( ​ PFA. > > > On Tue, Jul 10, 2018 at 11:48 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> On Tue, Ju

[pgAdmin4][patch] jQuery 3 migration few more leftovers

2018-07-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to migrate few more occurrences of deprecated functions of older jQuery versions in pgAdmin4 to jQuery 3 (which were missed in previous patches of jQuery migration :( ). Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB

[pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the fix. It is again related to changed made for RM3294, the font size was set to 0em. Also included changes to make sure CodeMirror font size is never set to 0em but to default 1em if font size is not available from preferences. -- Thanks and Regards, Aditya Toshniwal

[pgAdmin4][RM3478] User should able to type any query in SQL Filter

2018-07-09 Thread Aditya Toshniwal
org/issues/3294> patch 0001 ​which I had sent previously. Also, fixed a small typo in ​ ​ pgadmin/utils/preferences.py Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM3478.p

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Hackers, PPAS SQL also needs to changed. PFA updated patch. On Thu, Apr 12, 2018 at 2:14 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Team, > > Please hold on with the patch. Checking if changes are required for PPAS. > Will update soon. > &

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Khushboo, Looks like that need to be fixed too. It is not because of the new patch. Will send you the updated patch. On Thu, Apr 12, 2018 at 2:47 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > On Thu, Apr 12, 2018 at 2:30 PM, Aditya Toshniwal &l

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Team, Please hold on with the patch. Checking if changes are required for PPAS. Will update soon. On Thu, Apr 12, 2018 at 12:18 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Team, > > PFA patch for RM#3179 where error message was displayed when user se

Re: [pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Hackers, PFA updated patch which includes procedure and functions of ppas. Other nodes works fine. On Thu, Apr 12, 2018 at 2:59 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > Looks like that need to be fixed too. It is not because o

[pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-12 Thread Aditya Toshniwal
Hi Team, PFA patch for RM#3179 where error message was displayed when user selects the SQL tab for a trigger function. Fixed the SQL query used to fetch the definition. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions Pune | Mob - 8055837949 diff --git

[pgAdmin4][RM#3272] - Replace the pycrypto with the pycryptodome

2018-04-18 Thread Aditya Toshniwal
Hi Hackers, PFA patch for replacing pycrytpo with pycryptodome. Tested on Postgres 9.6,10 - Windows, Linux. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions Pune | Mob - 8055837949 RM_3272.patch Description: Binary data

Re: pgAdmin4 form control error icon position change

2018-03-21 Thread Aditya Toshniwal
that > we can keep track of changes, It will be difficult for us to keep track > of email for the details. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 21, 2018 at 2:28 PM, Adit

pgAdmin4 form control error icon position change

2018-03-21 Thread Aditya Toshniwal
of the label of the form control. Below are screenshots. Attached is the patch for the above changes. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions Pune | Mob - 8055837949 diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-06-29 Thread Aditya Toshniwal
gt; ​This error occurs even with the latest pull without changes.​ > >- Set the preferences setting "Open in new browser tab" to True and >open the query tool. Refer "Open_In_New_Broswer.png". > > ​Will look into this.​ > I haven't revie

[pgAdmin4][RM3660] Rename 'SQL Editor' into 'Query Tool' in Preferences

2018-10-08 Thread Aditya Toshniwal
Hi Hackers, Attached is the tiny patch for renaming 'SQL Editor' into 'Query Tool' in Preferences. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM3660.patch Description: Binary data

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-08 Thread Aditya Toshniwal
Hi, On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote: > Hi > > On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to migrate pgAdmin4 currently based on Bootstrap 3, &g

[pgAdmin4][patch] Changes to stabilise feature tests

2018-10-16 Thread Aditya Toshniwal
. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" feature_test_bs4.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM #3232 Backup with incorrect path stays in broken state

2018-10-22 Thread Aditya Toshniwal
ows. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][patch] Changes to stabilise feature tests

2018-10-16 Thread Aditya Toshniwal
Hi, On Tue, Oct 16, 2018 at 3:00 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to stabilise feature tests. Major changes includes: > 1) Changes required for working with Bootstrap 4. > 2) Change to fix the timeout e

[pgAdmin4][patch] Body tag level padding not required

2018-10-31 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to remove CSS values set for body tag which are not required. This may create problems as it is at body level and so should be removed. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain

Re: [pgAdmin4][Patch]: Fixed process watcher status message.

2018-10-25 Thread Aditya Toshniwal
e process watcher when user has stopped the process. >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > -- > *Akshay Joshi* > > *Sr. Software Arc

[pgAdmin4][patch] File Manager replace file minor fix

2018-10-24 Thread Aditya Toshniwal
Hi Hackers, Attached is the minor patch to fix a background color while replacing a file in File Manager dialog. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" replace-file-dialog.patch D

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Aditya Toshniwal
able bring back the calendar control. (Create Role -> Account expiry) Also fixed sort filter dropdown in query tool. Kindly review. On Wed, Oct 10, 2018 at 5:16 PM Dave Page wrote: > Thanks, patch applied. > > On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal < > aditya.toshni..

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Aditya Toshniwal
ced with d-none in Bootstrap 4. One more big miss - debugger button toolbar was not visible/or in position. Fixed that as well. Let me know if you find more. :/ On Thu, Oct 11, 2018 at 3:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Team found

Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI

2018-09-19 Thread Aditya Toshniwal
Hi, Please hold on. Need to fix some PEP8 issues. :| On Wed, Sep 19, 2018 at 6:07 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is patch to fix auto commit issue where changing auto commit > option from preferences was not having a

[pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI

2018-09-19 Thread Aditya Toshniwal
Hi Hackers, Attached is patch to fix auto commit issue where changing auto commit option from preferences was not having any effect in query tools. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about

Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI

2018-09-19 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. Kindly review. On Wed, Sep 19, 2018 at 6:20 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please hold on. Need to fix some PEP8 issues. :| > > On Wed, Sep 19, 2018 at 6:07 PM Aditya Toshni

[patch][pgAdmin4] Windows error - The application server could not be contacted occasionally

2019-01-01 Thread Aditya Toshniwal
figure out the standard timeout). Plus, I have changed the messages at intervals when the app is starting so that it does not look stuck. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Hea

  1   2   3   4   >