pgAdmin 4 commit: 1) Added partition module in webpack config.

2017-07-31 Thread Akshay Joshi
1) Added partition module in webpack config. 2) Fixed missing logic of partition from primary_key.js and unique_constraint.js as this two files are newly created for webpack. 3) Changed the node name from 'check_constraint' to 'check_constraints'. Also changed the same in test case url. Branch

pgAdmin 4 commit: Improved alertify notification logic. Remove Alertify

2017-07-31 Thread Akshay Joshi
Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e506fa1dbea02f4801c1b916ff23e28f2a302911 Modified Files --

pgAdmin 4 commit: Fixed collation tests on Windows, replace use of defa

2017-08-03 Thread Akshay Joshi
Fixed collation tests on Windows, replace use of default 'POSIX' collation with 'C' collation for testing. Fixes #2501 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bebfc627218eccce596caf8fea69eae14682ca7c Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: To fix Collation tests

2017-08-03 Thread Akshay Joshi
for testing, I > have tested it macOS, Linux & Windows platform the tests are working fine. > RM#2501 > > I have also reported bug in Postgres community regarding "POSIX" collation > issue on Windows. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB

pgAdmin 4 commit: Fixed issue in query tool where messages were not dis

2017-08-04 Thread Akshay Joshi
Fixed issue in query tool where messages were not displaying from functions/procedures properly. Fixes #2555 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef48c2ed91b023e4075259c3279484b48f437e49 Author: Murtuza Zabuawala

pgAdmin 4 commit: Use dict based data instead of 2d-array in Type modul

2017-08-17 Thread Akshay Joshi
Use dict based data instead of 2d-array in Type module as we are adding keys on the fly. Reviewed By: Harshal Dhumal Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6c4a16cecd8586c9ee5c9fa8456b6074813f46 Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-17 Thread Akshay Joshi
tp://www.enterprisedb.com/> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: 1) Connection Type cell was not honouring to 'Kind' o

2017-08-17 Thread Akshay Joshi
1) Connection Type cell was not honouring to 'Kind' option in Subnode control. 2) Kind option was not saved properly 3) User was not be able to update Kind option in edit mode. Fixes #2633 Branch -- master Details ---

Re: [pgAdmin4][PATCH] To fix pgAgent job step issues

2017-08-17 Thread Akshay Joshi
The Enterprise PostgreSQL Company > > [image: https://community.postgresrocks.net/] > <https://community.postgresrocks.net/> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch]: RM_2646 - Spinner icon not found error when a server node is connected

2017-08-17 Thread Akshay Joshi
nstead of referencing to static/js/generated/load-node.gif. > > Fixed the reference path, now it points to static/js/generated/laod-node. > gif. > > Please find attached patch and review. > > Thanks, > Surinder > ​ > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed the path reference of load-node.gif which was r

2017-08-17 Thread Akshay Joshi
Fixed the path reference of load-node.gif which was referencing to vendor directory. Fixes #2646 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bff48e0b2de6ba7e63f1f3ee8ae6cadfabf75938 Author: Surinder Kumar

pgAdmin 4 commit: Fixed alertify notification messages where checkmark

2017-08-17 Thread Akshay Joshi
Fixed alertify notification messages where checkmark box disconnected from frame. Fixes #2644 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dee5186f655b46ac239a504d676c571e1e071d20 Author: Sarah McAlear Modified Files

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-17 Thread Akshay Joshi
t;>>> set >>>>>>>>>>>> refresh rate to 1 for all dashboard graphs and repeat the steps. >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> >>>>>>>>>>>>> Wenlin >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar < >>>>>>>>>>>>> surinder.ku...@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi >>>>>>>>>>>>>> Review comments: >>>>>>>>>>>>>> >>>>>>>>>>>>>>1. >>>>>>>>>>>>>> >>>>>>>>>>>>>>For consistency, we use two spaces for indentation in CSS >>>>>>>>>>>>>>files. Four spaces are used in _dashboard.scss file. The >>>>>>>>>>>>>>configurations are defined in web/.editorconfig file. >>>>>>>>>>>>>>2. >>>>>>>>>>>>>> >>>>>>>>>>>>>>In,dashboard.css Can we return function object in return >>>>>>>>>>>>>>instead of function class itself, this will eliminate the >>>>>>>>>>>>>> need of creating >>>>>>>>>>>>>>function object every time we use info and error? >>>>>>>>>>>>>>3. >>>>>>>>>>>>>> >>>>>>>>>>>>>>On Dashboard, I can see Postgres icon is misaligned >>>>>>>>>>>>>>compared to other icons in Getting Started section. It is >>>>>>>>>>>>>>not related to this patch. adjusting margin top will fix it. >>>>>>>>>>>>>>4. >>>>>>>>>>>>>> >>>>>>>>>>>>>>I tried to test out Error message displayed, but I >>>>>>>>>>>>>>encounter an error(screenshot attached). >>>>>>>>>>>>>>Steps to reproduce: >>>>>>>>>>>>>> - Open pgAdmin4 in browser >>>>>>>>>>>>>> - Connect to PostgreSQL Server, Keep dashboard tab >>>>>>>>>>>>>> open. >>>>>>>>>>>>>> - Navigate to the database which is connected. >>>>>>>>>>>>>> - Now disconnect pgAdmin4 python server. >>>>>>>>>>>>>> ​ >>>>>>>>>>>>>> >>>>>>>>>>>>>> ​Here I mean Stop Python server. I​ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>>1. >>>>>>>>>>>>>> - ​ >>>>>>>>>>>>>> - No error message is displayed on Dashboard because >>>>>>>>>>>>>> it breaks in JS as xhr.responseText is empty. >>>>>>>>>>>>>> However, it might be an existing issue. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Surinder >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 10:40 AM, Wenlin Zhang < >>>>>>>>>>>>>> wzh...@pivotal.io> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Ashesh, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> That's correct. This patch just changed alert style in >>>>>>>>>>>>>>> the 'tabs', such as Dependency and Dependents. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Wenlin >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi < >>>>>>>>>>>>>>> ashesh.va...@enterprisedb.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Surinder, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Please take a look at this patch. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> If I recalls correctly, this patch is related to styling of >>>>>>>>>>>>>>>> the 'tabs' shown on the main window. >>>>>>>>>>>>>>>> Wenlin - please correct me if my understanding is wrong. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks & Regards, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Ashesh Vashi >>>>>>>>>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>>>>>>>>>> <http://www.enterprisedb.com> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>>>>>>>>>> <http://www.linkedin.com/in/asheshvashi> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 8:11 AM, Sarah McAlear < >>>>>>>>>>>>>>>> smcal...@pivotal.io> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi hackers, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Could you please review this patch? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Wenlin and Sarah >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang < >>>>>>>>>>>>>>>>> wzh...@pivotal.io> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi Hackers, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> This patch changes the alert style in the sub-navigation >>>>>>>>>>>>>>>>>> to match style guide. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> Wenlin, Shirley & Sarah >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> ​ >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value

2017-08-17 Thread Akshay Joshi
an empty value is set into the model, So, added a > check to remove the model attribute if the field is an empty string before > data is sent to the server. > > Please find attached patch. > > Thanks, > Surinder > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Unset compression ratio if it is an empty string in B

2017-08-17 Thread Akshay Joshi
Unset compression ratio if it is an empty string in Backup module. Fixes #2582 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7686dee054ef8a77ace02c1c4e4eed65a475602 Author: Surinder Kumar Modified Files

pgAdmin 4 commit: User can not add New Server through Quick links. Fixe

2017-08-17 Thread Akshay Joshi
User can not add New Server through Quick links. Fixes #2634 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9b80dae9c0dc3e054512c16b4c38a98c8980c93 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

2017-08-17 Thread Akshay Joshi
erprisedb.com%5D(mailto:murtuza.zabuaw...@enterprisedb.com)> >> wrote: >> >> Hi, >>> >>> PFA minor patch to fix the issue where add new server functionality >>> through Quick link on Dashboard is broken. >>> RM#2634 >>> >>>

[pgAdmin4][Patch]: Fix RM #2566 Pause/Resume Replay of WAL files are not working with PostgreSQL 10

2017-07-14 Thread Akshay Joshi
Hi Attached is the patch file to fix RM #2566 Pause/Resume Replay of WAL files are not working with PostgreSQL 10. Please review it and let me the comments (if any) -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2566.patch Description

[pgAdmin4][Patch]: Fixed #2545 Partitioned table should be created using 'OF TYPE'

2017-07-10 Thread Akshay Joshi
Hi All Attached is the patch file to fix the RM #2545, where user will be able to create partitioned table using 'OF TYPE' feature of table dialog. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2545.patch Description: Binary data

[pgAdmin4][Patch]: Fixed #2550 declarative partitioning - drop/delete and drop cascade is not working for partition table

2017-07-10 Thread Akshay Joshi
table' and 'reset statistics'. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2550.patch Description: Binary data

Re: Discussion on improving alertify notifications logic

2017-07-27 Thread Akshay Joshi
r so that it is clear that it isn't only > the alertify library, but it's been extended. > Thanks, but If I understand to you correctly calling it pgAdminAlertify will required code changes wherever alertify. is called. > > Rob & Sarah > > On Thu, Jul 27, 2017 at 9:41 PM, Aks

pgAdmin 4 commit: Added support of Declarative Partitioning (Range, Lis

2017-07-07 Thread Akshay Joshi
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10. This allows the user to create partitioned table and it's partitions. - Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal) - Updating browser tree node when

Re: [pgAdmin4][Patch]: Fix the Domain Create dialog issue

2017-08-01 Thread Akshay Joshi
riseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Domain create dialog do not open and Font size issue

2017-08-01 Thread Akshay Joshi
Domain create dialog do not open and Font size issue in Security label control. Fixes #2616 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6717aff8f5f7c782b9d53facb14678b21af9b13e Author: Murtuza Zabuawala

pgAdmin 4 commit: Added missing pgagent file in webpack.config.js Fixes

2017-08-04 Thread Akshay Joshi
Added missing pgagent file in webpack.config.js Fixes #2617 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06a65ecf71ccbbfb20cce86ebc1ad0b4b4289cdd Author: Surinder Kumar Modified Files --

Re: [pgAdmin4][Patch]: RM_ 2620 - Getting error "Violates check constraint" while creating pgAgent job

2017-08-04 Thread Akshay Joshi
me AND (jstkind = 'b'::bpchar OR jstconnstr <> '' > ::text)) > > Please find attached patch and review. > > Thanks, > Surinder > ​ > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Set the database name to blank('') when job type is s

2017-08-04 Thread Akshay Joshi
Set the database name to blank('') when job type is set to batch, while creating pgAgent job. Fixes #2620 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801a05891e94304d267e91adb98a92b5d8ea48cd Modified Files --

pgAdmin 4 commit: Changed the mapping of cell from 'numeric' to 'intege

2017-08-07 Thread Akshay Joshi
Changed the mapping of cell from 'numeric' to 'integer' for integer control as numeric cell has been removed from the code. Fixes #2631 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e418cb838730ce186c620cdf39c064eca02a7d61 Modified Files

Re: [Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar

2017-08-22 Thread Akshay Joshi
gt;> ​ >> Set `Backform.DatetimepickerControl` option `widget positioning > >> vertical` to `bottom` which ensures Datepicker widget expands to bottom >> whenever it is opened. >> >> Please find attached patch and review. >> >> Thanks, >> Surinder >> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Syntax error while saving changes for start/end time,

2017-08-23 Thread Akshay Joshi
Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee20a10e9410f2ce5024a7b8e4fa758706dc52d0 Author:

Re: [pgAdmin4] [pgAgent] [Patch]: RM_ 2657 - Syntax error while saving changes when start/end time is changed from scheduler

2017-08-23 Thread Akshay Joshi
> Hi > > *Issues fixed:* > > - Syntax error while saving changes when start/end time is updating in > Edit mode. > - The data type of `jscstart` should be `timestamptz` not `text`. > > Please find attached patch and review. > > Thanks, > Surinder > --

pgAdmin 4 commit: Unable to add/update variables for columns of a table

2017-08-23 Thread Akshay Joshi
Unable to add/update variables for columns of a table. Fixes #2659 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6e4686a2bf5d9d7db438d209d4d4d6783543ce Modified Files -- .../schemas/tables/column/static/js/column.js |

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Akshay Joshi
Harshal, Can you please rebase the patch, it's not applied with the latest code. On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > > > On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Ad

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Akshay Joshi
It works, sorry for the noise. On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > Harshal, > > Can you please rebase the patch, it's not applied with the latest code. > > On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi < > akshay.jo

[pgAdmin4][Patch] RM 2691 View data option is missing from pgAdmin4 2.0 version

2017-09-18 Thread Akshay Joshi
"visible: false" from js file. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2691.patch Description: Binary data

pgAdmin 4 commit: Filtered Rows dialog not opened from the context menu

2017-09-19 Thread Akshay Joshi
Filtered Rows dialog not opened from the context menu. Fixes #2699 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe757c384bac26ca97e7a6c5d735d0b787ad0796 Modified Files -- web/pgadmin/tools/datagrid/static/js/datagrid.js | 7

[pgAdmin4][Patch] RM 2673 Error not displaying in proper format in User management and Grant Wizard

2017-09-19 Thread Akshay Joshi
Hi Attached is the patch file to fix RM 2673 "Error not displaying in proper format in User management and Grant Wizard". Patch contains fix for Grant Wizard, as fix for user management is already committed. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517M

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-18 Thread Akshay Joshi
t; character and character[] respectively) > were not taken into consideration in sqleditor.js. I have attached updated > patch which fixes this issue. > > > > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com >

pgAdmin 4 commit: Changed array representation and formatting for the d

2017-09-18 Thread Akshay Joshi
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30e701607713edc1ba43173556c911c98fc09eb5 Author: Harshal Dhumal

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

2017-09-11 Thread Akshay Joshi
> - No behavior change to pg and ppas, still use "x-pgsql" >> >> Regards, >> Hao Wang & Teng Zhang >> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Highlighting greenplum keywords in sql editor

2017-09-11 Thread Akshay Joshi
Highlighting greenplum keywords in sql editor Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=512afd66182f463e6ce9515910205dcf0221e58c Author: Teng Zhang Modified Files -- web/package.json

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

2017-09-11 Thread Akshay Joshi
Code looks good to me. Thanks patch applied. On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > > > On Mon, Sep 11, 2017 at 5:34 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Akshay, can you review/commit this please? >&g

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Akshay Joshi
;> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgAdmin4][Patch] RM 2742 Unable to connect to database server with different user and role

2017-09-28 Thread Akshay Joshi
Hi Attached is the patch to fix RM 2742 "Unable to connect to database server with different user and role". -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2742.patch Description: Binary data

Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

2017-08-28 Thread Akshay Joshi
hanged, 18 insertions(+), 39 deletions(-) >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed issue where 'backend_type' column is exist for

2017-08-28 Thread Akshay Joshi
Fixed issue where 'backend_type' column is exist for database server version greater than 10. Issue is regression of RM #2597. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=401e13ca650e06f2ee9c2220d0c7b7dcbbcf6dd6 Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-28 Thread Akshay Joshi
t;>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <sw...@pivotal.io >>>>>>>>>>>> > wrote: >>>>>>>>>>>> >>>>>>>>>>>>> 2-3 days is a lot of valuable engineering time. Is this a >>>>>>>>>>>>> 'drop everything now' kind of feature or can this wait for some >>>>>>>>>>>>> user >>>>>>>>>>>>> validation on a mock up first? >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Most of the time will likely be on the infrastructure to change >>>>>>>>>>>> the display to a subnode control. If you have some cycles to mockup >>>>>>>>>>>> potential layouts for the subnode view and have them validated, >>>>>>>>>>>> please feel >>>>>>>>>>>> free, however, that seems like an awful lot of work to me to >>>>>>>>>>>> display some >>>>>>>>>>>> missing SQL using a standard control. >>>>>>>>>>>> >>>>>>>>>>> Regarding SQL display: Developing simple control to show >>>>>>>>>>> codemirror in disabled state (for now) wont take that much time. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> Part of a product designer's job is to make sure there is a >>>>>>>>>> definitive need for a feature and that the interface for the feature >>>>>>>>>> is >>>>>>>>>> designed in such a way that the user gets all intended value from >>>>>>>>>> it. Time >>>>>>>>>> spent validating now will decrease the time spent later on >>>>>>>>>> redesigning / >>>>>>>>>> reimplementing. >>>>>>>>>> >>>>>>>>>> If everyone is aware of what that value is and confident that how >>>>>>>>>> it'll be displayed is right, there's little risk in starting to >>>>>>>>>> develop it. >>>>>>>>>> If we're wrong, it'll add to feature bloat and detract from the >>>>>>>>>> experience. >>>>>>>>>> >>>>>>>>>> Would Chethana be able to take on some of the design work? It >>>>>>>>>> would be valuable for the dev team to also be part of design process. >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Chethana Kumar >>>>>> Principal UI/UX Designer >>>>>> EnterpriseDB Corporation >>>>>> >>>>>> >>>>>> The Postgres Database Company >>>>>> >>>>>> P: +91 86981 57146 <+91%2086981%2057146> >>>>>> www.enterprisedb.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Akshay Joshi
Greenplum specific DDL and Dashboard display changes. Initial patch by Sarah McAlear. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46c5df4e7bb7abba6896cfb86eed43914a74850a Author: Teng Zhang

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Akshay Joshi
t;>>> a gpdb server. >>>>>>>>>> For this patch specifically, the goal is to improve the >>>>>>>>>> experience for greenplum users so they can get the same information >>>>>>>>>> as >>>>>>>>>> someone connected to a postgres server. >>>>>>>>>> >>>>>>>>>> I do agree that this is a bigger discussion about how we handle >>>>>>>>>> behavior change overall if it's regular postgres or something else. >>>>>>>>>> Let's >>>>>>>>>> talk about how we can restructure this behavior in a wider context. >>>>>>>>>> Are you >>>>>>>>>> open to meeting about it? >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> ~Jing >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Violet. >>>>>>>>>>> >>>>>>>>>>> I don't really like the way this has been implemented. It adds a >>>>>>>>>>> variable which is only used for gpdb. >>>>>>>>>>> >>>>>>>>>>> There are other places in the code where the behaviour is >>>>>>>>>>> changed if the server is ppas or regular postgres. >>>>>>>>>>> >>>>>>>>>>> Candidly I think all of this needs restructuring. >>>>>>>>>>> >>>>>>>>>>> Dave Cramer >>>>>>>>>>> >>>>>>>>>>> On 15 August 2017 at 23:29, Violet Cheng <vch...@pivotal.io> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Any comment on this patch? If no, will it be committed soon? >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Violet >>>>>>>>>>> >>>>>>>>>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear < >>>>>>>>>>> smcal...@pivotal.io> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi Hackers! >>>>>>>>>>> >>>>>>>>>>> This patch enables Greenplum users to see the same charts on the >>>>>>>>>>> dashboard as postgres users. It also adds some additional >>>>>>>>>>> information to >>>>>>>>>>> the DDL that is Greenplum specific and necessary to create a new >>>>>>>>>>> table. >>>>>>>>>>> >>>>>>>>>>> Thanks! >>>>>>>>>>> Sarah >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: 1) Fixed error in alertify.pgNotifier when server con

2017-08-31 Thread Akshay Joshi
1) Fixed error in alertify.pgNotifier when server connection is lost. 2) Change styling of alertify.pgNotifier as we did for success, error and info. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47cf874460dd0fcd0f39af1772e4ba3913020ee1

Re: [pgAdmin4][Patch]: Fixed RM 2844 Tree View Icons

2017-11-05 Thread Akshay Joshi
eDB Corporation >> >> >> The Postgres Database Company >> >> P: +91 86981 57146 <+91%2086981%2057146> >> www.enterprisedb.com >> > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Updated colours of tree view icons, which is to be mo

2017-11-05 Thread Akshay Joshi
Updated colours of tree view icons, which is to be more comfortable in identifying. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2be418706dd2ba86d79d2431b67d47cfd133c6fb Author: Chethana Kumar Modified

pgAdmin 4 commit: Fixed layout of the alertify error message in the que

2018-05-07 Thread Akshay Joshi
Fixed layout of the alertify error message in the query tool. Fixes #3310 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ac3e73daf8121207fe60eefe6db1aba9c1abcc3 Author: Khushboo Vashi Modified Files

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-07 Thread Akshay Joshi
On Thu, May 3, 2018 at 10:19 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Khushboo

pgAdmin 4 commit: Backup, Maintenance and Restore should not be started

2018-05-07 Thread Akshay Joshi
Backup, Maintenance and Restore should not be started if database name contains "=" symbol. Fixes #1220 #1221 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=567f7642348e15d8adb57d683c64e8d8090b77fe Author: Khushboo Vashi

Re: [pgAdmin4][Patch]: Fix layout of the error message in the query tool

2018-05-07 Thread Akshay Joshi
Thanks patch applied. On Mon, May 7, 2018 at 12:53 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the layout of the error message in > the query tool. (Ref RM #3310). > > Thanks, > Khushboo > --

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-14 Thread Akshay Joshi
Hi Dave On which database server you are running this test cases, I have tested it on PG 9.6 On Mon, May 14, 2018 at 5:45 PM, Dave Page <dp...@pgadmin.org> wrote: > > Hi > > On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: &

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-15 Thread Akshay Joshi
Hi Dave On Mon, May 14, 2018 at 6:33 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Mon, May 14, 2018 at 2:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On which database server you are running this test cases

pgAdmin 4 commit: Fixed query tool keyboard issue where arrow keys were

2018-05-09 Thread Akshay Joshi
Fixed query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Fixes #3298 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b86a67a412b9d170ce3ce886adb5aa4f63388b1 Author: Aditya Toshniwal

Re: [pgAdmin4][RM#3298] Query tool shortcut issue

2018-05-09 Thread Akshay Joshi
st you to kindly review. >> >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-09 Thread Akshay Joshi
il on our CI pipelines, which > run Chrome. Please look at this revised patch that accommodates for both > Chrome and Firefox with the wait_for_element_to_reload function. > >> -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3270_v9.patch Description: Binary data

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-08 Thread Akshay Joshi
On Tue, 8 May 2018, 13:35 Dave Page, <dp...@pgadmin.org> wrote: > Could you update the 3.1 release notes to reflect that please? > Sure > > On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied

pgAdmin 4 commit: Updated release note for 3.1

2018-05-08 Thread Akshay Joshi
Updated release note for 3.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=39ea7c2916e699adc9de3e023ed63d64ab331936 Modified Files -- docs/en_US/release_notes_3_1.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Fixed issue where icon for Partitioned tables was the

2018-04-26 Thread Akshay Joshi
Fixed issue where icon for Partitioned tables was the same as Non Partitioned tables for GreenPlum database. Fixes #3308 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=966279c1b3cc9137ed6bb7ba21e76d0981178b3c Author: Joao De Almeida Pereira

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-11 Thread Akshay Joshi
Hi Dave On Thu, May 10, 2018 at 2:03 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, May 9, 2018 at 2:55 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Wed, May 9, 2018 at 6:19 PM, Dave Page <dp...@pgadmin.o

pgAdmin 4 commit: Fixed pep8 issue for last commit.

2018-05-18 Thread Akshay Joshi
Fixed pep8 issue for last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28126a0a0dd242620df137a88f8b05e78c2c230c Modified Files -- web/config.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

pgAdmin 4 commit: Correct the logic to set the SUPPORT_SSH_TUNNEL flag

2018-05-17 Thread Akshay Joshi
Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is set the False in local config file, then we should not override it. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb0c322ccf80ab9a3ff322af13e1f59e9baa8a82 Modified Files

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-16 Thread Akshay Joshi
Hi Hackers, On Tue, May 15, 2018 at 9:52 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > Hi Joao > > On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Akshay, >> >> This patch is flaky; it

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-18 Thread Akshay Joshi
his separately and show it in the alertify panel. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed issue where 'Identity file' control of SSH Tunn

2018-05-17 Thread Akshay Joshi
Fixed issue where 'Identity file' control of SSH Tunnel tab is enabled when database is connected and 'Use SSH tunneling' flag is set to No. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=719938a14c1b6bdae96aff82a2f6a02901a7ca8d Modified

[pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-15 Thread Akshay Joshi
Hi Hackers, Attached is the patch to capture the notification from psycopg2 and displayed it in "Messages" tab of query tool. Added feature test to cover this scenario. Refer Notification.png file to how it looks in "Messages" tab. Please review it. -- *Akshay Joshi* *Sr

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-15 Thread Akshay Joshi
creen, stacktrace) > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:132> > TimeoutException: Message: Timed out waiting for element to exist > > > All the failures are related to query_tool_notify_statements.

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-22 Thread Akshay Joshi
Hi Dave On Tue, May 22, 2018 at 2:02 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Tue, May 22, 2018 at 9:13 AM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < >> akshay.jo...@enterpr

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-26 Thread Akshay Joshi
where all the notify messages will be recorded with the timestamp and payload. Please review the latest patch. On Tue, May 22, 2018 at 2:43 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Tue, May 22, 2018 at 10:01 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wr

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-21 Thread Akshay Joshi
Hi Dave On Fri, May 18, 2018 at 4:56 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, May 18, 2018 at 12:11 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, May 18, 2018 at 3:58 PM, Dave Page <dp...@pgad

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-22 Thread Akshay Joshi
Hi All Please ignore the previous patch. Attached is the latest one. On Tue, May 22, 2018 at 11:37 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > As per suggestion by Dave, I have modified the logic and now notifications > are popped up in ale

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-22 Thread Akshay Joshi
o')' query (with payload). - Go to the query tool window from where 'LISTEN' was executed and run any other query. On Mon, May 21, 2018 at 1:36 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > Hi Dave > > On Fri, May 18, 2018 at 4:56 PM, Dave Page

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Akshay Joshi
On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for the Feature #2686 Property to switch >> lower

[pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog

2018-06-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch for Feature #3388 Allow to set the connection timeout on the server properties dialog. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3388.patch Description: Binary data

[pgadmin4][Patch]: RM #3361 Create database dialog does not show template0 and template1 database in Template dropdown

2018-06-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch for RM #3361 Create database dialog does not show template0 and template1 database in Template drop down. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3361.patch Description: Binary data

[pgadmin4][Patch]: Support for create multiple test classes in one test file

2018-06-12 Thread Akshay Joshi
implementation it will run the test cases for *TestZ* class. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* multiple_class_support.patch Description: Binary data

[pgadmin4][Patch]: Remove extra space from create script for Procedures.

2018-06-15 Thread Akshay Joshi
Hi Hackers, Attached is the patch to remove extra space from create script for Procedures. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Remove_Extra_Space_Procedure.patch Description: Binary data

[pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL

2018-06-15 Thread Akshay Joshi
Hi Hackers, Attached is the patch for RM #3356 pgAdmin 4 does not include schema name in generated package SQL. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3356.patch Description: Binary data

[pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

2018-05-31 Thread Akshay Joshi
at the top of the function then why to open that again using *fdopen() **in the first call. * Tested the patch with Python 3.5 and 3.6, please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3277.patch Description: Binary data

pgAdmin 4 commit: Fixed ordering of changes in release note and added o

2018-05-31 Thread Akshay Joshi
Fixed ordering of changes in release note and added one missing entry. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55232b0944b11b954b9611acf7add801736725a7 Modified Files -- docs/en_US/release_notes_3_1.rst | 9 + 1

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-29 Thread Akshay Joshi
hen the previous one. Attached is the modified patch. Please review it. > Thanks > Anthony && Joao > ​ > > On Mon, May 28, 2018 at 1:34 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hakers, >> >> On my last patch feature tests were

[pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

2018-05-29 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3355_v1.patch

[pgAdmin4][Patch] RM 3353 and 3357

2018-05-28 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix following RMs: - #3353 Correct messages should be displayed while rename the maintenance database. - #3357 User can not drop database on ssh tunnel connection Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20

[pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool

2018-06-05 Thread Akshay Joshi
Hi Hackers, Attached is the minor patch to move 'Notifications' tab before "Query History" in Query Tool. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Move_Notifications_Tab.patch Description: Binary data

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-27 Thread Akshay Joshi
database and don't know why it is failing. On Sat, May 26, 2018 at 5:47 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > Hi Hackers, > > As per suggestion by Dave and discussion with in the team, I have modified > the logic again. Following are the modifications

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

2018-05-29 Thread Akshay Joshi
ind port returned by SSH Tunnel module. Khushboo has send the patch where she wrote test cases for Utility module (not committed yet) and anyways we can't replicate the SSH Tunnelling scenario using test cases. > > Thanks > Anthony && Joao > > On Tue, May

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-25 Thread Akshay Joshi
On Mon, Jun 25, 2018 at 4:43 PM, Dave Page wrote: > Hi > > On Fri, Jun 22, 2018 at 6:39 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote: >> >>> Hi >>> &g

[pgadmin4][Patch]: Fixed RM 3442, 3443, 3444 Drop options not available.

2018-06-25 Thread Akshay Joshi
Hi Hackers, Attached is the patch to RM 3442, 3443 and 3444 related to Drop options not available for Collations, Packages, Synonyms, Rules, Check Constraint and Domain Constraints. This are regressions. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058

pgAdmin 4 commit: Updated extension upgrade message. Fixes #3445

2018-06-26 Thread Akshay Joshi
Updated extension upgrade message. Fixes #3445 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08e4cdf2ac5c843e383e7cf1603c144d181517ce Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2 +- 1 file changed, 1

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-20 Thread Akshay Joshi
On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote: > Hi > > On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for Feature #3273 Add ability to sort in the Select >> Fi

[pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file

2018-06-21 Thread Akshay Joshi
to fix that. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Auto_discover_exception.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-03 Thread Akshay Joshi
Hi Dave, On Mon, Jul 2, 2018 at 4:10 PM, Dave Page wrote: > Hi > > On Sat, Jun 30, 2018 at 9:15 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Jun 29, 2018 at 7:45 PM, Dave Page wrote: >> >>>

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-06-30 Thread Akshay Joshi
Hi Dave On Fri, Jun 29, 2018 at 7:45 PM, Dave Page wrote: > > > On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote: >> >>> Hi

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

2018-05-01 Thread Akshay Joshi
yboard.js file(some one letter variables >>> and other code) >>> >>> >>> >>> Thanks >>> Joao >>> >>> On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>&

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

2018-05-02 Thread Akshay Joshi
Thanks patch applied. On Wed, May 2, 2018 at 11:16 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch which fixes the linter issues. > > Thanks, > Khushboo > > On Wed, May 2, 2018 at 11:10

  1   2   3   4   5   6   7   8   >