pgAdmin 4 commit: Properly handle bytea[], and 'infinity'::real/real[].

Properly handle bytea[], and 'infinity'::real/real[]. Fixes #2498. Fixes #2502. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2ba57c1abfda02241d969c4caa1ce0bf24cfc09 Author: Murtuza Zabuawala Modified Files -- .../feature_tests

Re: [pgAdmin4][PATCH] Fix handling of real type

of real type. >> RM#2502 >> >> Steps to re-produce: Below given query fails to render result in Query >> tool, >> SELECT 'Infinity'::real, '{Infinity}'::real[] >> >> Also updated PG Data type feature test for the same. >> >&

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

mentation about this command. make: *** [check-feature] Error 1 On Mon, Jun 19, 2017 at 8:28 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers, > > This patch will upgrade Slickgrid Version to 2.3.7 to include a PR we > created for it. This PR made SlickGrid Cell Decorator and Cell Se

pgAdmin 4 commit: No need for the menu icon to link to the homepage, as

No need for the menu icon to link to the homepage, as pgAdmin is a SPA. Fixes #2479 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34518d328e836758c87c40628cf8738e1756962e Author: Murtuza Zabuawala Modified Files -- web/pgadmin/

Re: [pgAdmin4][PATCH] Fix clicking on the "pgAdmin 4" header logo shows a empty dialog

oute to to home page. > RM#2479 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Create a runner for the feature tests.

Create a runner for the feature tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd917f234870a776d0cbe4631360a30445ae6591 Modified Files -- ci/run_feature_tests.sh | 37 + ci/run_python_test

pgAdmin 4 commit: Run yarn tasks where required to run the tests.

Run yarn tasks where required to run the tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5616c786926f7717fea89d681f7b28d8d455181 Modified Files -- ci/run_feature_tests.sh | 4 ci/run_jasmine_tests.sh | 3 ++- 2 files cha

pgAdmin 4 commit: Correct the v10 template path.

Correct the v10 template path. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9829d74a043e0b24f8d0caac3ea1ba9336680ff6 Modified Files -- web/pgadmin/browser/server_groups/servers/tests/test_check_recovery.py | 2 +- 1 file changed,

pgAdmin 4 commit: Install the Yarn deps before trying to bundle.

Install the Yarn deps before trying to bundle. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf5a2252af4589fc91a8c567fcbb216b0100e353 Modified Files -- ci/run_feature_tests.sh | 1 + 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Increase the default size of the Grant Wizard to enab

Increase the default size of the Grant Wizard to enable it to properly display privileges at the default size on smaller displays. Fixes #2013 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0202228d0820e27645e05c73908352b58c8c30f Author: Mur

Re: [pgAdmin4][PATCH] To increase the size of Grant Wizard dialog

768 screen resolution. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Consolidate selection colors in the drop down menu an

Consolidate selection colors in the drop down menu and browser tree to match the light blue agreed upon in the styleguide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=281b67952a94bc1599536c2b6c469252f233aa69 Author: Shruti B Iyer Modifie

Re: [pgAdmin4][PATCH] Consolidating Selection Colors

Thanks, patch applied. On Tue, Jun 20, 2017 at 9:39 PM, Shruti B Iyer wrote: > Hi Hackers! > > Attached is a patch that consolidates selection colors in the drop down menu > and browser tree to match the light blue agreed upon in the styleguide. > > Thanks, > Shirley and Sh

pgAdmin 4 commit: Vendorize React. This is required at this time becaus

Vendorize React. This is required at this time because we need to modify it to work with QtWebKit. The patch to do that has been submitted upstream; if accepted, we can un-vendorize again. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a45b

pgAdmin 4 commit: Fix React to work with QtWebKit

Fix React to work with QtWebKit We learned that the underlying issue was related to react-dom's SyntheticEvent.augmentClass function being undefined. This seems to be caused by attempted property assignment after the SyntheticEvent had been replaced by a Proxy of itself. This works fine in Chr

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

am has the capacity for that. If yours does, then it's certainly worth exploring. Ashesh is also planning to spend a little more time looking more deeply at Electron/Node-Webkit as well as other options, once he's finished his current work. Other thoughts/experiences are definitel

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

etting a startup time of ~20 seconds or less in my test VM and on my 16GB i7 SSD based desktop under Windows 10 - Ensuring that node expansion/load times are basically instant with a local database server. > Thanks! > João & Sarah > > On Wed, Jun 21, 2017 at 6:37 AM, Dave Page wrote:

pgAdmin 4 commit: Handle missing/dropped synonyms gracefully. Fixes #25

Handle missing/dropped synonyms gracefully. Fixes #2503 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9736cbd74c723ce914fa3beaafe03fd284daf45 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/synonyms/__

Re: [pgAdmin4][PATCH] To fix the issue in Synonym node

erprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update MatView and pgAgent modules to work with recen

Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9f6fb95456a540287ef7aca02ff885068b64cd5 Author: Murtuza Zabuawala Modified Files -- .../

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

>> wrote: >>> >>> Hi, >>> >>> PFA minor patch to fix the issue where create dialog opens blank due to >>> JS error. >>> RM#2504 >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

request. > > > Thanks, > Khushboo -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Maintain a client-side cache of preference values, po

Maintain a client-side cache of preference values, populated using an async call. Fixes #2487 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67fd119de834afd022f95c8c153a3b0c8c7b7fae Author: Khushboo Vashi Modified Files -- .../b

Re: [pgadmin-hackers][patch] History Detail Pane

PM, George Gelashvili wrote: > Hi > > We rebased this on top of latest master. > > Cheers, > Matt and George > > On Thu, Jun 15, 2017 at 10:43 AM, Dave Page wrote: >> >> Hi >> >> We use Qt 5.8 at the moment, with the updated QtWebKit TP5 release >> from

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

e stays the same. Let me know your thoughts if any. > > Shirley & Shruti > > On Wed, May 31, 2017 at 3:02 PM Shirley Wang wrote: > >> On Wed, May 31, 2017 at 11:55 AM Dave Page wrote: >> >>> On Wed, May 31, 2017 at 2:27 PM, Shirley Wang wrote: >>>

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Khusboo, > > Looks like given change have broken Backup, Restore, Import/Export & > Maintenance, even if I have binary path set it is throwing an error. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Compa

pgAdmin 4 commit: Ensure default values are honoured when adding/editin

Ensure default values are honoured when adding/editing columns. Fixes #1860 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=137bae1b0494a7c763d302f5f5e652e5201abdea Author: Murtuza Zabuawala Modified Files -- .../foreign_tables/te

Re: [pgAdmin4][PATCH] To fix the issue in column module

lar issue in foreign table module. > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix preferences handling for utilities.

Fix preferences handling for utilities. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33e75d24f82828c6925b88fecf0eac35a8480bbd Author: Khushboo Vashi Modified Files -- web/pgadmin/preferences/__init__.py | 2 +- web/pgadmin/utils

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, patch applied. On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached fix for the same. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 2:18 PM, Dave Page wrote: >> >> Hmm, yes - and it's not giving the no

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

; false Both of those are valid addresses. Note that I've only eye-balled the patch so far, as I was unable to apply it without manual work. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix import/export to work as expected with TSV data.

Fix import/export to work as expected with TSV data. Fixes #1934 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ab637c7ab9dd7b23692dd2b6eda3b983fa7780f Author: Murtuza Zabuawala Modified Files -- .../tools/import_export/template

Re: [pgAdmin4][Patch] To fix the in Import/Export module

delimiter(ie - no delimiter, let > copy command handle it) for csv & text file format user was forced to select > delimiter. > RM#1934 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Da

pgAdmin 4 commit: Additional preference fix.

Additional preference fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25282f3094a3727fd194420cb77bd65a42838995 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/js/check_node_visibility.js | 2 +- 1 file changed, 1 i

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, applied. On Thu, Jun 22, 2017 at 2:43 PM, Khushboo Vashi wrote: > Hi Dave, > > One more fix for this module. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 4:49 PM, Dave Page wrote: >> >> Thanks, patch applied. >> >> On Thu, Ju

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

gt; (who reported the issue) > > I just re-based it against current code. Isn't that code required? We do need plugin_debugger to be present for global (indirect) debugging to work. I suppose it may not be required for direct debugging, but I haven't tested that. -- Dave Page B

pgAdmin 4 commit: Ensure the relevant Makefile targets install node mod

Ensure the relevant Makefile targets install node modules before running. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b98fcaa829aa71493af8419d6d97a5c8a3b74302 Author: Matthew Kleiman Modified Files -- Makefile | 11 +++

pgAdmin 4 commit: Update Slickgrid to 2.3.7. As this version includes a

Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94aa5487fb9c4e24b3b06e02e40bd3f9829b543

pgAdmin 4 commit: Fix cell selection window alignment for the updated S

Fix cell selection window alignment for the updated SlickGrid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9af29364c7414128d091d57b020750657946cc8c Author: Matthew Kleiman Modified Files -- web/pgadmin/static/js/selection/xcel

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

sks. > > Thanks > Matt && João > > On Tue, Jun 20, 2017 at 5:23 AM, Dave Page wrote: > >> Hi, >> >> This fails tests: >> >> (pgadmin4)piranha:pgadmin4 dpage$ make check-feature >> cd web && yarn run bundle && python regre

pgAdmin 4 commit: Fix removal of sizes from column definitions. Fixes #

Fix removal of sizes from column definitions. Fixes #2155 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a4945ff9e9a3cb7cf9dc0c4f042f5502d76464f Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/tables/templates/

Re: [pgAdmin4][Patch] To fix the issue in Column module

uawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add access keys for top level menus.

Add access keys for top level menus. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fabf4764b51c9978c896ce93733b474a3c3a8ff Modified Files -- web/pgadmin/browser/templates/browser/index.html | 12 ++-- 1 file changed, 6 in

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

n 23, 2017 at 1:20 PM, Dave Page wrote: >> >> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala >> wrote: >> > Hi, >> > >> > PFA patch to fix the issue in Debugger module where it was unable to >> > start >> > debugging if

pgAdmin 4 commit: Tidy up About box formatting, 'cos it's been annoying

Tidy up About box formatting, 'cos it's been annoying me for ages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92b1b1365e9b82bcc7ff201f94496b94f1ae8759 Modified Files -- web/pgadmin/about/templates/about/index.html | 10 +--

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

en in markup. > Where are you seeing these changes? I can't spot them in the diff (though, I've only looked at changes to our code). > Thanks, > Surinder > > > On Fri, Jun 23, 2017 at 2:08 PM, Dave Page wrote: > >> Thanks - all applied! >> >> On

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

be made there, patches should be sent upstream. We don't want to modify (and thus have to vendorise) 3rd party code unless it's absolutely essential. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Wait for the Tools menu to be populated when running

Wait for the Tools menu to be populated when running the feature tests, instead of failing. Fix by Khushboo, based on Harshal's previous work. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b6d3369b31547f5042428a579aa92a1726ba7b5 Author: Kh

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala > wrote: >> >> Yes, I'm looking into it, I will send updated patch. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Compa

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

pply. If memory serves, this normally happens if you forget to use --binary when creating the diff. Can you send an updated version please? On Fri, Jun 23, 2017 at 3:59 PM, Atul Sharma wrote: > Hi, > > Please find updated patch. > > Regards, > Atul > > On Thu, Jun 22, 2017

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Harshal, When can we expect an updated version of this patch? I think it's important to get this into the next release. Thanks! On Fri, Jun 16, 2017 at 10:55 AM, Dave Page wrote: > Hi, > > That's better - the failures are far less random now :-). I got the > following

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

h for the feature #2506: Allow the dashboard > panel to be closed. > > Thanks, > Khushboo -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

working. This is fixed. > > Please find attached patch. > > Thanks, > Surinder Kumar -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in Sqleditor module

ed sqleditor.js, so declared those > variables before using them. > > Please find attached patch. > > Thanks, > Surinder Kumar -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Use client-side url_for in the sql editor and data gr

Use client-side url_for in the sql editor and data grid modules. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cfb4b115732f353bc0bf723d87968ed250af063f Author: Surinder Kumar Modified Files -- web/pgadmin/tools/datagrid/__init__

pgAdmin 4 commit: Ensure revoked public privileges are displayed in the

Ensure revoked public privileges are displayed in the RE-SQL for functions. Fixes #2507 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4e77deda466f460debbe37044d44a0c8ad456fa Author: Khushboo Vashi Modified Files -- .../databas

Re: [pgAdmin4][patch]: Fixed RM #2507 : REVOKE privileges do not display in SQL tab for the function

Thanks, patch applied. On Mon, Jun 26, 2017 at 3:25 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the RM #2507: REVOKE privileges do not > display in SQL tab for the function > > Thanks, > Khushboo > > -- Dave Page Blog: http://p

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

I'm sorry, it needs rebasing again. If you can do it quickly, I'll make sure it's the next patch I work on in that area. Thanks. On Mon, Jun 26, 2017 at 5:16 AM, Harshal Dhumal wrote: > Hi Dave, > > Please find updated rebased patch for RM2137 > > On Fri, Jun

pgAdmin 4 commit: Ensure saved passwords are effective immediately, not

Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27bc5c803f1b92dd8e498e751e2e3bf17f558d62 Author: Khushboo Vashi Modified Files -

Re: [pgAdmin4][Patch]: Fixed RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option.

Thanks, patch applied. On Mon, Jun 26, 2017 at 5:24 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM #1920 - [Web Based] Unexpected > behaviour observed when connect server with save password option. > > Thanks, > Khushboo --

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

">'+panel_title+''); >>queryToolPanel.icon('fa fa-bolt'); >> >> Surinder is looking into this. I'm holding patch for RM2137 (on demand >> loading of result set) until this is fixed. >> >> Thanks, >> >> >> &g

pgAdmin 4 commit: Un-break query tool feature tests.

Un-break query tool feature tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4781cdcbfcdf4436a71fdc9e6e1782303d1bc2 Author: Surinder Kumar Modified Files -- .../tools/datagrid/templates/datagrid/js/datagrid.js | 18 ++---

pgAdmin 4 commit: Add support for the hostaddr connection parameter. Th

Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15cb9fc35b41736a331a452b9303a79e8f13ee36 Author: Atul Sharma Modified Fi

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

gex approach. > Attached is the patch for the same. Please review. > > Regards, > Atul > > On Sun, Jun 25, 2017 at 6:32 PM, Dave Page wrote: >> >> Hi >> >> There are still validation issues unfortunately; see the attached >> screenshot. >> &g

Re: [pgadmin-hackers][patch] History Detail Pane

atch. > >>> >>> >>>> 4. In 'codemirror.jsx', setInterval is used to bind >>>> hydrateWhenBecomesVisible function after every 100ms. Can setTimeout be used >>>> as it needs to bind only once ? >>>> Also if setInterval is used, in componentWillUnmount clearInterval(...) >>>> should be implemented. >>> >>> >>> We actually need to poll, as otherwise the codemirror element will render >>> with its last state (so, incorrect query history) >>> >>>> 5. The text like 'Rows Affected' or 'Duration' should be wrapped in >>>> 'gettext' for translation? >>> >>> >>> We are working on using translations in React components. This needs >>> additional effort and we'll send this in a separate patch. >>> >>> Thanks >>> Shruti and George >> >> > > Thanks, > Joao and Shruti -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Use on-demand loading for results in the query tool.

Use on-demand loading for results in the query tool. Fixes #2137 With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c65158312d6db6425abfde67d4f22

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

eer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Mon, Jun 26, 2017 at 5:22 PM, Dave Page wrote: >> >>> I'm sorry, it needs rebasing again. If you can do it quickly, I'll >&

Re: [pgadmin-hackers][patch] History Detail Pane

t; > We believe that this should be a conversation to have next Friday in the > Hackers Community Forum. In the meanwhile we hope this is not a blocker to > the merge of this patch. > > >> >>> ​4. In 'codemirror.jsx', setInterval is used to bi

pgAdmin 4 commit: Allow the user to close the dashboard panel. Fixes #2

Allow the user to close the dashboard panel. Fixes #2506 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a87ee6d059e478a9ed6bea4fa628e93e1ce46c50 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/panel.js

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Thanks, patch applied. On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Jun 26, 2017 at 5:08 PM, Dave Page wrote: > >> Hi >>

pgAdmin 4 commit: Add preferences to enable brace matching and brace cl

Add preferences to enable brace matching and brace closing in the SQL editors. Fixes #2513 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b49bb8b220e2dd28641e2b424e225e6612f147b Author: Murtuza Zabuawala Modified Files -- web/p

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

riseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

init (browser.js:386) at (index):278 at Object.execCb (require.min.js:29) at Z.check (require.min.js:18) On Tue, Jun 27, 2017 at 9:21 AM, Dave Page wrote: > Thanks, patch applied. > > On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: &

pgAdmin 4 commit: Revert "Allow the user to close the dashboard panel.

Revert "Allow the user to close the dashboard panel. Fixes #2506" This reverts commit a87ee6d059e478a9ed6bea4fa628e93e1ce46c50. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96412b32196c0e4da2104d323a79106d43265606 Modified Files --

pgAdmin 4 commit: Add stylesheet to override brace matching styles, mis

Add stylesheet to override brace matching styles, missed from the feature commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e413186d239150cc993ac100601c10ded1000400 Modified Files -- web/pgadmin/static/css/codemirror.overrid

pgAdmin 4 commit: Overhaul the query history tab to allow browsing of t

Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282 Patch by Joao and the team at Pivotal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f5541205936e32b08a2183f00173a0c64019c8e Author: Joao Pedr

Re: [pgadmin-hackers][patch] History Detail Pane

Thanks - patch applied (just in time for Raffi's & my talk)! On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Yep, > please see attached > > On Tue, Jun 27, 2017 at 9:11 AM, Dave Page wrote: > >&

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Thanks, patch applied. On Tue, Jun 27, 2017 at 4:21 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave > > Please find updated patch, > > On Fri, Jun 23, 2017 at 7:09 PM, Dave Page wrote: > >> Hi >> >> I'm unable to proper

pgAdmin 4 commit: Allow non-superusers to debug their own functions and

Allow non-superusers to debug their own functions and prevent them from setting global breakpoints. Fixes #2162 Based on a patch from Kit Yam Tse Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9fa093d4b988403f8350f06958951272a5304e1 Author:

pgAdmin 4 commit: Update preferences docs.

Update preferences docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0066d60066d3a2297bbec0fa1acbcd9d0d858f8 Author: Murtuza Zabuawala Modified Files -- docs/en_US/images/preferences_sql_options.png | Bin 49360 -> 232229 byte

pgAdmin 4 commit: Fix image size.

Fix image size. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed5c74affece560138d79dab3245592ee0b60e64 Modified Files -- docs/en_US/images/server_advanced.png | Bin 75902 -> 41923 bytes 1 file changed, 0 insertions(+), 0 deletion

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

PostgreSQL Company > > On Tue, Jun 27, 2017 at 7:43 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Sure Dave, I'll do the needful. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Ente

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

> On 27 Jun 2017, at 17:18, Robert Eckhardt wrote: > > > >> On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira >> wrote: >> Hello Hackers, >> >> When we started the app we noticed some change in the front end. >> >> The line numbers in the Editor: >> - We noticed a bug with t

pgAdmin 4 commit: Fix encoding issue when saving servers. Fixes #2518

Fix encoding issue when saving servers. Fixes #2518 Patch by Khushboo, based on a suggested fix from Ladislav Jech Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=301798d87a25e7ed2290af909a814a89107fd667 Author: Khushboo Vashi Modified Files

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

bject to str implicitly >>>> 2017-06-27 13:21:53,031: INFO werkzeug: 127.0.0.1 - - [27/Jun/2017 >>>> 13:21:53] "POST /browser/server/obj/2/ HTTP/1.1" 410 - >>>> 2017-06-27 13:22:49,936: INFO werkzeug: * Detected change in >>>> '/

pgAdmin 4 commit: A number of minor cleanups to the recent changes to t

A number of minor cleanups to the recent changes to the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7389744ecff66cb070c118682992d9c5cb5b04ee Author: Harshal Dhumal Modified Files -- web/pgadmin/feature_tests/view_d

Re: Tree view icon samples

Hi > On 28 Jun 2017, at 12:41, Chethana Kumar > wrote: > > Hi Team, > > I am coming up with some sample icons for Tree View Control. > > Thought process behind the concept - > > 1. Included EDB color brand feel (gray and blue colors) You mean pgAdmin colour brand :-). EDB is orange & black.

Re: Tree view icon samples

ent types of colour blindness. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][Patch] Change alert styling

in the > app where alertify.success, alertify.notify (with the type 'error' or > 'success') and alertify.error are called. > > What is the advantage of this over simply overriding the existing styles? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Tree view icon samples

s > application for color blind testing. > Talk to IT please (don't forget this isn't an internal mailing list :-) ) > > Or do I have any other way to install the app, please suggest. > > Thanks and Regards, > Chethana kumar > > On Thu, Jun 29, 2017 at 6:05 AM,

Re: [RM2522] Improve grid/column select all operation

qleditor do not support overlapped row selection >> so we can simply cancat rows from different ranges without worrying about >> overlapped row selection. >> >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >&

Re: [RM2522] Improve grid/column select all operation

ise PostgreSQL Company > > On Fri, Jun 30, 2017 at 12:07 PM, Dave Page wrote: > >> Hi >> >> On Thursday, June 29, 2017, Harshal Dhumal > om> wrote: >> >>> >>> >>> On Thu, Jun 29, 2017 at 4:33 PM, Harshal Dhumal < >>> h

pgAdmin 4 commit: Improve speed of Select All in the results grid. Fixe

Improve speed of Select All in the results grid. Fixes #2522 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d653129108179af270a5cd6e65b758d437f6176 Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/selection/range_s

Re: [RM2522] Improve grid/column select all operation

es). > > Ah, I see. In that case, patch applied. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Thanks - seems to work for me :-). Patch applied. On Thu, Jun 29, 2017 at 1:35 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Jun 28, 2017 at 7:08 PM, Dave Page wrote

pgAdmin 4 commit: Allow the dashboard panel to be closed. Fixes #2506

Allow the dashboard panel to be closed. Fixes #2506 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=501120701eecfda0fed14dcc11edf54f2ac333f3 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/panel.js

pgAdmin 4 commit: Update alertify alerts to use the styling defined in

Update alertify alerts to use the styling defined in the styleguide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a30a86e7d5e562040500f448fbb0d143ff2cff9 Author: Joao Pedro De Almeida Pereira Modified Files -- .../servers/data

pgAdmin 4 commit: Add support for SCSS building in webpack.

Add support for SCSS building in webpack. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba3ab7b322ef940a53e2e4309b39855d1bac0b66 Author: Joao Pedro De Almeida Pereira Modified Files -- web/package.json | 3

pgAdmin 4 commit: Update alertify alerts to use the styling defined in

Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2d2075d81718ec02550fb592851aa330d327b24 Author: Joao Pedro De Almeida Pereira Mo

Re: [pgadmin-hackers][Patch] Change alert styling

imply override the styles because we are adding an icon to the > alert. So since we have to add a wrapper anyway we decided to style it like > we normally would. > > Thanks, > João & Sarah > > On Wed, Jun 28, 2017 at 8:51 PM, Dave Page wrote: > >> Hi >> &g

  1   2   3   4   5   6   7   8   9   10   >