Re: Build failed in Jenkins: pgadmin4-master-python33 #207

ResourceGroupsGetTestCase (Get resource groups) > ViewsAddTestCase (Add materialized view under schema node) > ViewsGetTestCase (Get materialized view under schema node) > ResourceGroupsAddTestCase (Add resource groups) > ResourceGroupsPutTestCase (Put resource groups) > ViewsUpdateTestCase (Update materialized view under schema > node) > ViewsDeleteTestCase (Delete materialized view under schema > node) > ResourceGroupsDeleteTestCase (Delete resource groups) > EventTriggerDeleteTestCase (Fetch Event Trigger Node URL) > EventTriggerPutTestCase (Fetch Event Trigger Node URL) > > == > > ERROR: Error detected when running the Python tests. > ERROR: Error detected when running the Python tests. > Build step 'Execute shell' marked build as failure > > Thanks. -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

Hi Ashesh, Please look into this as Dave is on leave. Thanks. On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for UUID creation issues with test > objects for FTS c

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

Fri, Aug 18, 2017 at 4:54 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh < >> navnath.gad...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find t

pgAdmin4: Cleanup in role dependency test cases

is safe to manually remove the user as it is not of any use more. Please find the patch. Thanks. -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company role_dependencies_tests_modification_v1.patch Description: Binary data

pgAdmin4: Patch for RM#3060

Hi Dave, Please find the patch for function name quoting in SQL tab for functions.(RM#3060 ) Files affected: pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py pgadmin/browser/server_groups/servers/databases/schema

Re: Import/export servers

://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Regards, Navnath Gadakh

Re: Import/export servers

ignore previous, use self.assertEqual(a,b) instead of self.assertTrue(a == b) On Tue, Nov 20, 2018 at 10:46 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > small feedback, > In the tests, instead of self.assertTrue(a == b) use self.assertEqual(a == > b) which will gi

[pgAdmin4][RM3961] - Exclude HTTPExceptions from all_exception_handler

Hi Hackers, Please find the attached patch for RM-3961. This is improvement to commit 1f298590400cf5d2921a07e200086e16cc22f72c Thanks! -- Regards, Navnath Gadakh RM-3961_v1.patch Description: Binary data

RE-SQL tests patch for packages node

Hi Dave, I have attached the patch for RE-SQL test cases for *Packages* node. Thanks! -- *Regards,* *Navnath Gadakh* re_sql_packages_tests_v1.patch Description: Binary data

Re: RE-SQL tests patch for packages node

>> Hi Navnath >> >> I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. >> Attached is the modified patch which fix the issue. >> Please work on child node (functions, procedure and variables) of >> Packages on top of modified pa

Re: RESQL test cases for view node

Hi Hackers, > > Please find here attached patch for reverse engineering test cases for > view node. > Please review it and give your feedback. > > -- > > > Thanks, > > Usman Muzaffar > QA Team > EnterpriseDB Corporation > -- *Regards,* *Navnath Gadakh*

Re: RE-SQL tests patch for packages node

Hi Dave, Please find the patch for M-SQL test cases for *Packages* module. Thanks! On Fri, Jul 12, 2019 at 4:02 PM Dave Page wrote: > Thanks, applied. > > On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi D

Re: RE-SQL tests patch for packages node

; Done. > >- Delete packages is missing in json file. > > Done. > >- Add test cases to revoke privileges(delete all the privileges). >Check Languages node for reference. > > Done. > > On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh < > navnath.gad...

Re: RE-SQL tests patch for packages node

t; >>>- Delete packages is missing in json file. >>> >>> Done. >> >>> >>>- Add test cases to revoke privileges(delete all the privileges). >>>Check Languages node for reference. >>> >>> Done. >> >>>

[pgAdmin][RM5048] : code coverage tool

file under /regression directory(details mentioned in README) Run coverage With all modules run 'python runtests.py --coverage --exclude feature_tests' With specific module run 'python runtests.py --pkg browser.server_groups.servers.tests --coverage' Thanks

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Khushboo, I think there is no use of +if app is not None: +AuthSourceRegistry.load_auth_sources() + in get_auth_sources() function. On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to support

[pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hello Hackers, Please find the attached patch for below fixes: - Added validation for table row data that should not be larger than the field size. - Rearrange the existing functions to add validation. - Added test cases. Regards, Navnath Gadakh rm_5210_v1.patch Description: Binary data

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

lic.account SET username = %(username)s WHERE user_id = 1;", {"username": "username-test-123"}) cur.execute("COMMIT;") except Exception as e: print('Exception : {0}'.format(e)) *Output:* Exception : value too long for type character varying(5) agai

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

gt; On Wed, Apr 15, 2020 at 3:06 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Apr 15, 2020 at 2:48 PM navnath gadakh < >> navnath.gad...@enterprisedb.com> wrote: >> >>> Hello Hackers, >>> >&g

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

every types supported by PG/PEM. >> > and - types from custom extensions. > So - no to that. > > — Ashesh > >> >> — Ashesh >> >> >>> >>> On Wed, 15 Apr 2020, 18:08 Dave Page, >>> wrote: >>> >>>> Removing

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

of >> API/Features tests remains the same. >> >> >> Thanks, >> Yogesh Mahajan >> QA - Team >> EnterpriseDB Corporation >> >> Phone: +91-9741705709 >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Regards, Navnath Gadakh

[pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

://redmine.postgresql.org/issues/5157 about to put a checkbox in the configuration for this behavior. Do I need to implement that really? I yes, Is preferences a good place for that? / Suggestions? Thanks! -- Regards, Navnath Gadakh RM-5157_v1.patch Description: Binary data

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

ll require use of an index to access what may be the whole table. > > -- > Dave Page > VP & Chief Architect, Database Infrastructure > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Regards, Navnath Gadakh RM-5157_v2.patch Description: Binary data

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

ed in else condition also, which is not required. Based on the parameter > setting, Just one call of that sql is enough. > > Thanks, > Khushboo > > > On Fri, Apr 17, 2020 at 6:43 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hello Hackers

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

Hi Khushboo, Please hold this patch for review I'm still optimizing the code in the patch. On Mon, Apr 20, 2020 at 9:16 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, >I have modified the code as per review comments. Please review the >

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

C order) 4 - Filtered rows (No order) In the https://redmine.postgresql.org/issues/5157 it's not clearly mentioned on which option to apply sorting by PK? I'm assuming that should be on ALL Rows option. Please suggest. Thanks! On Tue, Apr 21, 2020 at 10:12 AM navnath

Exclude RESQL test cases

Hello Hackers, Please review the small patch to exclude RESQL test cases. resql param is added to --exclude. Thanks! -- Regards, Navnath Gadakh exclude_resql_tests_v1.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

drop/delete functionality for the Table constraints. > > Thanks, > Khushboo > -- Regards, Navnath Gadakh

Re: [pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

Patch looks good to me. On Wed, Apr 22, 2020 at 1:54 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello, > > I'm reviewing this RM. > > On Wed, Apr 22, 2020 at 10:55 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >>

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Yogesh Jain >>> 8982696654 >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Regards, > Yogesh Jain > 8982696654 > -- Regards, Navnath Gadakh

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Please commit the second patch as there is an issue with first one for the zoom factor. On Wed, Apr 22, 2020 at 4:50 PM Akshay Joshi wrote: > Patch is committed :). Not pushed > > On Wed, 22 Apr, 2020, 16:46 navnath gadakh, < > navnath.gad...@enterprisedb.com> wrote: &

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

ppening without context refresh. > > > > Please review. > > Thanks > Sathish V > -- Regards, Navnath Gadakh

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Hello, Patch looks good to me. Newly created columns sorted according to their creation order without context refresh. Thanks! On Thu, Apr 23, 2020 at 10:13 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi, > > I'm reviewing this patch. > > On We

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

gt; > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- Regards, Navnath Gadakh

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

Hi Pradip, Patch looks good to me except one minor issue - Create a table without selecting any relation then try to update table like options switch buttons are still enabled. On Fri, Apr 24, 2020 at 3:04 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi, >

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

Hi , I'm reviewing this task. On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 5422 - Synonym Dependencies > tab shows incorrect data. > > Thanks, > Khushboo > -- Regards, Navnath Gadakh

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

Hi Khushboo, Patch looks good to me except there are no API test cases written for dependents and dependencies. Thanks! On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi , > > I'm reviewing this task. > > On Wed, Apr 29

Re: [pgAdmin4] RESQL tests for Column & Type nodes

enterprisedb.com > The Enterprise PostgreSQL Company > > -- Regards, Navnath Gadakh

Re: [pgAdmin4] RESQL tests for Column & Type nodes

Hi Murtuza, Patch looks good to me. Thanks! On Wed, Apr 29, 2020 at 2:38 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > I will review and test it. > > On Wed, Apr 29, 2020 at 2:27 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: >