Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Please find updated patch, I have tested following scenarios in query tool, 1) To test if we highlight faulty syntax SQL: select a from pg_roles; 2) To check duplicates in error messages. - Open query tool - Uncheck Auto-Commit and run below sql 3 times and you will get an error SQL:

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi On Mon, Sep 18, 2017 at 3:08 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Sorry my bad, I didn't check the backend code, I assumed that it is coming > from psycopg2 and so I was focusing it to remove from client side :( > > PFA updated patch. > I think it

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Sorry my bad, I didn't check the backend code, I assumed that it is coming from psycopg2 and so I was focusing it to remove from client side :( PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 18,

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Please disregard my previous patch and instead attaching updated patch. In my previous patch I used `let` keyword instead of `var` for defining variable, for consistency & backward compatibility I have used `var` in my latest patch. -- Regards, Murtuza Zabuawala EnterpriseDB:

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, PFA patch. On Mon, Sep 18, 2017 at 4:34 PM, Dave Page wrote: > Hi > > On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the issue where logic to extract the error using >> RegEX

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where logic to extract the error using > RegEX from error message was incorrect in Query tool(History tab). > RM#2700 > Thanks - applied, but -

[pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi, PFA minor patch to fix the issue where logic to extract the error using RegEX from error message was incorrect in Query tool(History tab). RM#2700 Another minor issue which I observed on login page is that close button on alert is little misaligned(screenshot attached). -- Regards, Murtuza