Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Thanks, applied. On Tue, Mar 13, 2018 at 9:27 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch which Joao sent along with RM#3139 fix. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Hi Dave, Please find updated patch which Joao sent along with RM#3139 fix. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Mar 13, 2018 at 6:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > I

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Hi Dave, I have already replied on another thread regarding the failure of these tests, Joao has already sent a patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Mar 13, 2018 at 6:20 PM, Dave Page

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

And... reverted. It seems this makes Jenkins very unhappy. On Tue, Mar 13, 2018 at 7:58 AM, Dave Page wrote: > OK, thanks. Patch applied. > > On Tue, Mar 13, 2018 at 12:32 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> We are not

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

OK, thanks. Patch applied. On Tue, Mar 13, 2018 at 12:32 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > We are not joining template path with os.path.join because we are passing > prefix paths in render_template(..) at many places, > we are passing them as

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Hi Dave, We are not joining template path with os.path.join because we are passing prefix paths in render_template(..) at many places, we are passing them as below, Some of examples, render_template( "exclusion_constraint/js/exclusion_constraint.js", _=_ ), recovery_check_sql =

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Hi On Mon, Mar 12, 2018 at 10:15 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to correct the template path generation logic incase of Windows > system. > Seems like it would be better to fix it the other way round to me - e.g. update the template loader

[pgAdmin4][RM#3139] Create proper template path if Windows

Hi, PFA patch to correct the template path generation logic incase of Windows system. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3139.diff Description: Binary data