Re: [pgadmin4][patch] #3099 GPDB: Creating table and creating column in table fails

2018-02-19 Thread Dave Page
Thanks, patch applied.

On Fri, Feb 9, 2018 at 10:49 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> Attached is the patch that correct the creation of tables and columns.
>
> Also started using in a more widespread way the `compile_template_path`
> function  to have the logic in a single place.
> Hides the Advanced Tab on table creation for GreenPlum Databases
> Correctly retrieves the collate of the GrenPlum Database in multiples
> places that use it
> Correct the SQL generation for table creation when a primary keys are
> present
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


[pgadmin4][patch] #3099 GPDB: Creating table and creating column in table fails

2018-02-09 Thread Joao De Almeida Pereira
Hi Hackers,

Attached is the patch that correct the creation of tables and columns.

Also started using in a more widespread way the `compile_template_path`
function  to have the logic in a single place.
Hides the Advanced Tab on table creation for GreenPlum Databases
Correctly retrieves the collate of the GrenPlum Database in multiples
places that use it
Correct the SQL generation for table creation when a primary keys are
present

Thanks
Joao


gpdb-creation-of-tables-and-columns-corrected
Description: Binary data