On Wed, Aug 9, 2017 at 8:55 AM, Wenlin Zhang <wzh...@pivotal.io> wrote:
> Hi Surinder, > > This is great and useful. Looks good to me. Hope this can be committed > ASAP. > Thanks! Committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> > > Thanks, > > Wenlin & Violet > > > > On Wed, Aug 2, 2017 at 9:41 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi All, >> >> This patch enables source maps in pgAdmin4 for development environment. >> >> On running yarn run bundle It will create source maps(i.e. extract each >> module js file so that it is available to debug). >> >> You can search each module(ie. menu.js to debug) file by filename as >> follows: >> >> 1. >> >> Start pgAdmin4 server or run separately yarn run bundle in pgadmin/web >> 2. >> >> Open pgAdmin4 in browser(I am using chrome). Click sources panel and >> press CMD+P and search for file menu.js. Click and then add >> breakpoint to the line where you want to debug codebase. Screenshot >> attached for reference. >> >> I have excluded vendor and codemirror bundle from source map as i >> believe we don’t debug these files. If someone needs, they can remove >> vendor.js from source map plugin and rebuild. >> >> I didn’t add this for production mode yet. >> >> Reference to SourceMapDevToolPlugin >> <https://webpack.js.org/plugins/source-map-dev-tool-plugin/#components/sidebar/sidebar.jsx> >> >> Please find attached patch and review. >> >> Thanks, >> Surinder >> >> > >
