Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Thanks, patch applied. On Mon, Apr 13, 2020 at 2:29 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the test cases due to this patch. > Also, this functionality will not be applicable on EPAS server as we can > change the view

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi, Please find the attached patch to fix the test cases due to this patch. Also, this functionality will not be applicable on EPAS server as we can change the view definition without dropping it. Thanks, Khushboo On Wed, Apr 8, 2020 at 11:42 AM Akshay Joshi wrote: > Thanks, patch applied. >

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Thanks, patch applied. On Wed, Apr 8, 2020 at 10:58 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Tue, Apr 7, 2020 at 11:43 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi Akshay, Please find the attached updated patch. Thanks, Khushboo On Tue, Apr 7, 2020 at 11:43 AM Akshay Joshi wrote: > Hi Khushboo > > The warning message is not showing up. Please fix and resend the patch. > > On Tue, Apr 7, 2020 at 10:00 AM Khushboo Vashi < >

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi Khushboo The warning message is not showing up. Please fix and resend the patch. On Tue, Apr 7, 2020 at 10:00 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Tue, Mar 24, 2020 at 2:47 PM Akshay Joshi < >

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi Akshay, Please find the attached updated patch. On Tue, Mar 24, 2020 at 2:47 PM Akshay Joshi wrote: > Hi Khushboo > > On Tue, Mar 24, 2020 at 1:47 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi < >>

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi Khushboo On Tue, Mar 24, 2020 at 1:47 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are the review comments: >> >>- Fix the PEP8 issue.

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi Akshay, On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi wrote: > Hi Khushboo > > Following are the review comments: > >- Fix the PEP8 issue. >- Drop query should be part of the jinja template for consistency. >Currently, it is added through the python file. > > The Delete query is

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

Hi Khushboo Following are the review comments: - Fix the PEP8 issue. - Drop query should be part of the jinja template for consistency. Currently, it is added through the python file. - Any changes in the view code should not warn the user "Changing the columns in a view requires