Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-17 Thread Akshay Joshi
Thanks patch applied. On Wed, Aug 9, 2017 at 4:25 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com>

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-09 Thread Harshal Dhumal
On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi wrote: > On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to use fetch dict based data instead of 2d-array based in >> Type module as we are adding keys on the fly. >> There is no RM just a mino

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-08 Thread Ashesh Vashi
On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to use fetch dict based data instead of 2d-array based in > Type module as we are adding keys on the fly. > There is no RM just a minor enhancement. > Harshal, Please review th