Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-17 Thread Ashesh Vashi 
On Tue, Aug 8, 2017 at 3:46 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Patch looks good to me.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma 
> wrote:
>
>> makes sense. Thanks for the solution.
>>
>> Please find attached revised patch.
>>
> Committed with minor change in existing logic.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>> Thanks,
>> Atul
>>
>> On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Atul,
>>>
>>> Better solution to solve this issue is to use self.conn instead of
>>> creating new conn using did, we already checking for "datallowconn"
>>> flag in check_precondition decorator.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> 
>>>
>>> On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <
>>> atul.sha...@enterprisedb.com> wrote:
>>>
 ok, Lemme check and I will get back to you.

 Thanks,
 Atul

 On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Atul,
>
> The given patch breaks RM#1801
> .
> After applying the patch, Now I'm not able to see the properties of a
> database of which "datallowconn" is set to False.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Murtuza,
>>
>> Please review this one.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <
>> atul.sha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch that fixes Default privileges don't show on Properties tab
>>> for database
>>>
>>> Thanks,
>>> Atul
>>>
>>
>>
>

>>>
>>
>

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Murtuza Zabuawala 
Patch looks good to me.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]


On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma 
wrote:

> makes sense. Thanks for the solution.
>
> Please find attached revised patch.
>
> Thanks,
> Atul
>
> On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Atul,
>>
>> Better solution to solve this issue is to use self.conn instead of
>> creating new conn using did, we already checking for "datallowconn" flag
>> in check_precondition decorator.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <
>> atul.sha...@enterprisedb.com> wrote:
>>
>>> ok, Lemme check and I will get back to you.
>>>
>>> Thanks,
>>> Atul
>>>
>>> On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Atul,

 The given patch breaks RM#1801
 .
 After applying the patch, Now I'm not able to see the properties of a
 database of which "datallowconn" is set to False.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> Murtuza,
>
> Please review this one.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <
> atul.sha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch that fixes Default privileges don't show on Properties tab
>> for database
>>
>> Thanks,
>> Atul
>>
>
>

>>>
>>
>

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Atul Sharma 
makes sense. Thanks for the solution.

Please find attached revised patch.

Thanks,
Atul

On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Atul,
>
> Better solution to solve this issue is to use self.conn instead of
> creating new conn using did, we already checking for "datallowconn" flag
> in check_precondition decorator.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma  > wrote:
>
>> ok, Lemme check and I will get back to you.
>>
>> Thanks,
>> Atul
>>
>> On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Atul,
>>>
>>> The given patch breaks RM#1801
>>> .
>>> After applying the patch, Now I'm not able to see the properties of a
>>> database of which "datallowconn" is set to False.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> 
>>>
>>> On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 Murtuza,

 Please review this one.

 --

 Thanks & Regards,

 Ashesh Vashi
 EnterpriseDB INDIA: Enterprise PostgreSQL Company
 


 *http://www.linkedin.com/in/asheshvashi*
 

 On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <
 atul.sha...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch that fixes Default privileges don't show on Properties tab
> for database
>
> Thanks,
> Atul
>


>>>
>>
>


RM_2567_v2.patch
Description: Binary data

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Murtuza Zabuawala 
Hi Atul,

Better solution to solve this issue is to use self.conn instead of creating
new conn using did, we already checking for "datallowconn" flag in
check_precondition
decorator.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]


On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma 
wrote:

> ok, Lemme check and I will get back to you.
>
> Thanks,
> Atul
>
> On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Atul,
>>
>> The given patch breaks RM#1801
>> .
>> After applying the patch, Now I'm not able to see the properties of a
>> database of which "datallowconn" is set to False.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Murtuza,
>>>
>>> Please review this one.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>
>>> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <
>>> atul.sha...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA patch that fixes Default privileges don't show on Properties tab
 for database

 Thanks,
 Atul

>>>
>>>
>>
>

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Atul Sharma 
ok, Lemme check and I will get back to you.

Thanks,
Atul

On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Atul,
>
> The given patch breaks RM#1801
> .
> After applying the patch, Now I'm not able to see the properties of a
> database of which "datallowconn" is set to False.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Murtuza,
>>
>> Please review this one.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma > > wrote:
>>
>>> Hi,
>>>
>>> PFA patch that fixes Default privileges don't show on Properties tab for
>>> database
>>>
>>> Thanks,
>>> Atul
>>>
>>
>>
>

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Murtuza Zabuawala 
Hi Atul,

The given patch breaks RM#1801 .
After applying the patch, Now I'm not able to see the properties of a
database of which "datallowconn" is set to False.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]


On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi  wrote:

> Murtuza,
>
> Please review this one.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma 
> wrote:
>
>> Hi,
>>
>> PFA patch that fixes Default privileges don't show on Properties tab for
>> database
>>
>> Thanks,
>> Atul
>>
>
>

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Ashesh Vashi 
Murtuza,

Please review this one.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma 
wrote:

> Hi,
>
> PFA patch that fixes Default privileges don't show on Properties tab for
> database
>
> Thanks,
> Atul
>