Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Thanks, applied. On Mon, Feb 12, 2018 at 7:27 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to update button tooltip. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri,

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hi Dave, PFA patch to update button tooltip. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Feb 9, 2018 at 6:14 PM, Dave Page wrote: > Thanks, applied. > > Can you please send a followup patch to include

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Sure. On Fri, Feb 9, 2018 at 6:14 PM, Dave Page wrote: > Thanks, applied. > > Can you please send a followup patch to include the configured keys on the > button tooltips, like we do in the Query Tool? > > > On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Thanks, applied. Can you please send a followup patch to include the configured keys on the button tooltips, like we do in the Query Tool? On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to make shortcut configurable in

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hi Joao, On Thu, Feb 8, 2018 at 8:07 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > After some review of the code we do have some questions: > - Do we really need to have the shortcuts in the backend?(I already asked > this in Khushboo's patch) > ​Yes, to

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hello Murtuza, After some review of the code we do have some questions: - Do we really need to have the shortcuts in the backend?(I already asked this in Khushboo's patch) - Do we need to have keyAction function(in direct.js) inside this Javascript file or can we extract that an create some