Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-06 Thread Dave Page
On Fri, Apr 6, 2018 at 8:52 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > I checked and found that the issue was in wcDocker which was causing > problem while opening query tool, > I have logged an issue on github: https://github.com/ > WebCabin/wcDocker/issues/

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-06 Thread Murtuza Zabuawala
Hi Dave, I checked and found that the issue was in wcDocker which was causing problem while opening query tool, I have logged an issue on github: https://github.com/WebCabin/wcDocker/issues/124 Query tool, Debugger etc are working properly when open in new Browser Tab and not in Panel. I'm also

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-04 Thread Murtuza Zabuawala
On Wed, Apr 4, 2018 at 3:19 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Joao, >> >> Yes it bundles latest version but I doubt that is not using it, If we >> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. >> I have t

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-04 Thread Dave Page
On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > Yes it bundles latest version but I doubt that is not using it, If we > upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. > I have tried that and I started getting jQuery relat

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-04 Thread Dave Page
Thanks, patch applied. On Tue, Apr 3, 2018 at 4:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > Reverted back jQuery version to 1.x because of SlickGrid dependancy. > Please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://ww

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-04 Thread Murtuza Zabuawala
Hi Joao, Yes it bundles latest version but I doubt that is not using it, If we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. I have tried that and I started getting jQuery related errors when trying to run query tool or when running jasmine tests. -- Regards, Murtuza Zabuawala Ent

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-03 Thread Joao De Almeida Pereira
Hi Murtuza, The patches look good and they pass all tests in CI. One think that we realized was the SlickGrid as a npm package now: https://www.npmjs.com/package/slickgrid Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully supported or not.. Thanks Victoria & Joao On Tue,

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-03 Thread Murtuza Zabuawala
​Hi Dave, Reverted back jQuery version to 1.x because of SlickGrid dependancy. Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-03 Thread Murtuza Zabuawala
Please hold on my previous patch. We can't use latest jQuery version as SlickGrid has dependancy on older version. I'll send updated patch again. On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patches, there are t

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-03 Thread Murtuza Zabuawala
Hi Dave, Please find updated patches, there are two patches attached one is for the story and another is for changes required as per new modules. On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: > Hi > > On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-04-03 Thread Dave Page
Hi On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to update the modules to latest version. > > - Why isn't jQuery updated to 3.3.1? - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 and pycrypto etc? > We

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-03-30 Thread Murtuza Zabuawala
Thanks for reviewing Victoria. On Fri, Mar 30, 2018 at 7:59 PM, Victoria Henry wrote: > Hi Murtuza, > > I ran this patch through the pipelines and all tests passed. > Everything looks good. > > Sinerely, > > Victoria > > On Fri, Mar 30, 2018 at 3:01 AM, Murtuza Zabuawala enterprisedb.com> wrote

Re: [pgAdmin4][RM#3154] Update modules to latest version

2018-03-30 Thread Victoria Henry
Hi Murtuza, I ran this patch through the pipelines and all tests passed. Everything looks good. Sinerely, Victoria On Fri, Mar 30, 2018 at 3:01 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to update the modules to latest version. > > We are not able to