Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Khushboo can you explain a little bit more this while loop? cnt = 0 while 1: if cnt > 1: break # Check the process list response1 = self.tester.get('/misc/bgprocess/?_='.format( random.randint(1, 999))) self.assertEquals(response1.status_code, 200)

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Victoria, As per the logs, Restore job is failing only for GPDB. As I don't have setup for the greenplum database, can you please check this functionality works well in pgAdmin4 with GPDB? Thanks, Khushboo On Wed, Jun 6, 2018 at 5:13 AM, Victoria Henry wrote: > Hi Khushboo > > The tests

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Khushboo The tests are still failing and seems flaky: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/113 Sincerely, Victoria On Tue, Jun 5, 2018 at 4:50 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 5, 2018

Re: [pgadmin4][Patch]: Test cases for the backup module

On Tue, Jun 5, 2018 at 9:37 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Jun 4, 2018 at 8:41 PM,

Re: [pgadmin4][Patch]: Test cases for the backup module

On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: > Hi > > On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Khushboo, >>> >>> Some tests

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Khushboo, >> >> Some tests are failing in greenplum: >>

Re: [pgadmin4][Patch]: Test cases for the backup module

On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > > Some tests are failing in greenplum: > https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/ > pipelines/pgadmin-patch/jobs/run-tests/builds/108 > The piece of code responsible for the

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Khushboo, Some tests are failing in greenplum: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/108 The piece of code responsible for the error is: if server['default_binary_paths'] is not None:

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi This looks good, except that it's leaving the test_restore_database behind. Can we clean that up please? Thanks. On Fri, Jun 1, 2018 at 7:06 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Victoria, > > Thanks for reviewing the patch. > The tests were failing due to the

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi there, We've been noticing some issues with the tests on both our CI and local Mac workstations. 1. When the following code blocks are invoked - we get plenty of app.context() issues. It must not be valid when running tests. ​ from pgadmin.utils.driver import get_driver driver =

Re: [pgadmin4][Patch]: Test cases for the backup module

On Wed, May 30, 2018 at 1:05 AM, Dave Page wrote: > Hi > > On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> please find the attached updated patch for the test cases of Backup, >> Restore and Maintenance modules which includes: >> >> 1.