Re: RM5049 Patch

2020-01-16 Thread Akshay Joshi
Thanks, patch applied with some modification as verify cast logic is not
working.

On Wed, Jan 15, 2020 at 2:45 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find updated patch -
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Wed, Jan 15, 2020 at 1:49 PM Neel Patel 
> wrote:
>
>> Patch only covers removal of the code and change in "coveragerc.in". I
>> guess you missed to add the new files in the patch. Can you please verify ?
>>
>> Thanks,
>> Neel Patel
>>
>> On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for  api tests for cast node.This covers -
>>> Added new file (cast_test_cases.json) storing inventory, test, expected
>>> data.
>>> Also covers test cases for all cast node related api,
>>> This increase code coverage for cast from 33% to 68%.
>>>
>>> Command to run tests -
>>> --pkg browser.server_groups.servers.databases.casts.tests
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: RM5049 Patch

2020-01-15 Thread Yogesh Mahajan
Hi,

Please find updated patch -


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Wed, Jan 15, 2020 at 1:49 PM Neel Patel 
wrote:

> Patch only covers removal of the code and change in "coveragerc.in". I
> guess you missed to add the new files in the patch. Can you please verify ?
>
> Thanks,
> Neel Patel
>
> On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch for  api tests for cast node.This covers -
>> Added new file (cast_test_cases.json) storing inventory, test, expected
>> data.
>> Also covers test cases for all cast node related api,
>> This increase code coverage for cast from 33% to 68%.
>>
>> Command to run tests -
>> --pkg browser.server_groups.servers.databases.casts.tests
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>


RM5049_v2.patch
Description: Binary data


Re: RM5049 Patch

2020-01-15 Thread Neel Patel
Patch only covers removal of the code and change in "coveragerc.in". I
guess you missed to add the new files in the patch. Can you please verify ?

Thanks,
Neel Patel

On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch for  api tests for cast node.This covers -
> Added new file (cast_test_cases.json) storing inventory, test, expected
> data.
> Also covers test cases for all cast node related api,
> This increase code coverage for cast from 33% to 68%.
>
> Command to run tests -
> --pkg browser.server_groups.servers.databases.casts.tests
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>