Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-02 Thread Dave Page
Thanks. On Tue, Jun 2, 2020 at 9:27 AM Akshay Joshi wrote: > I'll change and commit the code. > > On Tue, Jun 2, 2020 at 1:55 PM Dave Page wrote: > >> >> >> On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Tue, Jun 2, 2020 at 1:41

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-02 Thread Akshay Joshi
I'll change and commit the code. On Tue, Jun 2, 2020 at 1:55 PM Dave Page wrote: > > > On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi > wrote: > >> Hi Dave >> >> On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: >> >>> Hi >>> >>> Urgh, didn't realise pwd wasn't available on Windows :-(. What about

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-02 Thread Dave Page
On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi wrote: > Hi Dave > > On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: > >> Hi >> >> Urgh, didn't realise pwd wasn't available on Windows :-(. What about just >> using getpass.getuser() everywhere? According to the docs it falls back to >> using pwd

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-02 Thread Akshay Joshi
Hi Dave On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: > Hi > > Urgh, didn't realise pwd wasn't available on Windows :-(. What about just > using getpass.getuser() everywhere? According to the docs it falls back to > using pwd where that's supported anyway: >

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-02 Thread Dave Page
Hi Urgh, didn't realise pwd wasn't available on Windows :-(. What about just using getpass.getuser() everywhere? According to the docs it falls back to using pwd where that's supported anyway: https://docs.python.org/3.8/library/getpass.html On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi wrote: >

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-02 Thread Akshay Joshi
Hi Dave I have tested the logic on Mac OSX but not on Windows. The "*pwd*" module is not available on windows hence Jenkins build is failing. Attached is the patch to fix for Windows OS. I have used the "*getpass*" module for Windows. Please review it. If looks good I'll commit the code. On

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: > Patch for $SUBJECT attached. Sample output: > > python web/pgAdmin4.py > ERROR : Failed to create the directory /var/lib/pgadmin: >[Errno 13] Permission denied: '/var/lib/pgadmin' > HINT : Create the