Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

2016-09-19 Thread Navnath Gadakh
Hi Dave, Error resolved. Please find the revised patch. On Fri, Sep 16, 2016 at 9:23 PM, Dave Page wrote: > Hi > > On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch for the enhanced test result summary for > testing > > framework. The code

[pgadmin-hackers] PATCH: To fix the issue in Packages node (pgAdmin4)

2016-09-19 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue in Packages node where after updating any package user was getting 'Not Found' error. RM#1625 *Issue:* It was due to wrong parent was provided while sending the node to client. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterp

Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

2016-09-19 Thread Dave Page
Hi On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh wrote: > Hi Dave, > Error resolved. Please find the revised patch. I still see the error: Test Result Summary Regression - PG 9.4: 25 tests passed, 0 tests failed Please check outpu

[pgadmin-hackers] pgAdmin 4 commit: Resolve a refresh issue when updating packages. Fixes

2016-09-19 Thread Dave Page
Resolve a refresh issue when updating packages. Fixes #1625 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82d63804c1877f6e272b02a54c1b420ae034bd28 Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/databases/sc

Re: [pgadmin-hackers] PATCH: To fix the issue in Packages node (pgAdmin4)

2016-09-19 Thread Dave Page
Thanks, applied. On Mon, Sep 19, 2016 at 8:20 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Packages node where after updating any > package user was getting 'Not Found' error. > RM#1625 > > Issue: > It was due to wrong parent was provided while sending the node to cl

[pgadmin-hackers] [pgAdmin4][Patch]: RM1588 - User can not change the code of header through right if package created without body

2016-09-19 Thread Surinder Kumar
Hi Please find attached patch with fix: Minor changes in template file. Checks were missing for creating package body and drop package body. Please review. Thanks, Surinder Kumar RM1588.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)

[pgadmin-hackers] PATCH: To fix column editor issue (pgAdmin4)

2016-09-19 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in column editor where subnode control was not expanding properly. RM#1703/04 *Issue:* There was issue in SecurityGroup function(used to show/hide security tab) which was not able to find node_info property when called from subnode control, due t which it was breaki

[pgadmin-hackers] pgAdmin website commit: Add Linux package info

2016-09-19 Thread Dave Page
Add Linux package info Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=b321740bf3193822afade8ec809b43e550e67a7f Modified Files -- download/linux4.php | 22 ++ download/menu.php | 1 + 2 files changed, 23 inse

[pgadmin-hackers] pgAdmin website commit: Fix brain fart

2016-09-19 Thread Dave Page
Fix brain fart Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=5aa32cc67ebeda7a9a3a87cc876eac12c6333db7 Modified Files -- download/linux4.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mai

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

2016-09-19 Thread Dave Page
On Fri, Sep 16, 2016 at 9:17 AM, Devrim Gündüz wrote: > > Hi, > > On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote: >> >> Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-) > > \o/ Can't wait ;) > >> Let me know when packages available and ready to use, and I'll add a >> pa

[pgadmin-hackers] PATCH: To fix the issue where user gets error following application server restart (pgAdmin4)

2016-09-19 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user gets error following application server restart. RM#1707 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1707.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

2016-09-19 Thread Navnath Gadakh
Hi Dave, In the drop objects function scenario for 'NoneType' was not handled. Code is added in the revised patch. Thanks. On Mon, Sep 19, 2016 at 2:03 PM, Dave Page wrote: > Hi > > On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh > wrote: > > Hi Dave, > > Error resolved. Please find

[pgadmin-hackers] [pgAdmin4][Patch]: Slickgrid loading issue in Query tool

2016-09-19 Thread Surinder Kumar
Hi *Issue:* Slick-grid libraries loads when an instance of query tool is opened. But sometimes it throws exception "jQuery is not defined" and it doesn't opens up. *Solution:* As per my understanding, In *datagrid/index.html* file, we set the order of loading libraries such as *require(['jquery',

[pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-19 Thread Surinder Kumar
Hi Please find attached patch with fix. > ​Download as CSV > button should be enabled only for SELECT queries. ​Please review. Thanks, Surinder Kumar​ RM1592.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your su

[pgadmin-hackers] pgAdmin 4 commit: Resolve a syntax error when updating packages with no

2016-09-19 Thread Dave Page
Resolve a syntax error when updating packages with no body. Fixes #1588 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc0cb8327750e6ee1b13193d5afdc22ff3754022 Author: Surinder Kumar Modified Files -- .../packages/templates/packag

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1588 - User can not change the code of header through right if package created without body

2016-09-19 Thread Dave Page
Thanks, applied. On Mon, Sep 19, 2016 at 10:29 AM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix: > Minor changes in template file. Checks were missing for creating package > body and drop package body. > > Please review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pga

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue where the edit icon vanished and the def

2016-09-19 Thread Dave Page
Fix an issue where the edit icon vanished and the default tab wasn't shown when advanced-editing a column in the table dialogue. Fixes #1704 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2440f89a7134d9c8ff28b8f93ea0baf1e2abb211 Author: Murtuz

Re: [pgadmin-hackers] PATCH: To fix column editor issue (pgAdmin4)

2016-09-19 Thread Dave Page
Thanks, applied. On Mon, Sep 19, 2016 at 11:10 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in column editor where subnode control was not > expanding properly. > RM#1703/04 > > Issue: > There was issue in SecurityGroup function(used to show/hide security tab) > which was not

[pgadmin-hackers] pgAdmin 4 commit: Fix an exception that could occur when the browser pi

2016-09-19 Thread Dave Page
Fix an exception that could occur when the browser pings the server following a restart. Fixes #1707 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=881d2a60a4e1ef357dcf9fcfb5375f8dc3dd2163 Author: Murtuza Zabuawala Modified Files ---

Re: [pgadmin-hackers] PATCH: To fix the issue where user gets error following application server restart (pgAdmin4)

2016-09-19 Thread Dave Page
Thanks, applied. On Mon, Sep 19, 2016 at 12:48 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user gets error following application > server restart. > RM#1707 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Co

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-19 Thread Dave Page
Hi On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix. >> >> Download as CSV >> button should be enabled only for SELECT queries. I'm not sure there's a way to do this without parsing the query. Simply matching on ^select certainly won't work rel

[pgadmin-hackers] [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button

2016-09-19 Thread Surinder Kumar
Hi Please find patch with following fixes: 1) Newly added server-group not listing in tree view. 2) On creating a first node for collection node with no child. the created node doesn't show up under its respective parent node. - to add a node to child under its parent node. its parent node attri

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-19 Thread Surinder Kumar
On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote: > Hi > > On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar > wrote: > > Hi > > > > Please find attached patch with fix. > >> > >> Download as CSV > >> button should be enabled only for SELECT queries. > > I'm not sure there's a way to do this with

[pgadmin-hackers] pgAdmin 4 commit: Enhanced summary output for the test suite.

2016-09-19 Thread Dave Page
Enhanced summary output for the test suite. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c84fd83595be4922879c150314e9f1973e087e3f Author: Navnath Gadakh Modified Files -- .../servers/databases/tests/test_db_add.py | 35

Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

2016-09-19 Thread Dave Page
Thanks - applied with minor tweaks to the output formatting. On Mon, Sep 19, 2016 at 2:03 PM, Navnath Gadakh wrote: > Hi Dave, > In the drop objects function scenario for 'NoneType' was not handled. > Code is added in the revised patch. > > Thanks. > > On Mon, Sep 19, 2016 at 2:03 PM, Dave

[pgadmin-hackers] Regression errors - database node

2016-09-19 Thread Dave Page
Hi Navnath I keep seeing the errors below when running tests. It seems to be consistent on EPAS, but intermittent on PG. Any ideas what the issue is? I'm fairly convinced it's a test issue not an actual problem. 2016-09-19 16:47:49,567:ERROR:STDERR:===

[pgadmin-hackers] pgAdmin 4 commit: Ensure jQuery is loaded before SlickGrid. Fixes #1712

2016-09-19 Thread Dave Page
Ensure jQuery is loaded before SlickGrid. Fixes #1712 Patch by Ashesh with contributions from Surinder. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7ab0eb158f52d8fa662b55035f5dc91b7dd4c332 Author: Ashesh Vashi Modified Files -

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Slickgrid loading issue in Query tool

2016-09-19 Thread Dave Page
Thanks, applied. On Mon, Sep 19, 2016 at 2:58 PM, Surinder Kumar wrote: > Hi > > Issue: > Slick-grid libraries loads when an instance of query tool is opened. But > sometimes it throws exception "jQuery is not defined" and it doesn't opens > up. > > Solution: > As per my understanding, In datagri

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button

2016-09-19 Thread Dave Page
Hi On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar wrote: > Hi > > Please find patch with following fixes: > > 1) Newly added server-group not listing in tree view. > > 2) On creating a first node for collection node with no child. the created > node doesn't show up under its respective parent n

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-19 Thread Surinder Kumar
On Mon, Sep 19, 2016 at 8:59 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote: > >> Hi >> >> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find attached patch with fix. >> >> >> >> Download as CSV