Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-20 Thread Dave Page
On Tue, Sep 20, 2016 at 6:43 AM, Surinder Kumar wrote: > > On Mon, Sep 19, 2016 at 8:59 PM, Surinder Kumar > wrote: >> >> On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote: >>> >>> Hi >>> >>> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar >>> wrote: >>> > Hi >>> > >>> > Please find attached pat

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button

2016-09-20 Thread Surinder Kumar
On Mon, Sep 19, 2016 at 9:49 PM, Dave Page wrote: > Hi > > > On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar > wrote: > > Hi > > > > Please find patch with following fixes: > > > > 1) Newly added server-group not listing in tree view. > > > > 2) On creating a first node for collection node with

[pgadmin-hackers] PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

2016-09-20 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in debugger where we were not displaying result properly in result tab for composite types. RM#1662 @Neel, Would you please review the patch? *Issue:* Column name key was hardcoded in dict causing overwriting other columns. -- Regards, Murtuza Zabuawala Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Ensure items are properly added to the treeview when

2016-09-20 Thread Dave Page
Ensure items are properly added to the treeview when their parent has no pre-existing children. Fixes #1627 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=febb1b80b1f5682db8a257c0b43d63179ec6e71d Author: Surinder Kumar Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button

2016-09-20 Thread Dave Page
On Tue, Sep 20, 2016 at 10:22 AM, Surinder Kumar wrote: > On Mon, Sep 19, 2016 at 9:49 PM, Dave Page wrote: >> >> Hi >> >> >> On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find patch with following fixes: >> > >> > 1) Newly added server-group not listing in t

Re: [pgadmin-hackers] PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

2016-09-20 Thread Neel Patel
Hi Murtuza, Sure. I will review it. Thanks, Neel Patel On Tue, Sep 20, 2016 at 3:16 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in debugger where we were not displaying result > properly in result tab for composite types. > RM#1662 > >

Re: [pgadmin-hackers] PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

2016-09-20 Thread Dave Page
Thanks - applied. On Tue, Sep 20, 2016 at 10:46 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in debugger where we were not displaying result > properly in result tab for composite types. > RM#1662 > > @Neel, > Would you please review the patch? > > Issue: > Column name key wa

[pgadmin-hackers] pgAdmin 4 commit: Handle composite type return values properly in the d

2016-09-20 Thread Dave Page
Handle composite type return values properly in the debugger. Fixes #1662 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f991354f9a17a04b6530b460880936f51023ece7 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/debugg

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-20 Thread Surinder Kumar
Please find updated patch with suggested changes and inline comments. Also, Incase if user tries to download csv on queries other than select, we are catching that exception and write into 'csv' with name 'error.csv'. On Tue, Sep 20, 2016 at 2:33 PM, Dave Page wrote: > On Tue, Sep 20, 2016 at 6

[pgadmin-hackers] pgAdmin 4 commit: Save error details when executing to CSV, if no data

2016-09-20 Thread Dave Page
Save error details when executing to CSV, if no data is returned. This ensures the user gets some feedback rather than nothing at all. Fixes #1592 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28ce31a0227f7460b79688e6ca85c23404190251 Author:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL

2016-09-20 Thread Dave Page
Thanks, applied. On Tue, Sep 20, 2016 at 11:39 AM, Surinder Kumar wrote: > Please find updated patch with suggested changes and inline comments. > > Also, Incase if user tries to download csv on queries other than select, we > are catching that exception and write into 'csv' with name 'error.csv'

Re: [pgadmin-hackers] pgAdmin 4 commit: Add classid filter to queries on pg_depend. Fixes #17

2016-09-20 Thread Magnus Hagander
Thanks! I'll push a backpatch of this to pgadmin3 as well, just in case somebody wants to build their own version even if there are no more official releases. In working on this I also noticed that we fairly often use the construct of "(select oid from pg_class where relname=xxx)" instead of usin

[pgadmin-hackers] pgAdmin III commit: Add classid filter to queries on pg_depend

2016-09-20 Thread Magnus Hagander
Add classid filter to queries on pg_depend There are a number of cases where queries in both pgadmin4 and pgadmin3 are done against pg_depend but falis to constrain the query on classid. In particular, if for example a constraint and a sequence exists with the same oid (which is perfectly valid,

[pgadmin-hackers] pgAdmin website commit: Fix dates per Magnus

2016-09-20 Thread Dave Page
Fix dates per Magnus Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=dc90f8e48868e0447d8b0f4d5c6f5532076e4995 Modified Files -- index.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mai

[pgadmin-hackers] [pgAdmin4][Patch]: RM1171 - Fix IE caching issue

2016-09-20 Thread Surinder Kumar
Hi *Issue:* IE always caching the response data returned from the server and when same request is made for next time, it doesn't bring new data, instead it use cached data. *Solution:* Set cache to '*no-cache*' in response headers while sending from the server side. This prevents browser from cac

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1171 - Fix IE caching issue

2016-09-20 Thread Surinder Kumar
This patch has some issue in chrome while loading nodes. I will send updated patch. On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issue:* > IE always caching the response data returned from the server and when same > request is made for next t

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1171 - Fix IE caching issue

2016-09-20 Thread Surinder Kumar
Missed method closing parenthesis while calling Please find updated patch On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > This patch has some issue in chrome while loading nodes. I will send > updated patch. > > On Tue, Sep 20, 2016 at 7:16 PM, Surinde

[pgadmin-hackers] openbsd build failure: vacuumdb.c

2016-09-20 Thread jungle Boogie
Hi All, This may not be the right mailing list. Apologizes in advance. I'm attempting to build PostgreSQL from source on OpenBSD i386 from an openbsd snapshot from yesterday (19 September) with this configuration: ./configure --enable-cassert --enable-debug --with-perl \ --with-python