[pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

Hi While working on RM*1391 *I found another issue* 'Backup is not working on windows".* The reason is that the process executor which uses subprocess Popen() to execute job fails when we pass close_fds=True and shell=False in windows. Now we are settings close_fds=False and shell=True to fix

[pgadmin-hackers] PATCH: To fix JSON array handling (pgAdmin4)

Hi, PFA patch to fix the issue where SlickGrid was not displaying nested JSON data properly. This patch fixes: RM#1713 & RM#1404 *Issue:* Nested JSON data was not handled properly. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

Hi Dave, On Mon, 2016-09-19 at 12:03 +0100, Dave Page wrote: > https://www.pgadmin.org/download/linux4.php > > How's that? If you have instructions, please send me text (or better > yet, a patch), and I'll add them. I added packages for 9.4 and 9.5, too. Also wrote a basic blog post about

Re: [pgadmin-hackers] Regression errors - database node

Hi Dave, After a long debugging of these errors with Harshal, we found the issue is in the handling pyscopg connection. Need to add some code in the pyscopg connection manager as per Harshal. For more details, Please refer RM #1720. @Harshal,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1171 - Fix IE caching issue

Can you rebase please? piranha:web dpage$ git apply ~/Downloads/RM1171_v1.patch error: patch failed: web/pgadmin/utils/ajax.py:29 error: web/pgadmin/utils/ajax.py: patch does not apply On Tue, Sep 20, 2016 at 2:58 PM, Surinder Kumar wrote: > Missed method

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1171 - Fix IE caching issue

​Hi I did git pull and applied the patch without any error.​ I have attached updated patch. Please apply this patch and let me know if any issue. On Wed, Sep 21, 2016 at 5:59 PM, Dave Page wrote: > Can you rebase please? > > piranha:web dpage$ git apply

[pgadmin-hackers] pgAdmin 4 commit: Handle nested JSON correctly in SlickGrid. Fixes #171

Handle nested JSON correctly in SlickGrid. Fixes #1713. Fixes #1404 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a401713008c516d45798ac258dc15fbd6977e29 Modified Files -- .../static/js/slickgrid/slick.pgadmin.editors.js |

Re: [pgadmin-hackers] PATCH: To fix JSON array handling (pgAdmin4)

Thanks, applied. On Wed, Sep 21, 2016 at 11:43 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where SlickGrid was not displaying nested JSON > data properly. > This patch fixes: RM#1713 & RM#1404 > > Issue: > Nested JSON data was not handled

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

Ashesh, Murtuza, Surinder, Some feedback or preferably a patch please? Release is next week! On Fri, Sep 16, 2016 at 3:36 PM, Magnus Hagander wrote: > On Fri, Sep 16, 2016 at 3:35 AM, Dave Page wrote: >> >> Ashesh, Murtuza, Surinder, >> >> Any thoughts

[pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi, PFA patch for RM1720 Issue: In pgAdmin4 we use server id (sid, which is id of server table in sqlite db) as key to keep track of server connection (server manger). But sqlite reuses these ids and therefore pgadmin4 connection manager assigns connection details of one database server to

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

Hi On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar wrote: > Hi Dave/Ashesh > > The thing we can do is: > 1) We can display loading message same as other panels if returned response > is taking longer than 2 seconds, otherwise we won't display any message(to >

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi On Wed, Sep 21, 2016 at 1:57 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for RM1720 > > > Issue: In pgAdmin4 we use server id (sid, which is id of server table in > sqlite db) as key to keep track of server connection (server manger). But > sqlite reuses

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

On Wed, Sep 21, 2016 at 4:02 PM, Navnath Gadakh wrote: > Hi Dave, > Can you please run testsuite for server or database node only, as > there are some code modifications are remaining on the rest of the nodes. > Currently i don't have a machine to look

[pgadmin-hackers] pgAdmin 4 commit: Prevent browsers caching responses. Fixes #1171

Prevent browsers caching responses. Fixes #1171 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2077bd5fdccaa56893b3abf0ee09dcf754e889fc Modified Files -- web/pgadmin/utils/ajax.py | 18 -- 1 file changed, 16

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1171 - Fix IE caching issue

Thanks, applied. On Wed, Sep 21, 2016 at 2:40 PM, Surinder Kumar wrote: > Hi > > I did git pull and applied the patch without any error. I have attached > updated patch. > Please apply this patch and let me know if any issue. > > On Wed, Sep 21, 2016 at 5:59 PM,

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi Dave, Can you please run testsuite for server or database node only, as there are some code modifications are remaining on the rest of the nodes. Currently i don't have a machine to look into issue, will check it tomorrow. Thanks. On 21-Sep-2016 6:50 PM, "Dave Page"