Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-01-13 Thread Surinder Kumar
Hi Please find attached patch and review. On Sun, Jan 8, 2017 at 3:27 PM, Dave Page wrote: > Hi > > On Friday, December 23, 2016, Surinder Kumar com> wrote: > >> Forgot to attach patch in last thread. please find patch. >> > > It looks good for the most part, except: > > 1) You missed the part

[pgadmin-hackers] PATCH: To display column information properly in Properties Panel (pgAdmin4)

2017-01-13 Thread Murtuza Zabuawala
Hi, PFA patch to display columns in Properties panel for exclusion constraint node, and in addition to that I found similar issue with foreign key node. We will also remove placeholder from Select2 control if it's in Properties panel or disabled, it will be generic change in Select2 control in Ba

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-13 Thread Murtuza Zabuawala
Hi Dave, I am not able to re-produce it, I reviewed reconnect to database logic and it is not affected by this patch, Would you please provide me exact steps? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 9, 2017 at 8:27 AM,

[pgadmin-hackers] [pgAdmin4][patch]: RM 1967 - Layout is not remembered

2017-01-13 Thread Neel Patel
Hi, Please find attached patch file with the fix of RM #1967. *Issue:-* Sometime arranged layout is not getting remembered. This may be due to we were saving the layout on "unload" event and handling of "unload" event varies from different versions of browser so we should not listen "unload" even

[pgadmin-hackers] PATCH: To fix the issue in Variable control (pgAdmin4)

2017-01-13 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where variable control was not displaying values properly in edit mode. This issue was due to wrong value set in model. RM#2067 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2067.patch Description: Bin