Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi Shirley, The new UI looks awesome :) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 6:58 PM, Shirley Wang wrote: > Hi Murtuza, > > This was before we had checkboxes removed and added column

Re: [pgadmin-hackers] [pgAdmin4] To fix issues in pgAgent's modules

Thanks, applied. On Wed, Jun 7, 2017 at 12:54 PM, Murtuza Zabuawala wrote: > Hi, > > Please find attached patch to fix the issues in pgAgent's Schedule and Step > module. > > 1) Error on clicking SQL panel when Schedule OR Step node is selected in > browser. >

[pgadmin-hackers] pgAdmin 4 commit: Fix various issues with pgAgent job steps and schedul

Fix various issues with pgAgent job steps and schedules: 1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888 2) Error while dropping Schedule OR Step node. Fixes #1889 3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890

[pgadmin-hackers] pgAdmin 4 commit: Retain column sizing in the query tool results grid w

Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fddf750e6a664a2d82756bf896bdacad1e10b2a Author: Surinder Kumar

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Thanks, applied. On Thu, Jun 8, 2017 at 1:59 PM, Harshal Dhumal wrote: > Please find attached rebased patch. > > -- > Harshal Dhumal > Sr. Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 7,

[pgadmin-hackers] pgAdmin 4 commit: Fix integer/numeric validation on various dialogues.

Fix integer/numeric validation on various dialogues. Fixes #2421 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa400cbc12f34f219322a2b62f9f51e21d031f0e Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

Exactly what my review was going to say :-) On Thu, Jun 8, 2017 at 3:07 PM, Sarah McAlear wrote: > Hi Surinder! > > We reviewed the patch and the changes look great. Could you change the grays > to match the style guide? > > Silver, #222, and #aaa aren't listed in

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi Murtuza, This was before we had checkboxes removed and added column and row highlighting. Try looking at this now with the query results grid updates and let me know what you think. On Thu, Jun 8, 2017 at 1:19 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > I

[pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

Hi, *Changes:* 1) Display only border-top for data-grid header instead of border on whole data-grid. 2) Remove dotted border from cell right for consistency. 3) Add border-bottom for header-row so that on scroll to bottom header rows are differentiated from cells. Also, due to these changes,

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar wrote: > Hi > > The attribute key for Ok, Save buttons should be mapped to 13(Enter), > for Help - 112(F1) and > for Cancel - 27(Esc) > The above changes are made into all dialog related template files. > > PFA

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

Thanks, applied. Can you update the data types feature test to cover this case please? Thanks. On Thu, Jun 8, 2017 at 6:51 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the handling of double precision[] type. > RM#1928 > > Steps to re-produce:

[pgadmin-hackers] pgAdmin 4 commit: Fix the handling of double precision[] type. Fixes #

Fix the handling of double precision[] type. Fixes #1928 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3bcbc505258e4583d94a40c6e0506046bdc21b98 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

Hi, The issue is fixed now. Added a new "stats.sql" file with updated columns for the version 10.0_plus PFA RM patch. Regards, Atul RM_2450.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

Hi Surinder! We reviewed the patch and the changes look great. Could you change the grays to match the style guide? Silver, #222, and #aaa aren't listed in pgadmin.style.css. Thanks so much! Shirley & Sarah On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar < surinder.ku...@enterprisedb.com>

[pgadmin-hackers] pgAdmin 4 commit: Set focus on the first enabled field when a dialogue

Set focus on the first enabled field when a dialogue is opened. Fixes #1533 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c9b717ed68797740a6ea8d3480627fe21777a8a8 Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1533]: Set focus on first field when new dialog window is presented

Thanks, patch applied. On Thu, Jun 8, 2017 at 5:34 AM, Surinder Kumar wrote: > Hi > > PFA patch and review. > > Thanks > Surinder > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi On Thu, Jun 8, 2017 at 2:18 PM, Sarah McAlear wrote: > On Thu, Jun 8, 2017 at 8:34 AM, Dave Page wrote: >> - There are changes to SlickGrid, the addition of a function to scroll >> a column into view. Is this submitted upstream and accepted? > > We

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

Hi Atul, On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma wrote: > Hi, > > The issue is fixed now. Added a new "stats.sql" file with updated columns > for the version 10.0_plus > > PFA RM patch. As PostgreSQL has moved to a 2 digit version number system instead of 3, I

Re: [pgadmin-hackers] Style guide live website - looking for feedback

> > > Looks good. A couple of thoughts: > > - Please use "pgAdmin 4" consistently :-) > > Just to clarify - is there always a space between pgAdmin and 4? or is it pgAdmin4? > - The neutral message panel has a border that is quite visible, whilst > the others have much more subtle borders. Seems

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #144

See Changes: [Dave Page] Fix various issues with pgAgent job steps and schedules: [Dave Page] Fix an intermittent error seen during result polling. Fixes #2470 [Dave Page] Retain column sizing in the

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi George On Wed, Jun 7, 2017 at 10:21 PM, George Gelashvili wrote: > Hi Dave, > > I split the linting out into an intermediate commit, and rebased on top of > master. Unfortunately, it still doesn't apply: error: patch failed: web/regression/javascript/test-main.js:1

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hi On Wed, Jun 7, 2017 at 7:10 PM, Joao Pedro De Almeida Pereira wrote: > Hello Dave, > By the description on the email, it looks like the process is very similar > to the Grunt process that we were talking about, but without the patch, it > is a bit hard to get

[pgadmin-hackers] pgAdmin 4 commit: Fix an intermittent error seen during result polling.

Fix an intermittent error seen during result polling. Fixes #2470 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=678b891ff76fea6f2c287d1eb3bc84ff242c61b4 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4] To fix the error "ValueError: too many values to unpack" while polling

Thanks, applied. On Wed, Jun 7, 2017 at 1:26 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in query tool result polling causing > exception, > ValueError: too many values to unpack > RM#2470 > > -- > Regards, > Murtuza Zabuawala >

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Please find attached rebased patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 7, 2017 at 6:59 PM, Dave Page wrote: > Can you rebase this please? I think Ashesh broke it :-p > >

[pgadmin-hackers] pgAdmin 4 commit: Improvements to the Query Results grid:

Improvements to the Query Results grid: - Improve the UI - Allow copy/paste from sets of rows, columns or arbitrary blocks of cells Patch by Matt, Shruti, Joao and Sarah @ Pivotal Fixes #2476 Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi! Thanks, patch applied... but I have one issue and one question: - There are changes to SlickGrid, the addition of a function to scroll a column into view. Is this submitted upstream and accepted? - One of the regression tests now fails because it's trying to access an element that's out of

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Ignore this patch. Rebase and migration of feature tests and jasmine tests required. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 3:56 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Thu, Jun 8, 2017 at 8:34 AM, Dave Page wrote: > Hi! > > Thanks, patch applied... but I have one issue and one question: > > - There are changes to SlickGrid, the addition of a function to scroll > a column into view. Is this submitted upstream and accepted? > We have

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

> > Thanks. When I run the tests my browser opens in some default size > that's always consistent, but doesn't match my normal Chrome sessions, > or the 1024x1024 default set in app_starter.py. This looks like an issue with string edit box placement in the implementation. We created an issue for

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

Thanks, applied! On Thu, Jun 8, 2017 at 4:53 PM, Surinder Kumar wrote: > Hi > > I > have > replaced Silver, #222, and #aaa colors > with relevant > colors > defined in pgadmin.styles.css > Also, the header rows > left & > right > border > color is changed to

[pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

Hi Hackers, This patch changes the ACI Tree font to the font used in the rest of the project and increases the size to match, Helvetica. Thanks, Shirley & Sarah diff --git a/web/pgadmin/static/css/aci_tree.overrides.css b/web/pgadmin/static/css/aci_tree.overrides.css new file mode 100644 index