[pgadmin-hackers] backgrid select2 cell

2016-01-06 Thread Harshal Dhumal
: "Select an option"}}, . . -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js index b12c089..de73b63 100644 --- a/web/p

[pgadmin-hackers] backform select2 control

2016-01-05 Thread Harshal Dhumal
Hi, Please find patch for backform select2 and select2ajaxoptoins controls Usage: schema: [{ id: 'name', label: '{{ _('Name') }}', cell: 'string', type: 'select2', select2:{tags: "true", placeholder: "Select an option", allowClear: true} } . . . -- *Harshal Dhumal

[pgadmin-hackers] backgrid select2 cell fixed issue for optionsValues

2016-01-06 Thread Harshal Dhumal
Hi, Please find minor patch to fix optionsValues for backgrid cell. *Issue:* Fixed issue when accessing OptionValues from view -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js b/web/p

Re: [pgadmin-hackers] backform select2 control

2016-01-06 Thread Harshal Dhumal
Hi, Updated patch. As yesterdays patch for backform select2 and select2ajaxoptoins controls was throwing malformed patch error. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Jan 6, 2016 at 12:01 PM, Harshal Dhumal < ha

[pgadmin-hackers] variable.js number formatting and sesschanged atrrib fix [pgadmin4]

2016-01-12 Thread Harshal Dhumal
Hi, Please find attached patch for number formating issue in variable.js and session changed duplicate values issue. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/static/js/variable.js

[pgadmin-hackers] Patch for TypeError: this.field is undefined error

2016-01-11 Thread Harshal Dhumal
Hi, Please find attached minor patch for TypeError: this.field is undefined error in pgadmin.backform.js -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgad

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

2016-06-03 Thread Harshal Dhumal
Hi, PFA attached patch (V5) for user management functionality. Note: If you've applied any of the previous patch of this functionality then set ConfigDB value to 10 in version table of and also delete role 'Standard' from role table before applying this patch. On Fri, Jun 3, 2016 at 4:39 PM,

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

2016-06-07 Thread Harshal Dhumal
Hi, PFA patch for user management issues. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 6:06 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Thanks - I've commit as-is (

[pgadmin-hackers] Email validation in setup.py [pgadmin4]

2016-06-09 Thread Harshal Dhumal
Hi, PFA patch for email validation in setup.py -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/setup.py b/web/setup.py index 4ea28e1..5f13e83 100644 --- a/web/setup.py +++ b/web/setup.py @@ -15,6 +15,7

[pgadmin-hackers] PAtch for RM 1107 [pgadmin4]

2016-06-09 Thread Harshal Dhumal
with create statement and also create statement cannot be executed inside database transaction):* Database, Tablespace *2]* Fixed typo in databases/templates/databases/sql/9.3_plus/grant.sql -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise

[pgadmin-hackers] Removed unwanted empty_value form Select2 template [pgadmin4]

2016-06-09 Thread Harshal Dhumal
Hi, PFA patch for select2 control in exclusion constraint. Fixed template render issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables

[pgadmin-hackers] Fix for RM1318 [pgadmin4]

2016-06-13 Thread Harshal Dhumal
Hi, PFA attached patch for issue RM1318. Issue fixed: Added help buttons on backup, restore, maintenance, user management dialogs. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

[pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Harshal Dhumal
Hi, PFA patch for RM1210 <https://redmine.postgresql.org/issues/1210> -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/__init_

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Harshal Dhumal
nd how did you fix it? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > > On Fri,

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Harshal Dhumal
urning sql. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 3, 2016 at 1:04 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal < > harshal.dhu..

[pgadmin-hackers] Evaluate Sellect2 cell options properly [pgadmin4]

2016-06-03 Thread Harshal Dhumal
t look for "options" in column definition but still we were looking for "options". This was causing javascript code to break if "options" were not passed in column definition. Error fixed: TypeError: this.column.get(...) is not a function (this.column.get('op

[pgadmin-hackers] Destroy header controls properly [pgadmin4]

2016-06-03 Thread Harshal Dhumal
Hi, PFA patch for tokes control in fts configuration and variable control. Issue fixed : Destroy header controls properly. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers] Fix for RM1318 [pgadmin4]

2016-06-13 Thread Harshal Dhumal
Hi, PFA patch for issue RM1318 with remaining bug fixes. On Mon, Jun 13, 2016 at 8:49 PM, Dave Page <dp...@pgadmin.org> wrote: > On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal > <harshal.dhu...@enterprisedb.com> wrote: > > Hi, > > > > PFA attached patch

[pgadmin-hackers] Fix for issue RM1348 [pgadmin4]

2016-06-13 Thread Harshal Dhumal
Hi, PFA patch for issue RM1348. Issue fixed: Not to show multiple 'Reset Layout' options under file menu. Also restructured code related to reset layout functionality. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

2016-06-14 Thread Harshal Dhumal
Hi, PFA patch for issue RM 1313. Changes: Added connect now option in server create dialog. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

2016-06-15 Thread Harshal Dhumal
Hi, PFA attached patch for RM1313 updates and RM1363 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 10:40 PM, Dave Page <dp...@pgadmin.org> wrote: > On Tue, Jun 14, 2016 at 5:28 PM,

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

2016-05-31 Thread Harshal Dhumal
Hi, PFA updated patch for user management. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Mon, May 30, 2016 at 5:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Harshal, > > > Please find the review comm

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

2016-05-31 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > PFA comments as below, > > 1) While running setup.py

[pgadmin-hackers] Regarding issue 1241

2016-05-31 Thread Harshal Dhumal
label tab. For Privileges tab I have reduced column resizing margin at some extent but not 100%. Regards, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make cha

[pgadmin-hackers] User management functionality patch [pgadmin4]

2016-05-27 Thread Harshal Dhumal
Hi, PFA initial patch for User management functionality. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/requirements_py2.txt b/requirements_py2.txt index a442e36..f3d8622 100644 --- a/requirements_py2.txt +++ b/requirements_py2.txt @@

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

2016-06-02 Thread Harshal Dhumal
Hi, This patch requires backgrid password cell for I have sent patch yesterday. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 2, 2016 at 7:12 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com>

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

2016-06-02 Thread Harshal Dhumal
Hi, PFA patch for user management functionality. Major changes in this patch are: 1. In-place editing of user and saving on server. 2. Removed dependency on marshmallow python package. 3. UI improvements. 4. Search by email. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India

[pgadmin-hackers] Backgrid passwordCell [pgadmin4]

2016-06-01 Thread Harshal Dhumal
Hi, PFA patch for backgrid passwordCell Usage: schema: [{ id: 'pass', label: '{{ _('New Password') }}', cell: 'password' }] -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/stat

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-21 Thread Harshal Dhumal
Hi, This patch consist fix for only RM1220 I'll send another patch for RM1221 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 21, 2016 at 4:08 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com>

[pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-21 Thread Harshal Dhumal
Hi, PFA patch for issues RM1220 and RM1221 Issue fixed: Backup, Restore and Maintenance were causing error with database name with special characters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-22 Thread Harshal Dhumal
Hi, PFA updated patch for issues 1220 and 1221 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 21, 2016 at 4:41 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Jun 21, 2016 at 11

[pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-16 Thread Harshal Dhumal
et on any disabled button inside query tool or out side the query tool. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/datagrid/templates/datagrid/index.html b/web/pgadmin/tools/datagrid/templates

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-16 Thread Harshal Dhumal
Hi Dave, Function keys won't work properly with browser as they already have predefined bindings. e.g. F5 for refresh (standard) F7 for Caret Browsing in firefox -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-16 Thread Harshal Dhumal
patch? On Thu, Jun 16, 2016 at 4:19 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite > the bullet and make it configurable. > On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal > <harshal.dhu...@enterpris

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-16 Thread Harshal Dhumal
Hi Dave, Ok, I'll change shortcut keys New shortcuts would be: Execute --> F5 Explain -->F7 Explain analyze --> Shift+F7 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 16, 2016 at 4:03

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-23 Thread Harshal Dhumal
One more thing that this also fails in pgadmin3 as well. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 23, 2016 at 6:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, >

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-23 Thread Harshal Dhumal
is *"!#$%^&*()_+{}|:\"<>?=-\\][';/**.,"* but in pg_dump error it says *failed: invalid connection option "!#$%^&*()_+{}|:"<>?"* -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Compa

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-20 Thread Harshal Dhumal
functionality (like resize, move, minimize, maximize etc). And regarding Ctrl+F5, it is for hard refresh on some browsers. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 16, 2016 at 8:03 PM, Dave Page <

[pgadmin-hackers] Fix for RM1386 [pgamin4]

2016-06-21 Thread Harshal Dhumal
Hi, PFA patch for issue RM1386 Issue Fixed: Now User cannot be created with single (or less than 6 ) character password. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/user_management

[pgadmin-hackers] Variable js issue [pgAdmin4]

2016-01-17 Thread Harshal Dhumal
Hi, Here is patch for variable.js Issues fixed: 1. Parsing variables values of type int and float/real [Ashesh Vashi]. 2. variables tab header form control not found issue [Ashesh Vashi]. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff

[pgadmin-hackers] New mechanism in backgrid to render different types of cells in same column [pgAdmin4]

2016-01-18 Thread Harshal Dhumal
} else { return Backgrid.NumberCell; } } }, {id: 'database', label:'Database', type: 'text', editable: false}, . . . -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/stati

[pgadmin-hackers] Re: New mechanism in backgrid to render different types of cells in same column [pgAdmin4]

2016-01-18 Thread Harshal Dhumal
+ Also fixed some minor issues related to Unique column functionality in Variable control in same patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Tue, Jan 19, 2016 at 12:37 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com>

[pgadmin-hackers] Privilege control with select2cell for user role section

2016-01-15 Thread Harshal Dhumal
Hi, Please find the attached path for Privilege control with select2cell for user role section TODO: Need to add current database logged in user in Granter filed in privilege grid control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff

Re: [pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, PFA patch for schema macros for security and privilege. Now I have moved macros related to schema and its child object under schemas/templates/macros/schemas folder -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Feb 10, 2016 at 5

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, PFA updated patch for sequence node. *Changes:* Updated sql files to refer macros from schemas/templates/macros/schemas folder instead of servers/templates/macros -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Feb 10, 2016 at 5

Re: [pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
, object_name, privileges_without_grant, privileges_with_grant, object.schema) PRIVILEGE.UNSETALL(conn, object_type, grantee, object_name, schema) privileges_without_grant = comma separated string of privileges. privileges_with_grant = comma separated string of privileges. -- *Harshal Dhumal

[pgadmin-hackers] Common utility functions to parse privileges [pgadmin4]

2016-02-04 Thread Harshal Dhumal
Hi, PFA patch for server utility functions to parse privileges. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/utils.py b/web/pgadmin/browser/server_groups/servers/utils.py new file mode

[pgadmin-hackers] Patch sequence node [pgadmin4]

2016-02-09 Thread Harshal Dhumal
Hi, PFA patch for sequence node. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/sequences/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/seq

[pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-09 Thread Harshal Dhumal
Hi, PFA of macros (privilege, security) for sequence node. Also fixed minor issue in security macro (removed unwanted qtIdent for provider) -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/tem

[pgadmin-hackers] Minor database patch [pgadmin4]

2016-02-09 Thread Harshal Dhumal
Hi, PFA patch for database node. Enhancement: We don't need to disconnect and connect to databse for each single offline query. We can disconnect once then apply queries and then connect again. And minor code refactoring (more pythonic way) -- *Harshal Dhumal* *Software Engineer

Re: [pgadmin-hackers] Minor issue in variable js [pgadmin4]

2016-02-05 Thread Harshal Dhumal
Hi All, Now ignore this patch as this issue is covered in this commit. <http://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=a0648ed54b9a5079434d8a4ebcd09e30e3f54098> -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Tue, Feb 2,

[pgadmin-hackers] Privilege control: disable with grant ops if grantee is public [pgAdmin4]

2016-02-10 Thread Harshal Dhumal
Hi, PFA patch for privilege control. *Issue fixed:* Disable all with grant options if grantee is public. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/static/js/privilege.js b/web/pgadmin/b

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-11 Thread Harshal Dhumal
6 were given *- *In pgadmin3 it shows drop down for language name while in pgadmin4 in edit mode it shows input text *.* Need some clarification whether user is allowed to enter any language name or can only select from predefined language names. Regards, ~Harshal -- *Harshal Dhumal* *Softwa

[pgadmin-hackers] Event trigges node patch [pgadmin4]

2016-02-11 Thread Harshal Dhumal
Hi, PFA patch event triggers node. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> event_triggers_12_Frb_1.parch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscr

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-12 Thread Harshal Dhumal
Hi, New language patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ? Thank you, Harshal -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, Feb 11, 2016 at 4:01 PM, Akshay Joshi <

Re: [pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, Here is updated patch for macros. I have added required validation in macros. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Feb 10, 2016 at 1:06 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > On Tue, Feb 9,

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, Here is updated patch for sequence node. As macros are changed for security and privileges. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Tue, Feb 9, 2016 at 4:19 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi

Re: [pgadmin-hackers] Updated patches

2016-02-03 Thread Harshal Dhumal
-- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Feb 3, 2016 at 2:47 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for database node. > > I have fixed almost all issues reported

[pgadmin-hackers] Minor issue in variable js [pgadmin4]

2016-02-02 Thread Harshal Dhumal
Hi, PFA minor patch for variable js. Issue fixed: Initialize boolean cell with proper data (either true or false not undefined). -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/static/js/varia

[pgadmin-hackers] Updated patches

2016-01-22 Thread Harshal Dhumal
Hi, PFA updated patches: I have made changes as per Ashesh's suggestions. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/dat

[pgadmin-hackers] Database patch and other minor patches and control documentation

2016-01-21 Thread Harshal Dhumal
t same time)* (In below example you can see hasRole:true as I need role field in variable control for database node) { id: 'variables', label: '{{ _('Variables') }}', type: 'collection', model: pgAdmin.Browser.Node.VariableModel, editable: false, group: '{{ _('Security') }}', mode: ['properties',

[pgadmin-hackers] Patch for minor UI issues [pgadmin4]

2016-01-20 Thread Harshal Dhumal
Hi, PFA patches for minor issues in status bar and border issue in Unique coll collection. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/n

[pgadmin-hackers] python 2.6 support [pgAdmin4]

2016-01-27 Thread Harshal Dhumal
. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/requirements_py2.txt b/requirements_py2.txt index b7475cd..8dc6caa 100644 --- a/requirements_py2.txt +++ b/requirements_py2.txt @@ -27,3 +27,4 @@ speaklater==1.3 pycrypto==2.6.1 wsgiref==0.1.2 simp

[pgadmin-hackers] work status

2016-02-14 Thread Harshal Dhumal
Hi, I have started working on Backup Globals feature. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com>

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

2016-03-09 Thread Harshal Dhumal
Hi, PFA updated patch for sequence node. Changes: 1] Added changes related to schema child node. 2] re-based with latest code. 3] Added dependencies and dependents functionality. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <h

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

2016-03-10 Thread Harshal Dhumal
Hi, PFA update patch for sequence node. Changes: Fixed leaf node issue. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, Mar 10, 2016 at 12:45 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > &

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-18 Thread Harshal Dhumal
Hi Dave, This seems to be some dependency issue. Can you please send me a screenshot of debugger console with js error stack. Regards, Harshal -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, Mar 17, 2016 at 10:33 PM, Dave Pa

[pgadmin-hackers] Primary key constraint [pgadmin4]

2016-03-15 Thread Harshal Dhumal
Hi PFA patch for primary key constraint. Note: This patch has dependency on Table, Column node and backform multiselect control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/databases/s

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-15 Thread Harshal Dhumal
Hi, PFA generalized updated patch for backform multiSelectControl. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA backform

Re: [pgadmin-hackers] Event trigges node patch [pgadmin4]

2016-03-09 Thread Harshal Dhumal
Hi, PFA updated patch for events trigger node. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Fri, Mar 4, 2016 at 7:58 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, Feb 12, 2016 at 6:32 AM, Harshal D

[pgadmin-hackers] Subnode grid row close issue [pgAdmin4]

2016-03-19 Thread Harshal Dhumal
Hi, PFA patch for Subnode grid row close issue. Issue fixed: 1] Close any existing row while adding new row. 2] Close any existing row if we edit new row. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/sta

[pgadmin-hackers] Tree reload & panel close issue after saving new node on server [pgadmin4]

2016-03-31 Thread Harshal Dhumal
.* -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js index 5d6ec86..bb683ee 100644 --- a/web/pgadmin/browser/templates/browser/js/node.js +++

[pgadmin-hackers] Patch for index constraint (primary and unique key) [pgadmin4]

2016-04-11 Thread Harshal Dhumal
Hi, PAF patch for exclusion constraint which takes care both primary and unique key. Note: This patch has dependency on Table, Column node and Index constraint. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/b

[pgadmin-hackers] Initial foreign key constraint node patch [pgadmin4]

2016-04-11 Thread Harshal Dhumal
Hi, PFA initial patch for foreign key constraint. Note: This patch has dependency on Table, Column node and Index constraint. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/

[pgadmin-hackers] Dialog issue: General category text is shown as undefined [pgadmin4]

2016-04-12 Thread Harshal Dhumal
Hi, PFA minor patch for message.js Issue fixed : Dialog issue, General category text is shown as undefined -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/templates/browser/js/messages.js b/web/pgadmin/browser/tem

[pgadmin-hackers] Patch for exclusion constraint [pgadmin4]

2016-04-11 Thread Harshal Dhumal
Hi, PAF patch for exclusion constraint. Note: This patch has dependency on Table, Column node and Index constraint (I'll be sending patch for index constraint immediately after this). -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git

Re: [pgadmin-hackers] Subnode grid row close issue [pgAdmin4]

2016-03-19 Thread Harshal Dhumal
Hi, Here is updated patch. In initial patch I fixed this issue in only Subnode control while Type node uses unique collection control (which is special case of subnode control). Now I have fixed in both control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <h

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-21 Thread Harshal Dhumal
Hi, Here is updated patch -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Fri, Mar 18, 2016 at 9:37 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal < > harshal.dhu...@enter

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-03-19 Thread Harshal Dhumal
Hi Dave, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, Mar 17, 2016 at 4:13 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com&

[pgadmin-hackers] Switch control options issue [pgadmin4]

2016-03-22 Thread Harshal Dhumal
Hi, PFA patch for switch control. Issue: Configuration options for switch control from different places should be merged together and not overridden. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backform.pgad

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-22 Thread Harshal Dhumal
Hi, PFA patch for MultiselectControl. Issue: Fixed issue when parsing undefined data as json. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Mon, Mar 21, 2016 at 11:35 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: &g

[pgadmin-hackers] Disabled option to bootstrap switch control [pgadmin4]

2016-03-23 Thread Harshal Dhumal
Hi, PFA minor patch for switch control. Change: Added disabled option to bootstrap switch control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-08 Thread Harshal Dhumal
Hi Dave, Currently there is no test dialogue to test this control. Also Ashesh has suggested some changes. Once I complete those changes; I'll resubmit the patch along with test dialogue to test it. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.

[pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-07 Thread Harshal Dhumal
, deps: ['index'], node: 'column', model: pgBrowser.Node.Model.extend({ keys: ['column'], defaults: { column: undefined } }) } Note: When using this control model should have *column* attribute. And node property should be *column*. -- *Harshal Dhumal* *Software

[pgadmin-hackers] Numeric control optionally allow null values [pgadmin4]

2016-03-03 Thread Harshal Dhumal
: ['index'], type: 'numeric', group: '{{ _('Definition') }}', allowNull: true, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index 4346156..82963bb

Re: [pgadmin-hackers] Numeric control optionally allow null values [pgadmin4]

2016-03-03 Thread Harshal Dhumal
: '{{ _('Fill factor') }}', deps: ['index'], type: 'numeric', group: '{{ _('Definition') }}', allowNull: true, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Fri, Mar 4, 2016 at 10:55 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com>

[pgadmin-hackers] [pgadmin3] [postgresSQL] [bug] Two or more different types of constraints with same name creates ambiguity while drooping.

2016-03-29 Thread Harshal Dhumal
with same was there. *Note: Create foreign key first with some name and then primary key with same name.* -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com>

Re: [pgadmin-hackers] Minor issues

2016-04-29 Thread Harshal Dhumal
-- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Fri, Apr 29, 2016 at 11:52 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for minor issues. > > Issues fixed: > > 1] Removed unwan

[pgadmin-hackers] Minor issues

2016-04-29 Thread Harshal Dhumal
Hi, PFA patch for minor issues. Issues fixed: 1] Removed unwanted "{% if %}" from database 9.1 nodes.sql 2] Fixed issue while removing select2cell fro backgrid. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-28 Thread Harshal Dhumal
-- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, Apr 28, 2016 at 2:22 PM, Dave Page <dp...@pgadmin.org> wrote: > > > > On 27 Apr 2016, at 13:43, Thom Brown <t...@linux.com> wrote: > > > > On 27 April 2016

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-27 Thread Harshal Dhumal
Hi, The exclusion constraint has minor validation issue (this won't block testing of patch). I'm closely working with Ashesh to fix this. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Apr 27, 2016 at 2:52 PM, Harshal Dhumal < ha

[pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

2016-05-24 Thread Harshal Dhumal
Hi, PFA patch for server and database node: Issue fixed: Added node type check in is_connected check. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/database

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

2016-05-24 Thread Harshal Dhumal
if that menu has check on is_connected function. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Tue, May 24, 2016 at 12:13 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > > On Tue, May 24, 2016 at 12:06 PM, Harshal Dhum

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi Akshay, Murtuza hasn't fixed it in all places. He missed in following tow functions connect_server and disconnect_server -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi <akshay.jo...@enterpr

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-12 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Tue, May 10, 2016 at 6:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > Pending issues to be fixed which I tried but not able to fix

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, PFA updated patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > Hi Harshal > > Below are my review comments : > >- Facing

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, May 12, 2016 at 4:16 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com>

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, PFA updated patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, May 12, 2016 at 1:27 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > This patch needs a rebase. (as "Named restore po

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, This patch needs a rebase. (as "Named restore point" patch is committed.) -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, May 11, 2016 at 12:35 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, &

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-17 Thread Harshal Dhumal
sname" and in python you have applied validations on key "parser") 3. When we clear dictionary for any token using cross (x) button in select2; JavaScript code for selecct2 fails. (see attached screenshot) -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterpr

  1   2   3   >