Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-13 Thread Dave Page
Thanks, applied.

On Mon, Jun 12, 2017 at 8:14 PM, Joao Pedro De Almeida Pereira
 wrote:
> Hello Hackers,
> We sent the wrong patch. Attached is the correct one.
>
> Sorry
>
> Shruti & Joao
>
> On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira
>  wrote:
>>
>> Hi Hackers,
>>
>> We were trying to run the feature tests against GreenPlum and one of the
>> tests was failing (CheckForViewDataTest). In this test, we are creating a
>> table using COLLATE, and the COLLATE command is only available starting in
>> version 9.1 of Postgres, per the documentation. We decided to skip this test
>> for now for all PG Versions below 9.1
>>
>> Thanks
>> Shruti & Joao
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-12 Thread Joao Pedro De Almeida Pereira
Hello Hackers,
We sent the wrong patch. Attached is the correct one.

Sorry

Shruti & Joao

On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> We were trying to run the feature tests against GreenPlum and one of the
> tests was failing (CheckForViewDataTest). In this test, we are creating a
> table using COLLATE, and the COLLATE command is only available starting
> in version 9.1 of Postgres, per the documentation. We decided to skip this
> test for now for all PG Versions below 9.1
>
> Thanks
> Shruti & Joao
>


skip-collate-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-12 Thread Joao Pedro De Almeida Pereira
Hi Hackers,

We were trying to run the feature tests against GreenPlum and one of the
tests was failing (CheckForViewDataTest). In this test, we are creating a
table using COLLATE, and the COLLATE command is only available starting in
version 9.1 of Postgres, per the documentation. We decided to skip this
test for now for all PG Versions below 9.1

Thanks
Shruti & Joao


skip-collate-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers