Re: [pgadmin-hackers] Minor issue in variable js [pgadmin4]

[Harshal Dhumal]

Hi All,

Now ignore this patch as this issue is covered in this commit.


-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 

On Tue, Feb 2, 2016 at 4:55 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch for variable js.
>
> Issue fixed: Initialize boolean cell with proper data (either true or
> false not undefined).
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB 
>

[pgadmin-hackers] Minor issue in variable js [pgadmin4]

[Harshal Dhumal]

Hi,

PFA minor patch for variable js.

Issue fixed: Initialize boolean cell with proper data (either true or false
not undefined).

-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 
diff --git a/web/pgadmin/browser/server_groups/servers/static/js/variable.js b/web/pgadmin/browser/server_groups/servers/static/js/variable.js
index fd3a0bb..8308c27 100644
--- a/web/pgadmin/browser/server_groups/servers/static/js/variable.js
+++ b/web/pgadmin/browser/server_groups/servers/static/js/variable.js
@@ -120,7 +120,11 @@
 
   switch(variable && variable.vartype) {
 case "bool":
-  // There are no specific properties for BooleanCell.
+  /*
+   * bool cell and variable can not be stateless (i.e undefined).
+   * It should be either true or false.
+   */
+  opts.model.set("value", Boolean(opts.model.get("value")));
   break;
 
 case "enum":

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers