Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Great - all tests pass now. So, it would be very helpful if the rest of the tests that are outstanding can now be completed before GA is wrapped on Monday :-) Thanks! On Thu, Sep 22, 2016 at 8:09 AM, Harshal Dhumal wrote: > Hi, > > Please find attached updated

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi, Please find attached updated patch for RM1720. Also test this patch with updated test suite patch which Navnath would be sending. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 21, 2016 at 8:39 PM,

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

On Wed, Sep 21, 2016 at 4:02 PM, Navnath Gadakh wrote: > Hi Dave, > Can you please run testsuite for server or database node only, as > there are some code modifications are remaining on the rest of the nodes. > Currently i don't have a machine to look

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi Dave, Can you please run testsuite for server or database node only, as there are some code modifications are remaining on the rest of the nodes. Currently i don't have a machine to look into issue, will check it tomorrow. Thanks. On 21-Sep-2016 6:50 PM, "Dave Page"

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi On Wed, Sep 21, 2016 at 1:57 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for RM1720 > > > Issue: In pgAdmin4 we use server id (sid, which is id of server table in > sqlite db) as key to keep track of server connection (server manger). But > sqlite reuses

[pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi, PFA patch for RM1720 Issue: In pgAdmin4 we use server id (sid, which is id of server table in sqlite db) as key to keep track of server connection (server manger). But sqlite reuses these ids and therefore pgadmin4 connection manager assigns connection details of one database server to