Thanks, applied.
On Tue, Sep 20, 2016 at 11:39 AM, Surinder Kumar
wrote:
> Please find updated patch with suggested changes and inline comments.
>
> Also, Incase if user tries to download csv on queries other than select, we
> are catching that exception and write into 'csv' with name 'error.csv'
Please find updated patch with suggested changes and inline comments.
Also, Incase if user tries to download csv on queries other than select, we
are catching that exception and write into 'csv' with name 'error.csv'.
On Tue, Sep 20, 2016 at 2:33 PM, Dave Page wrote:
> On Tue, Sep 20, 2016 at 6
On Tue, Sep 20, 2016 at 6:43 AM, Surinder Kumar
wrote:
>
> On Mon, Sep 19, 2016 at 8:59 PM, Surinder Kumar
> wrote:
>>
>> On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote:
>>>
>>> Hi
>>>
>>> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar
>>> wrote:
>>> > Hi
>>> >
>>> > Please find attached pat
On Mon, Sep 19, 2016 at 8:59 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote:
>
>> Hi
>>
>> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar
>> wrote:
>> > Hi
>> >
>> > Please find attached patch with fix.
>> >>
>> >> Download as CSV
On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote:
> Hi
>
> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar
> wrote:
> > Hi
> >
> > Please find attached patch with fix.
> >>
> >> Download as CSV
> >> button should be enabled only for SELECT queries.
>
> I'm not sure there's a way to do this with
Hi
On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar
wrote:
> Hi
>
> Please find attached patch with fix.
>>
>> Download as CSV
>> button should be enabled only for SELECT queries.
I'm not sure there's a way to do this without parsing the query.
Simply matching on ^select certainly won't work rel
