Hipgadmin-support-ow...@postgresql.org wrote on 10/07/2012 16:05:18:> From: Dave Page > To: Martin French , > Cc: pgadmin-support@postgresql.org, pgadmin-support-ow...@postgresql.org> Date: 10/07/2012 19:12> Subject: Re: [pgadmin-support] pgAgent reports failure upon success>
On Tue, Jul 10, 2012 at 1:57 PM, Martin French
wrote:
> Hi
>
> Thanks for the feedback. I certainly won't be discouraged by it! :)
:-)
>> - You have member name of [Get|Set]LastResult which set/return a
>> member variable called lastStatus. These should be consistent to avoid
>> confusion.
>
> W
HiThanks for the feedback. I certainly won't be discouraged by it! :)> - You have member name of [Get|Set]LastResult which set/return a> member variable called lastStatus. These should be consistent to avoid> confusion.Will amend accordingly.> - Rather than setting lastStatus to 0 or -1, why not se
Hi
On Mon, Jul 9, 2012 at 10:30 AM, Martin French
wrote:
> Apologies wrong files attached! It is Monday after all... ;o)
>
>
> (See attached file: connection.cpp.patch)(See attached file:
> connection.h.patch)(See attached file: job.cpp.patch)
OK, first of all, thanks for the patch. Second; plea
Tree Diff. diff -r pgAgent-3.2.1-Source pgAgent-3.2.2-Sourcediff -r pgAgent-3.2.1-Source/connection.cpp pgAgent-3.2.2-Source/connection.cpp28a29> lastStatus = 0;339a341> {340a343,344> conn->SetLastResult(0);> }344a349> co
resql.org, pgadmin-support-ow...@postgresql.org> Date: 09/07/2012 10:16> Subject: Re: [pgadmin-support] pgAgent reports failure upon success> > Hi> > On Mon, Jul 9, 2012 at 10:11 AM, Martin French> wrote:> > Proposed patch for this bug in attached files.> >> >
Hi
On Mon, Jul 9, 2012 at 10:11 AM, Martin French
wrote:
> Proposed patch for this bug in attached files.
>
> (See attached file: connection.cpp)(See attached file: connection.h)(See
> attached file: job.cpp)
>
> Tested against PG 9.1.4, all seems fine, success/failure reported correctly
> even w
back.Thanks.pgadmin-support-ow...@postgresql.org wrote on 06/07/2012 12:29:56:> From: Dave Page > To: Martin French , > Cc: pgadmin-support@postgresql.org> Date: 06/07/2012 15:35> Subject: Re: [pgadmin-support] pgAgent reports failure upon success> Sent by: pgadmin-support-ow...@postgresql.org&
On Fri, Jul 6, 2012 at 12:26 PM, Martin French
wrote:
> Yep, can do, and will do Dave.
>
> Will be after the weekend now, but should have something Monday eve.
>
Great.
> Have a good weekend mate.
>
> Cheers
>
And you!
Cheers, Dave.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg
Yep, can do, and will do Dave.Will be after the weekend now, but should have something Monday eve.Have a good weekend mate.CheersDave Page ---06/07/2012 12:22:56---Hi On Fri, Jul 6, 2012 at 11:36 AM, Martin FrenchFrom:Dave Page To:Martin French , Cc:pgadmin-support@postgresq
Hi
On Fri, Jul 6, 2012 at 11:36 AM, Martin French
wrote:
> Hi Dave,
>
> That seems reasonable enough to me.
>
> GetLastError only returns a wxString though, fed from PQerrorMessage so I
> guess it would be the string that would be tested for content?
>
> Maybe passing the ExecStatusType into a DB
Hi Dave,That seems reasonable enough to me. GetLastError only returns a wxString though, fed from PQerrorMessage so I guess it would be the string that would be tested for content?Maybe passing the ExecStatusType into a DBConn/DBResult member variable that could be tested would work better?Thoughts
Hi
On Fri, Jul 6, 2012 at 8:04 AM, Martin French
wrote:
>
> I've been through the code, and the return of 1 is coming back from the
> number of rows inserted after ExecuteVoid so the logic following in job.cpp
> seems incorrect:
>
> wxString stepstatus;
> if (rc ==
13 matches
Mail list logo
