Re: [BUGS] BUG #5915: OldSerXidAdd inflates pg_serial too much

2011-03-08 Thread Heikki Linnakangas
On 06.03.2011 20:32, Kevin Grittner wrote: Heikki Linnakangas wrote: Here's what I had in mind. Can you review The additions and modifications to the comments all look good to me. I can see why you renamed one field and eliminated another; no problem there. I'm really surprised, when you ig

Re: [BUGS] BUG #5918: SummarizeOldestCommittedSxact assertion failure

2011-03-08 Thread Heikki Linnakangas
On 08.03.2011 02:37, YAMAMOTO Takashi wrote: The following bug has been logged online: Bug reference: 5918 Logged by: YAMAMOTO Takashi Email address: y...@mwd.biglobe.ne.jp PostgreSQL version: 9.1devel Operating system: NetBSD Description:SummarizeOldestCommittedSxa

Re: [BUGS] Missing Bug-Report #5904?

2011-03-08 Thread Torsten Zühlsdorff
Hello Tom, Now for the Problem: There is a problem with the translation of the english word "March" to the german "März". Instead of "März" i get "MäRz" (with uppercase "r"). You can reproduce it as follow: # SET lc_time = "de_DE.UTF-8"; # SELECT to_char('2011-03-04 00:00:01'::date, 'TMMonth

Re: [BUGS] BUG #5918: SummarizeOldestCommittedSxact assertion failure

2011-03-08 Thread Dan Ports
On Tue, Mar 08, 2011 at 01:22:20PM +0200, Heikki Linnakangas wrote: > I think we need to just treat an empty list as normal in > SummarizeOldestcommittedSxact(), patch attached. I just hit the same assertion. Testing this patch now. Dan -- Dan R. K. Ports MIT CSAIL

Re: [BUGS] Missing Bug-Report #5904?

2011-03-08 Thread Tom Lane
=?ISO-8859-15?Q?Torsten_Z=FChlsdorff?= writes: >>> # SET lc_time = "de_DE.UTF-8"; >>> # SELECT to_char('2011-03-04 00:00:01'::date, 'TMMonth '); >>> to_char >>> --- >>> MäRz 2011 >> I can reproduce the above when the database encoding is not UTF8 or >> lc_ctype isn't a UTF8 locale. >

Re: [BUGS] Missing Bug-Report #5904?

2011-03-08 Thread Torsten Zühlsdorff
Hello, # SET lc_time = "de_DE.UTF-8"; # SELECT to_char('2011-03-04 00:00:01'::date, 'TMMonth '); to_char --- MäRz 2011 I can reproduce the above when the database encoding is not UTF8 or lc_ctype isn't a UTF8 locale. Hm... encoding of the database is UTF8. The lc_ctype is 'C'.

Re: [BUGS] BUG #5918: SummarizeOldestCommittedSxact assertion failure

2011-03-08 Thread Dan Ports
Looks good -- with this patch I didn't hit any assertion failures or other errors during an hour of stress testing with DBT-2. Dan -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs

Re: [BUGS] CREATEROLE does not permit commenting on newly-created roles

2011-03-08 Thread Alvaro Herrera
Excerpts from Euler Taveira de Oliveira's message of mar mar 08 02:06:13 -0300 2011: > Em 07-03-2011 16:53, Owen Jacobson escreveu: > > psql:repro.sql:2: ERROR: must be member of role "commented_role" to > > comment upon it > > > This isn't a bug; let say it is a limitation (and a documented one

Re: [BUGS] CREATEROLE does not permit commenting on newly-created roles

2011-03-08 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Euler Taveira de Oliveira's message of mar mar 08 02:06:13 > -0300 2011: >> Em 07-03-2011 16:53, Owen Jacobson escreveu: >>> psql:repro.sql:2: ERROR: must be member of role "commented_role" to >>> comment upon it >> This isn't a bug; let say it is a limita

Re: [BUGS] BUG #5918: SummarizeOldestCommittedSxact assertion failure

2011-03-08 Thread Kevin Grittner
Heikki Linnakangas wrote: > On 08.03.2011 02:37, YAMAMOTO Takashi wrote: >> i got the following assertion failure. given that availableList >> is not empty and SxactGlobalXminCount == 0, i guess it was raced >> with ReleasePredicateLocks. > > Yeah, that's what it looks like. One backend calls >

Re: [BUGS] BUG #5918: SummarizeOldestCommittedSxact assertion failure

2011-03-08 Thread Heikki Linnakangas
On 08.03.2011 18:27, Kevin Grittner wrote: Heikki Linnakangas wrote: I think we need to just treat an empty list as normal in SummarizeOldestcommittedSxact(), patch attached. Looks good. I suggest we get that one in before the alpha is cut. Especially since Dan was able to hit that same asse

Re: [BUGS] BUG #5889: "Intersects" for polygons broken

2011-03-08 Thread Robert Haas
On Wed, Feb 16, 2011 at 10:33 AM, Konrad Garus wrote: > 2011/2/16 Tom Lane : >> "Konrad Garus" writes: >>> && operator seems to be broken for polygons whose bounding boxes intersect: >> >>> select polygon'((0,0), (1,2), (0,2))' && polygon'((0.5, 0), (1,0), (1,1))'; >>>  ?column? >>> -- >>

Re: [BUGS] BUG #5889: "Intersects" for polygons broken

2011-03-08 Thread Konrad Garus
http://www.postgresql.org/docs/current/static/functions-geometry.html I wish it explained what arguments each of the operators accepts, and whether any automatic conversions take place (like polygon to box in that 8.3 issue). What happens when I call ?# or ?- on a polygon and point? Two points? O

Re: [BUGS] CREATEROLE does not permit commenting on newly-created roles

2011-03-08 Thread Tom Lane
I wrote: > I thought there was nothing particularly unreasonable about Owen's > suggestion: let users with the CREATEROLE attribute comment on any role. > I don't think COMMENT added to CREATE ROLE would be a very nice fix > (aside from being ugly, what if you want to change the comment later?). >

Re: [BUGS] CREATEROLE does not permit commenting on newly-created roles

2011-03-08 Thread Robert Haas
On Tue, Mar 8, 2011 at 11:48 PM, Tom Lane wrote: > I wrote: >> I thought there was nothing particularly unreasonable about Owen's >> suggestion: let users with the CREATEROLE attribute comment on any role. >> I don't think COMMENT added to CREATE ROLE would be a very nice fix >> (aside from being

Re: [BUGS] CREATEROLE does not permit commenting on newly-created roles

2011-03-08 Thread Tom Lane
Robert Haas writes: > On Tue, Mar 8, 2011 at 11:48 PM, Tom Lane wrote: >> In particular, I suggest the attached patch (code-complete, but sans >> documentation changes). > I think it's a good change, but we should make sure to release-note it > properly, I had already drafted a commit message: