pgsql: Mark some more functions as pg_attribute_noreturn().

2017-11-27 Thread Tom Lane
Mark some more functions as pg_attribute_noreturn(). Doing this suppresses Coverity warnings and might allow improved code in some cases. The prospects of that are not so bright as to warrant back-patching, though. Michael Paquier, per Coverity Branch -- master Details ---

pgsql: Fix assorted syscache lookup sloppiness in partition-related cod

2017-11-27 Thread Tom Lane
Fix assorted syscache lookup sloppiness in partition-related code. heap_drop_with_catalog and ATExecDetachPartition neglected to check for SearchSysCache failures, as noted in bugs #14927 and #14928 from Pan Bian. Such failures are pretty unlikely, since we should already have some sort of lock

pgsql: Fix assorted syscache lookup sloppiness in partition-related cod

2017-11-27 Thread Tom Lane
Fix assorted syscache lookup sloppiness in partition-related code. heap_drop_with_catalog and ATExecDetachPartition neglected to check for SearchSysCache failures, as noted in bugs #14927 and #14928 from Pan Bian. Such failures are pretty unlikely, since we should already have some sort of lock

pgsql: Fix creation of resjunk tlist entries for inherited mixed UPDATE

2017-11-27 Thread Tom Lane
Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE. rewriteTargetListUD's processing is dependent on the relkind of the query's target table. That was fine at the time it was made to act that way, even for queries on inheritance trees, because all tables in an inheritance

pgsql: Fix creation of resjunk tlist entries for inherited mixed UPDATE

2017-11-27 Thread Tom Lane
Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE. rewriteTargetListUD's processing is dependent on the relkind of the query's target table. That was fine at the time it was made to act that way, even for queries on inheritance trees, because all tables in an inheritance

pgsql: Fix creation of resjunk tlist entries for inherited mixed UPDATE

2017-11-27 Thread Tom Lane
Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE. rewriteTargetListUD's processing is dependent on the relkind of the query's target table. That was fine at the time it was made to act that way, even for queries on inheritance trees, because all tables in an inheritance

pgsql: Additional docs for toast_tuple_target changes

2017-11-27 Thread Simon Riggs
Additional docs for toast_tuple_target changes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/117469006bf525c6e8dc84cb9fcbdc4c1a050878 Modified Files -- doc/src/sgml/storage.sgml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

pgsql: Pad XLogReaderState's per-buffer data_bufsz more aggressively.

2017-11-27 Thread Simon Riggs
Pad XLogReaderState's per-buffer data_bufsz more aggressively. Originally, we palloc'd this buffer just barely big enough to hold the largest xlog backup block seen so far. We now MAXALIGN the palloc size. The original coding could result in many repeated palloc cycles, in the worst case where

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/65f1623336a39f65a9d8a34e06f127cae583ff3b Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d5f965c257aed40d515e6b518422ac6e6982c46c Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/510cc2e048f800e1764a6d6cbcf8fff4e3bda1fd Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/caa6e12b5deb3ece8828507b2b4d4e1218d42ed7 Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f2d0af1719e608a7d5d1e51620c4b914b3137fa Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)