Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Thomas Munro
On Mon, Dec 4, 2017 at 12:18 PM, Thomas Munro wrote: > On Mon, Dec 4, 2017 at 9:12 AM, Thomas Munro > wrote: >> On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote: >>> On 2017-11-30 08:06:44 -0800, Andres Freund wrote: At the current rate of failure I'm slightly inclined to just leave the

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Thomas Munro
On Mon, Dec 4, 2017 at 9:12 AM, Thomas Munro wrote: > On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote: >> On 2017-11-30 08:06:44 -0800, Andres Freund wrote: >>> At the current rate of failure I'm slightly inclined to just leave the >>> occasionally failing test, which sounds like an actual bu

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Thomas Munro
On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote: > On 2017-11-30 08:06:44 -0800, Andres Freund wrote: >> At the current rate of failure I'm slightly inclined to just leave the >> occasionally failing test, which sounds like an actual bug imo, in place >> till we have the fix. But if there's a

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Andres Freund
On 2017-11-30 08:06:44 -0800, Andres Freund wrote: > Hi, > > On 2017-11-30 23:53:55 +1300, Thomas Munro wrote: > > On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro > > wrote: > > > On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote: > > >> Andres Freund writes: > > >>> Add some regression tests that

pgsql: Fix uninitialized-variable compiler warning induced by commit e4

2017-12-03 Thread Tom Lane
Fix uninitialized-variable compiler warning induced by commit e4128ee76. I'm a little bit astonished that anyone's compiler would have failed to complain about this. The compiler surely does not know that is_procedure means the function return value will be ignored. Branch -- master Details