Re: pgsql: Use new overflow aware integer operations.

2017-12-22 Thread Andres Freund
On December 22, 2017 7:52:54 PM GMT+01:00, Tom Lane wrote: >Andres Freund writes: >> On 2017-12-22 11:00:54 -0500, Tom Lane wrote: >>> I do not think it is reasonable for these functions to not set the >>> output variable at all in the overflow case; it is not their job >>> to opine on whether

Re: pgsql: Use new overflow aware integer operations.

2017-12-22 Thread Tom Lane
Andres Freund writes: > On 2017-12-22 11:00:54 -0500, Tom Lane wrote: >> I do not think it is reasonable for these functions to not set the >> output variable at all in the overflow case; it is not their job >> to opine on whether the caller may use the result. > I don't agree. Please note that t

Re: pgsql: Use new overflow aware integer operations.

2017-12-22 Thread Andres Freund
Hi, On 2017-12-22 11:00:54 -0500, Tom Lane wrote: > Andres Freund writes: > > Use new overflow aware integer operations. > > I just tried to compile manually on prairiedog for the first time since > this went in, and noticed that it now produces a boatload of warnings > like > > int.c: In funct

pgsql: Disallow UNION/INTERSECT/EXCEPT over no columns.

2017-12-22 Thread Tom Lane
Disallow UNION/INTERSECT/EXCEPT over no columns. Since 9.4, we've allowed the syntax "select union select" and variants of that. However, the planner wasn't expecting a no-column set operation and ended up treating the set operation as if it were UNION ALL. Pre-v10, there seem to be some executo

pgsql: Disallow UNION/INTERSECT/EXCEPT over no columns.

2017-12-22 Thread Tom Lane
Disallow UNION/INTERSECT/EXCEPT over no columns. Since 9.4, we've allowed the syntax "select union select" and variants of that. However, the planner wasn't expecting a no-column set operation and ended up treating the set operation as if it were UNION ALL. Pre-v10, there seem to be some executo

pgsql: Fix UNION/INTERSECT/EXCEPT over no columns.

2017-12-22 Thread Tom Lane
Fix UNION/INTERSECT/EXCEPT over no columns. Since 9.4, we've allowed the syntax "select union select" and variants of that. However, the planner wasn't expecting a no-column set operation and ended up treating the set operation as if it were UNION ALL. Turns out it's trivial to fix in v10 and la

pgsql: Disallow UNION/INTERSECT/EXCEPT over no columns.

2017-12-22 Thread Tom Lane
Disallow UNION/INTERSECT/EXCEPT over no columns. Since 9.4, we've allowed the syntax "select union select" and variants of that. However, the planner wasn't expecting a no-column set operation and ended up treating the set operation as if it were UNION ALL. Pre-v10, there seem to be some executo

pgsql: Fix UNION/INTERSECT/EXCEPT over no columns.

2017-12-22 Thread Tom Lane
Fix UNION/INTERSECT/EXCEPT over no columns. Since 9.4, we've allowed the syntax "select union select" and variants of that. However, the planner wasn't expecting a no-column set operation and ended up treating the set operation as if it were UNION ALL. Turns out it's trivial to fix in v10 and la

Re: pgsql: Use new overflow aware integer operations.

2017-12-22 Thread Tom Lane
Andres Freund writes: > Use new overflow aware integer operations. I just tried to compile manually on prairiedog for the first time since this went in, and noticed that it now produces a boatload of warnings like int.c: In function 'int2pl': int.c:735: warning: 'result' may be used uninitialize

pgsql: Add optional compression method to SP-GiST

2017-12-22 Thread Teodor Sigaev
Add optional compression method to SP-GiST Patch allows to have different types of column and value stored in leaf tuples of SP-GiST. The main application of feature is to transform complex column type to simple indexed type or for truncating too long value, transformation could be lossy. Simple

Re: pgsql: Add parallel-aware hash joins.

2017-12-22 Thread Andres Freund
Hi, On 2017-12-22 21:16:10 +1300, Thomas Munro wrote: > Andres, your machine francolin crashed -- got a core file? Unfortunately not - it appears the buildfarm cleared it away :( Might try to reproduce it on that machine... Greetings, Andres Freund

Re: pgsql: Add parallel-aware hash joins.

2017-12-22 Thread Thomas Munro
On Fri, Dec 22, 2017 at 1:48 AM, Thomas Munro wrote: > I don't think that's quite it, because it should never have set > 'writing' for any batch number >= nbatch. > > It's late here, but I'll take this up tomorrow and either find a fix > or figure out how to avoid antisocial noise levels on the bu