Re: pgsql: Add parallel-aware hash joins.

2017-12-27 Thread Tom Lane
Thomas Munro writes: > On Thu, Dec 28, 2017 at 3:32 PM, Tom Lane wrote: >> Aside from the instability problems, I'm pretty unhappy about how much >> the PHJ patch has added to the runtime of "make check". I do not think >> any one feature can justify adding 20% to that. Can't you cut down the >

Re: pgsql: Add parallel-aware hash joins.

2017-12-27 Thread Thomas Munro
On Thu, Dec 28, 2017 at 3:32 PM, Tom Lane wrote: > Thomas Munro writes: >> I'll address the instability of the regression test output separately. > > If you're still looking for data on that --- prairiedog is able to > reproduce the "multibatch = f" variant about one time in thirty. > I modified

Re: pgsql: Add parallel-aware hash joins.

2017-12-27 Thread Tom Lane
Thomas Munro writes: > I'll address the instability of the regression test output separately. If you're still looking for data on that --- prairiedog is able to reproduce the "multibatch = f" variant about one time in thirty. I modified the test case to print out the full EXPLAIN ANALYZE output r

Re: pgsql: Use new overflow aware integer operations.

2017-12-27 Thread Tom Lane
[ back from Christmas break ] Andres Freund writes: > On December 22, 2017 7:52:54 PM GMT+01:00, Tom Lane > wrote: >> I will not accept an implementation that spews compiler warnings >> all over the place, which is what this one is doing. Please fix that, >> or else I will. > Are you seriousl

pgsql: Protect against hypothetical memory leaks in RelationGetPartitio

2017-12-27 Thread Alvaro Herrera
Protect against hypothetical memory leaks in RelationGetPartitionKey Also, fix a comment that commit 8a0596cb656e made obsolete. Reported-by: Robert Haas Discussion: http://postgr.es/m/ca+tgmoybpp2ghynwwm0qkah39spiu7uoinxlz20asfk...@mail.gmail.com Branch -- master Details --- https

pgsql: Remove incorrect apostrophe.

2017-12-27 Thread Robert Haas
Remove incorrect apostrophe. Etsuro Fujita Discussion: http://postgr.es/m/5a4393aa.8000...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b726eaa37a59d0cae0be56457c9522db7288255d Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 2

pgsql: Fix race-under-concurrency in PathNameCreateTemporaryDir.

2017-12-27 Thread Robert Haas
Fix race-under-concurrency in PathNameCreateTemporaryDir. Thomas Munro Discussion: http://postgr.es/m/CAEepm=1vp1e3ktftltw4b60zv9teneku6hxoaabptqmsrwj...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/62d02f39e72a2c030711a772f00f47f51262803c Modif

pgsql: Add pow(), aka power(), function to pgbench.

2017-12-27 Thread Robert Haas
Add pow(), aka power(), function to pgbench. Raúl Marín Rodríguez, reviewed by Fabien Coelho and Michael Paquier, with a minor fix by me. Discussion: http://postgr.es/m/cam6_um4xia14y9hndqu9kaaotwmhhzxw--q_zaczw9hsrsf...@mail.gmail.com Branch -- master Details --- https://git.postgresq

pgsql: Update relation's stats in pg_class during vacuum full.

2017-12-27 Thread Teodor Sigaev
Update relation's stats in pg_class during vacuum full. Hash index depends on estimation of numbers of tuples and pages of relations, incorrect value could be a reason of significantly growing of index. Vacuum full recreates heap and reindex all indexes before renewal stats. The patch fixes that,

pgsql: Update relation's stats in pg_class during vacuum full.

2017-12-27 Thread Teodor Sigaev
Update relation's stats in pg_class during vacuum full. Hash index depends on estimation of numbers of tuples and pages of relations, incorrect value could be a reason of significantly growing of index. Vacuum full recreates heap and reindex all indexes before renewal stats. The patch fixes that,