Re: pgsql: Add parallel-aware hash joins.

2017-12-30 Thread Tom Lane
Thomas Munro writes: > On Sun, Dec 31, 2017 at 11:34 AM, Tom Lane wrote: >> ... This isn't quite 100% reproducible on gaur/pademelon, >> but it fails more often than not seems like, so I can poke into it >> if you can say what info would be helpful. > Right. That's apparently unrelated and is t

Re: pgsql: Add parallel-aware hash joins.

2017-12-30 Thread Thomas Munro
On Sun, Dec 31, 2017 at 11:34 AM, Tom Lane wrote: > Thomas Munro writes: >> You mentioned that prairiedog sees the problem about one time in >> thirty. Would you mind checking if it goes away with this patch >> applied? > > I've run 55 cycles of "make installcheck" without seeing a failure > wit

Re: pgsql: Add parallel-aware hash joins.

2017-12-30 Thread Tom Lane
Thomas Munro writes: >> This is explained by the early exit case in >> ExecParallelHashEnsureBatchAccessors(). With just the right timing, >> it finishes up not reporting the true nbatch number, and never calling >> ExecParallelHashUpdateSpacePeak(). > Hi Tom, > You mentioned that prairiedog se

Re: pgsql: Add parallel-aware hash joins.

2017-12-30 Thread Thomas Munro
On Sun, Dec 31, 2017 at 5:16 AM, Andres Freund wrote: >> In a race case, EXPLAIN ANALYZE could fail to display correct nbatch and size >> information. Refactor so that participants report only on batches they >> worked >> on rather than trying to report on all of them, and teach explain.c to >>

Re: pgsql: Add parallel-aware hash joins.

2017-12-30 Thread Andres Freund
Hi, On 2017-12-31 02:51:26 +1300, Thomas Munro wrote: > You mentioned that prairiedog sees the problem about one time in > thirty. Would you mind checking if it goes away with this patch > applied? > > -- > Thomas Munro > http://www.enterprisedb.com > From cbed027275039cc5debf8db89342a133a831c

Re: pgsql: Add parallel-aware hash joins.

2017-12-30 Thread Thomas Munro
On Fri, Dec 29, 2017 at 2:21 AM, Thomas Munro wrote: > On Thu, Dec 28, 2017 at 5:15 PM, Thomas Munro > wrote: >> On Thu, Dec 28, 2017 at 3:32 PM, Tom Lane wrote: >>> !Buckets: 1024 (originally 2048) Batches: 1 >>> (originally 1) Memory Usage: 0kB >>> ! Execution t