Re: pgsql: Add parallel-aware hash joins.

2018-01-22 Thread Tom Lane
I wrote: > Anyway, it looks like we should write off these longfin timings as > ambient noise :-( Here's a possibly more useful graph of regression test timings over the last year. I pulled this from the buildfarm database: it is the reported runtime for the "installcheck-C" step in each successf

pgsql: Move handling of database properties from pg_dumpall into pg_dum

2018-01-22 Thread Tom Lane
Move handling of database properties from pg_dumpall into pg_dump. This patch rearranges the division of labor between pg_dump and pg_dumpall so that pg_dump itself handles all properties attached to a single database. Notably, a database's ACL (GRANT/REVOKE status) and local GUC settings establi

pgsql: Reorder code in pg_dump to dump comments etc in a uniform order.

2018-01-22 Thread Tom Lane
Reorder code in pg_dump to dump comments etc in a uniform order. Most of the code in pg_dump dumps an object's comment, security label, and ACL auxiliary TOC entries, in that order, immediately after the object's main TOC entry, and at least dumpComment's API spec says this isn't optional. dumpDa

pgsql: PL/Python: Fix tests for older Python versions

2018-01-22 Thread Peter Eisentraut
PL/Python: Fix tests for older Python versions Commit 8561e4840c81f7e345be2df170839846814fa004 neglected to handle older Python versions that don't support the "with" statement. So write the tests in a way that older versions can handle as well. Branch -- master Details --- https://git.

pgsql: Make pg_dump's ACL, sec label, and comment entries reliably iden

2018-01-22 Thread Tom Lane
Make pg_dump's ACL, sec label, and comment entries reliably identifiable. _tocEntryRequired() expects that it can identify ACL, SECURITY LABEL, and COMMENT TOC entries that are for large objects by seeing whether the tag for them starts with "LARGE OBJECT ". While that works fine for actual large

pgsql: Make pg_dump's ACL, sec label, and comment entries reliably iden

2018-01-22 Thread Tom Lane
Make pg_dump's ACL, sec label, and comment entries reliably identifiable. _tocEntryRequired() expects that it can identify ACL, SECURITY LABEL, and COMMENT TOC entries that are for large objects by seeing whether the tag for them starts with "LARGE OBJECT ". While that works fine for actual large

pgsql: Make pg_dump's ACL, sec label, and comment entries reliably iden

2018-01-22 Thread Tom Lane
Make pg_dump's ACL, sec label, and comment entries reliably identifiable. _tocEntryRequired() expects that it can identify ACL, SECURITY LABEL, and COMMENT TOC entries that are for large objects by seeing whether the tag for them starts with "LARGE OBJECT ". While that works fine for actual large

pgsql: Make pg_dump's ACL, sec label, and comment entries reliably iden

2018-01-22 Thread Tom Lane
Make pg_dump's ACL, sec label, and comment entries reliably identifiable. _tocEntryRequired() expects that it can identify ACL, SECURITY LABEL, and COMMENT TOC entries that are for large objects by seeing whether the tag for them starts with "LARGE OBJECT ". While that works fine for actual large

pgsql: Make pg_dump's ACL, sec label, and comment entries reliably iden

2018-01-22 Thread Tom Lane
Make pg_dump's ACL, sec label, and comment entries reliably identifiable. _tocEntryRequired() expects that it can identify ACL, SECURITY LABEL, and COMMENT TOC entries that are for large objects by seeing whether the tag for them starts with "LARGE OBJECT ". While that works fine for actual large

pgsql: Make pg_dump's ACL, sec label, and comment entries reliably iden

2018-01-22 Thread Tom Lane
Make pg_dump's ACL, sec label, and comment entries reliably identifiable. _tocEntryRequired() expects that it can identify ACL, SECURITY LABEL, and COMMENT TOC entries that are for large objects by seeing whether the tag for them starts with "LARGE OBJECT ". While that works fine for actual large

Re: pgsql: Add parallel-aware hash joins.

2018-01-22 Thread Tom Lane
Thomas Munro writes: > On Mon, Jan 22, 2018 at 11:17 PM, Thomas Munro > wrote: >> It looks to me like longfin's average and >> variation increased half way between fa330f9a and 18042840, somewhere >> near Dec 7 to 9, when we went from ~40s +/- 1 to ~50s with several >> seconds' variation. Was th

pgsql: Transaction control in PL procedures

2018-01-22 Thread Peter Eisentraut
Transaction control in PL procedures In each of the supplied procedural languages (PL/pgSQL, PL/Perl, PL/Python, PL/Tcl), add language-specific commit and rollback functions/commands to control transactions in procedures in that language. Add similar underlying functions to SPI. Some additional

Re: pgsql: Add parallel-aware hash joins.

2018-01-22 Thread Thomas Munro
On Mon, Jan 22, 2018 at 11:17 PM, Thomas Munro wrote: > It looks to me like longfin's average and > variation increased half way between fa330f9a and 18042840, somewhere > near Dec 7 to 9, when we went from ~40s +/- 1 to ~50s with several > seconds' variation. Was there some other environmental c

Re: pgsql: Add parallel-aware hash joins.

2018-01-22 Thread Thomas Munro
On Thu, Dec 28, 2017 at 5:26 PM, Tom Lane wrote: > Thomas Munro writes: >> On Thu, Dec 28, 2017 at 3:32 PM, Tom Lane wrote: >>> Aside from the instability problems, I'm pretty unhappy about how much >>> the PHJ patch has added to the runtime of "make check". I do not think >>> any one feature c

pgsql: Fix docs typo

2018-01-22 Thread Magnus Hagander
Fix docs typo Spotted by Thomas Munro Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b9ff79b8f17697f3df492017d454caa9920a7183 Modified Files -- doc/src/sgml/config.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)