pgsql: Refactor client-side SSL certificate checking code

2018-01-30 Thread Peter Eisentraut
Refactor client-side SSL certificate checking code Separate the parts specific to the SSL library from the general logic. The previous code structure was open_client_SSL() calls verify_peer_name_matches_certificate() calls verify_peer_name_matches_certificate_name() calls wildcard_certificate_ma

pgsql: Exclude common/int128.h from cpluspluscheck

2018-01-30 Thread Peter Eisentraut
Exclude common/int128.h from cpluspluscheck It uses static assertions, which are not supported under C++ in this branch. This change only goes into the 9.4 branch, because 9.5 and beyond will primarily use the USE_NATIVE_INT128 branch, so cpluspluscheck isn't bothered. In PG11 we will have C++ s

pgsql: Fix up references to scram-sha-256

2018-01-30 Thread Peter Eisentraut
Fix up references to scram-sha-256 pg_hba_file_rules erroneously reported this as scram-sha256. Fix that. To avoid future errors and confusion, also adjust documentation links and internal symbols to have a separator between "sha" and "256". Reported-by: Christophe Courtois Author: Michael Paq

pgsql: Fix up references to scram-sha-256

2018-01-30 Thread Peter Eisentraut
Fix up references to scram-sha-256 pg_hba_file_rules erroneously reported this as scram-sha256. Fix that. To avoid future errors and confusion, also adjust documentation links and internal symbols to have a separator between "sha" and "256". Reported-by: Christophe Courtois Author: Michael Paq

pgsql: Fix test case for 'outer pathkeys do not match mergeclauses' fix

2018-01-30 Thread Robert Haas
Fix test case for 'outer pathkeys do not match mergeclauses' fix. Commit 4bbf6edfbd5d03743ff82dda2f00c738fb3208f5 added a test case, but it turns out that the test case doesn't reliably test for the bug, and in the context of the regression test suite did not because ANALYZE had not been run. Rep

pgsql: Fix test case for 'outer pathkeys do not match mergeclauses' fix

2018-01-30 Thread Robert Haas
Fix test case for 'outer pathkeys do not match mergeclauses' fix. Commit 4bbf6edfbd5d03743ff82dda2f00c738fb3208f5 added a test case, but it turns out that the test case doesn't reliably test for the bug, and in the context of the regression test suite did not because ANALYZE had not been run. Rep

pgsql: Fix test case for 'outer pathkeys do not match mergeclauses' fix

2018-01-30 Thread Robert Haas
Fix test case for 'outer pathkeys do not match mergeclauses' fix. Commit 4bbf6edfbd5d03743ff82dda2f00c738fb3208f5 added a test case, but it turns out that the test case doesn't reliably test for the bug, and in the context of the regression test suite did not because ANALYZE had not been run. Rep