pgsql: Remove redundant IndexTupleDSize macro.

2018-02-28 Thread Tom Lane
Remove redundant IndexTupleDSize macro. Use IndexTupleSize everywhere, instead. Also, remove IndexTupleSize's internal typecast, as that's not really needed and might mask coding errors. Change some pointer variable datatypes in the call sites to compensate for that and make it clearer what we'r

pgsql: Doc: remove duplicate poly_ops row from SP-GiST opclass table.

2018-02-28 Thread Tom Lane
Doc: remove duplicate poly_ops row from SP-GiST opclass table. Commit ff963b393 added two identical copies of this row. Dagfinn Ilmari MannsÃ¥ker Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d3b8

pgsql: Rename base64 routines to avoid conflict with Solaris built-in f

2018-02-28 Thread Tom Lane
Rename base64 routines to avoid conflict with Solaris built-in functions. Solaris 11.4 has built-in functions named b64_encode and b64_decode. Rename ours to something else to avoid the conflict (fortunately, ours are static so the impact is limited). One could wish for less duplication of code i

pgsql: Rename base64 routines to avoid conflict with Solaris built-in f

2018-02-28 Thread Tom Lane
Rename base64 routines to avoid conflict with Solaris built-in functions. Solaris 11.4 has built-in functions named b64_encode and b64_decode. Rename ours to something else to avoid the conflict (fortunately, ours are static so the impact is limited). One could wish for less duplication of code i

pgsql: Rename base64 routines to avoid conflict with Solaris built-in f

2018-02-28 Thread Tom Lane
Rename base64 routines to avoid conflict with Solaris built-in functions. Solaris 11.4 has built-in functions named b64_encode and b64_decode. Rename ours to something else to avoid the conflict (fortunately, ours are static so the impact is limited). One could wish for less duplication of code i

pgsql: Rename base64 routines to avoid conflict with Solaris built-in f

2018-02-28 Thread Tom Lane
Rename base64 routines to avoid conflict with Solaris built-in functions. Solaris 11.4 has built-in functions named b64_encode and b64_decode. Rename ours to something else to avoid the conflict (fortunately, ours are static so the impact is limited). One could wish for less duplication of code i

pgsql: Rename base64 routines to avoid conflict with Solaris built-in f

2018-02-28 Thread Tom Lane
Rename base64 routines to avoid conflict with Solaris built-in functions. Solaris 11.4 has built-in functions named b64_encode and b64_decode. Rename ours to something else to avoid the conflict (fortunately, ours are static so the impact is limited). One could wish for less duplication of code i

pgsql: Rename base64 routines to avoid conflict with Solaris built-in f

2018-02-28 Thread Tom Lane
Rename base64 routines to avoid conflict with Solaris built-in functions. Solaris 11.4 has built-in functions named b64_encode and b64_decode. Rename ours to something else to avoid the conflict (fortunately, ours are static so the impact is limited). One could wish for less duplication of code i

pgsql: Remove restriction on SQL block length in isolationtester scanne

2018-02-28 Thread Tom Lane
Remove restriction on SQL block length in isolationtester scanner. specscanner.l had a fixed limit of 1024 bytes on the length of individual SQL stanzas in an isolation test script. People are starting to run into that, so fix it by making the buffer resizable. Once we allow this in HEAD, it see

pgsql: Remove restriction on SQL block length in isolationtester scanne

2018-02-28 Thread Tom Lane
Remove restriction on SQL block length in isolationtester scanner. specscanner.l had a fixed limit of 1024 bytes on the length of individual SQL stanzas in an isolation test script. People are starting to run into that, so fix it by making the buffer resizable. Once we allow this in HEAD, it see

pgsql: Remove restriction on SQL block length in isolationtester scanne

2018-02-28 Thread Tom Lane
Remove restriction on SQL block length in isolationtester scanner. specscanner.l had a fixed limit of 1024 bytes on the length of individual SQL stanzas in an isolation test script. People are starting to run into that, so fix it by making the buffer resizable. Once we allow this in HEAD, it see

pgsql: Remove restriction on SQL block length in isolationtester scanne

2018-02-28 Thread Tom Lane
Remove restriction on SQL block length in isolationtester scanner. specscanner.l had a fixed limit of 1024 bytes on the length of individual SQL stanzas in an isolation test script. People are starting to run into that, so fix it by making the buffer resizable. Once we allow this in HEAD, it see

pgsql: Remove restriction on SQL block length in isolationtester scanne

2018-02-28 Thread Tom Lane
Remove restriction on SQL block length in isolationtester scanner. specscanner.l had a fixed limit of 1024 bytes on the length of individual SQL stanzas in an isolation test script. People are starting to run into that, so fix it by making the buffer resizable. Once we allow this in HEAD, it see

pgsql: Remove restriction on SQL block length in isolationtester scanne

2018-02-28 Thread Tom Lane
Remove restriction on SQL block length in isolationtester scanner. specscanner.l had a fixed limit of 1024 bytes on the length of individual SQL stanzas in an isolation test script. People are starting to run into that, so fix it by making the buffer resizable. Once we allow this in HEAD, it see

Re: pgsql: Un-break parallel pg_upgrade.

2018-02-28 Thread Catalin Iacob
On Sun, Feb 25, 2018 at 11:27 PM, Tom Lane wrote: > Un-break parallel pg_upgrade. > This is the cause of the intermittent failures buildfarm member jacana > has been showing for the last month; evidently it is the only BF member > configured to run the pg_upgrade test with parallelism enabled. Se

pgsql: For partitionwise join, match on partcollation, not parttypcoll.

2018-02-28 Thread Robert Haas
For partitionwise join, match on partcollation, not parttypcoll. The previous code considered two tables to have the partition scheme if the underlying columns had the same collation, but what we actually need to compare is not the collations associated with the column but the collation used for p

pgsql: Document LWTRANCHE_PARALLEL_HASH_JOIN.

2018-02-28 Thread Robert Haas
Document LWTRANCHE_PARALLEL_HASH_JOIN. Thomas Munro Discussion: http://postgr.es/m/CAEepm=3g1hhbfzykr_qt9rmbvsgx4uaectx-4js8ooemmfe...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/73797b7884ee1722127f27ecfcede99367139dc0 Modified Files -

pgsql: Fix assertion failure when Parallel Append is run serially.

2018-02-28 Thread Robert Haas
Fix assertion failure when Parallel Append is run serially. Parallel-aware plan nodes must be prepared to run without parallelism if it's not possible at execution time for whatever reason. Commit ab72716778128fb63d54ac256adf7fe6820a1185, which introduced Parallel Append, overlooked this. Rajkum

pgsql: postgres_fdw: Third attempt to stabilize regression tests.

2018-02-28 Thread Robert Haas
postgres_fdw: Third attempt to stabilize regression tests. Commit 1bc0100d270e5bcc980a0629b8726a32a497e788 added this test, and commit 882ea509fe7a4711fe25463427a33262b873dfa1 tried to stabilize it. There were still failures, so commit 958e20e42d6c346ab89f6c72e4262230161d1663 tried again to stabi

pgsql: Update and improve comments.

2018-02-28 Thread Robert Haas
Update and improve comments. Commits 6f6b99d1335be8ea1b74581fc489a97b109dd08a and f3b0897a1213f46b4d3a99a7f8ef3a4b32e03572 didn't properly update these comments. Etsuro Fujita, reviewed by Amit Langote Discussion: http://postgr.es/m/[email protected] Branch -- master Details -

pgsql: doc: Improve man build speed

2018-02-28 Thread Peter Eisentraut
doc: Improve man build speed Turn off man.endnotes.are.numbered parameter, which we don't need, but which increases performance vastly if off. Also turn on man.output.quietly, which also makes things a bit faster, but which is also less useful now as a progress indicator because the build is so f

pgsql: Fix warnings in man page build

2018-02-28 Thread Peter Eisentraut
Fix warnings in man page build The changes in the CREATE POLICY man page from commit 87c2a17fee784c7e1004ba3d3c5d8147da676783 triggered a stylesheet bug that created some warning messages and incorrect output. This installs a workaround. Also improve the whitespace a bit so it looks better. Bra