pgsql: Fix assorted issues in convert_to_scalar().

2018-03-03 Thread Tom Lane
Fix assorted issues in convert_to_scalar(). If convert_to_scalar is passed a pair of datatypes it can't cope with, its former behavior was just to elog(ERROR). While this is OK so far as the core code is concerned, there's extension code that would like to use scalarltsel/scalargtsel/etc as selec

pgsql: Fix assorted issues in convert_to_scalar().

2018-03-03 Thread Tom Lane
Fix assorted issues in convert_to_scalar(). If convert_to_scalar is passed a pair of datatypes it can't cope with, its former behavior was just to elog(ERROR). While this is OK so far as the core code is concerned, there's extension code that would like to use scalarltsel/scalargtsel/etc as selec

pgsql: Fix assorted issues in convert_to_scalar().

2018-03-03 Thread Tom Lane
Fix assorted issues in convert_to_scalar(). If convert_to_scalar is passed a pair of datatypes it can't cope with, its former behavior was just to elog(ERROR). While this is OK so far as the core code is concerned, there's extension code that would like to use scalarltsel/scalargtsel/etc as selec

pgsql: Fix assorted issues in convert_to_scalar().

2018-03-03 Thread Tom Lane
Fix assorted issues in convert_to_scalar(). If convert_to_scalar is passed a pair of datatypes it can't cope with, its former behavior was just to elog(ERROR). While this is OK so far as the core code is concerned, there's extension code that would like to use scalarltsel/scalargtsel/etc as selec

pgsql: Fix assorted issues in convert_to_scalar().

2018-03-03 Thread Tom Lane
Fix assorted issues in convert_to_scalar(). If convert_to_scalar is passed a pair of datatypes it can't cope with, its former behavior was just to elog(ERROR). While this is OK so far as the core code is concerned, there's extension code that would like to use scalarltsel/scalargtsel/etc as selec

pgsql: Fix assorted issues in convert_to_scalar().

2018-03-03 Thread Tom Lane
Fix assorted issues in convert_to_scalar(). If convert_to_scalar is passed a pair of datatypes it can't cope with, its former behavior was just to elog(ERROR). While this is OK so far as the core code is concerned, there's extension code that would like to use scalarltsel/scalargtsel/etc as selec

pgsql: doc: Small wording improvement

2018-03-03 Thread Peter Eisentraut
doc: Small wording improvement Replace "checkpoint segment" with "WAL segment". Reported-by: Maksim Milyutin Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7726147f5368e04d0b7c1ab1849a6be47391ff24 Modified Files -- doc/src/sgml/config.sgml | 2 +- 1 f

pgsql: doc: Fix links to pg_stat_replication

2018-03-03 Thread Peter Eisentraut
doc: Fix links to pg_stat_replication In PostgreSQL 9.5, the documentation for pg_stat_replication was moved, so some of the links pointed to an appropriate location. Author: Maksim Milyutin Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/79300d09fc4c61945c

pgsql: doc: Fix links to pg_stat_replication

2018-03-03 Thread Peter Eisentraut
doc: Fix links to pg_stat_replication In PostgreSQL 9.5, the documentation for pg_stat_replication was moved, so some of the links pointed to an appropriate location. Author: Maksim Milyutin Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/965a6a3369ce014b41

pgsql: doc: Fix links to pg_stat_replication

2018-03-03 Thread Peter Eisentraut
doc: Fix links to pg_stat_replication In PostgreSQL 9.5, the documentation for pg_stat_replication was moved, so some of the links pointed to an appropriate location. Author: Maksim Milyutin Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4346794abfb55a3b5c

pgsql: doc: Fix links to pg_stat_replication

2018-03-03 Thread Peter Eisentraut
doc: Fix links to pg_stat_replication In PostgreSQL 9.5, the documentation for pg_stat_replication was moved, so some of the links pointed to an appropriate location. Author: Maksim Milyutin Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e568eed2fce7c50f40e0dcdec

pgsql: Minor fixes for reloptions tests

2018-03-03 Thread Peter Eisentraut
Minor fixes for reloptions tests Follow-up to 4b95cc1dc36c9d1971f757e9b519fcc442833f0e Author: Nikolay Shaplov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/39314efa4dd9101c18ef37067c3e114968a600a4 Modified Files -- src/test/regress/expected/relopti

pgsql: Trivial adjustments in preparation for bootstrap data conversion

2018-03-03 Thread Tom Lane
Trivial adjustments in preparation for bootstrap data conversion. Rationalize a couple of macro names: * In catalog/pg_init_privs.h, rename Anum_pg_init_privs_privs to Anum_pg_init_privs_initprivs to match the column's actual name. * In ecpg, rename ZPBITOID to BITOID to match catalog/pg_type.h.

pgsql: Minor cleanup in genbki.pl.

2018-03-03 Thread Tom Lane
Minor cleanup in genbki.pl. Separate out the pg_attribute logic of genbki.pl into its own function. Drop unnecessary "defined $catalog->{data}" check. This both narrows and shortens the data writing loop of the script. There is no functional change (the emitted files are the same as before). Jo

pgsql: doc: Improve wording

2018-03-03 Thread Peter Eisentraut
doc: Improve wording Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/506652bcaea74a23d6f0a33923a7f558126b472d Modified Files -- doc/src/sgml/bgworker.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: In SSL tests, restart after pg_hba.conf changes

2018-03-03 Thread Peter Eisentraut
In SSL tests, restart after pg_hba.conf changes This prevents silently using a wrong configuration, similar to b4e2ada347bd8ae941171bd0761462e5b11b765d. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f96f48113f97a45fe95d016e7b1afef4953616f0 Modified Files

pgsql: Prevent LDAP and SSL tests from running without support in build

2018-03-03 Thread Peter Eisentraut
Prevent LDAP and SSL tests from running without support in build Add checks in each test file that the build supports the feature, otherwise skip all the tests. Before, if someone were to (accidentally) invoke these tests without build support, they would fail in confusing ways. based on patch f

Re: pgsql: Fix msvc builds for ActivePerl > 5.24

2018-03-03 Thread Noah Misch
On Fri, Mar 02, 2018 at 11:42:32AM +, Magnus Hagander wrote: > Fix msvc builds for ActivePerl > 5.24 > --- a/src/tools/msvc/Mkvcbuild.pm > +++ b/src/tools/msvc/Mkvcbuild.pm > @@ -524,9 +524,11 @@ sub mkvcbuild > my $perl_path = $solution->{options}->{perl} . > '\lib\CORE\*perl*'