Re: pgsql: Allow FOR EACH ROW triggers on partitioned tables

2018-03-24 Thread Andres Freund
Hi, On 2018-03-23 13:48:53 +, Alvaro Herrera wrote: > Allow FOR EACH ROW triggers on partitioned tables > > Previously, FOR EACH ROW triggers were not allowed in partitioned > tables. Now we allow AFTER triggers on them, and on trigger creation we > cascade to create an identical trigger in

Re: pgsql: Add long options to pg_resetwal and pg_controldata

2018-03-24 Thread Tom Lane
Andres Freund writes: > Windows doesn't like this, I suspect you need to include getopt_long.h Not just Windows. I went ahead and pushed this so I could resume testing on gaur/pademelon. regards, tom lane

pgsql: Add #includes missed in commit e22b27f0cb3ee03ee300d431997f5944c

2018-03-24 Thread Tom Lane
Add #includes missed in commit e22b27f0cb3ee03ee300d431997f5944ccf2d7b3. Leaving out getopt_long.h works on some platforms, but not all. Per buildfarm. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.

pgsql: Stabilize regression test result.

2018-03-24 Thread Tom Lane
Stabilize regression test result. If random() returns a result sufficiently close to zero, float8out switches to scientific notation, breaking this test case's expectation that the output should look like '0.x'. Casting to numeric should fix that. Per buildfarm member pogona. Discussion

pgsql: Mop-up for commit feb8254518752b2cb4a8964c374dd82d49ef0e0d.

2018-03-24 Thread Tom Lane
Mop-up for commit feb8254518752b2cb4a8964c374dd82d49ef0e0d. Missed these occurrences of some of the adjusted error messages. Per buildfarm member pademelon. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/da616950cee395919f835b5cbec3d23c4844015a Modified Files

Re: pgsql: Add long options to pg_resetwal and pg_controldata

2018-03-24 Thread Andres Freund
On 2018-03-25 01:53:06 +, Peter Eisentraut wrote: > Add long options to pg_resetwal and pg_controldata > > We were running out of good single-letter options for some upcoming > pg_resetwal functionality, so add long options to create more > possibilities. Add to pg_controldata as well for sym

Re: pgsql: Avoid premature free of pass-by-reference CALL arguments.

2018-03-24 Thread Tom Lane
Andres Freund writes: > On 2018-02-10 18:37:17 +, Tom Lane wrote: > CALL ptest1(substring(random()::text, 1, 1)); -- ok, volatile arg > At first I was gosh darned confused, this really didn't seem likely to > be an LLVM induced failure. And it turns out it isn't. If the value > returned by

pgsql: Add long options to pg_resetwal and pg_controldata

2018-03-24 Thread Peter Eisentraut
Add long options to pg_resetwal and pg_controldata We were running out of good single-letter options for some upcoming pg_resetwal functionality, so add long options to create more possibilities. Add to pg_controldata as well for symmetry. based on patch by Bossart, Nathan Branch -- master

Re: pgsql: Avoid premature free of pass-by-reference CALL arguments.

2018-03-24 Thread Andres Freund
On 2018-02-10 18:37:17 +, Tom Lane wrote: > Avoid premature free of pass-by-reference CALL arguments. > src/test/regress/expected/create_procedure.out | 12 +++ > src/test/regress/sql/create_procedure.sql | 4 +++- > 3 files changed, 33 insertions(+), 11 deletions(-) There's a re

pgsql: initdb: Improve --wal-segsize handling

2018-03-24 Thread Peter Eisentraut
initdb: Improve --wal-segsize handling Give separate error messages for when the argument is not a number and when it is not the right kind of number. Fix wording in the help message. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/496d56670af44a2a578c15195c36f797e

pgsql: Improve pg_resetwal documentation

2018-03-24 Thread Peter Eisentraut
Improve pg_resetwal documentation Clarify that the -l option takes a file name, not an "address", and that that might be different from the LSN if nondefault WAL segment sizes are used. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4644a1170f0ad88f92d2835f589fffb6