Re: pgsql: Rewrite the code that applies scan/join targets to paths.

2018-03-29 Thread Andres Freund
On 2018-03-29 19:52:40 +, Robert Haas wrote: > Rewrite the code that applies scan/join targets to paths. > > If the toplevel scan/join target list is parallel-safe, postpone > generating Gather (or Gather Merge) paths until after the toplevel has > been adjusted to return it. This

pgsql: docs: fix spacing around "if not exists" brackets

2018-03-29 Thread Bruce Momjian
docs: fix spacing around "if not exists" brackets Reported-by: Fabrízio de Royes Mello Discussion: https://postgr.es/m/cafcns+qdd+qkcf8ycpqnjaxown61qy_ydflb3iqqbwclscy...@mail.gmail.com Author: Fabrízio de Royes Mello Branch -- master Details ---

pgsql: Allow to lock views.

2018-03-29 Thread Tatsuo Ishii
Allow to lock views. Now all tables used in view definitions can be recursively locked by a LOCK command. Author: Yugo Nagata Reviewed by Robert Haas, Thomas Munro and me. Discussion: https://postgr.es/m/20171011183629.eb2817b3.nagata%40sraoss.co.jp Branch -- master Details ---

pgsql: Improve JIT docs.

2018-03-29 Thread Andres Freund
Improve JIT docs. Author: John Naylor and Andres Freund Discussion: https://postgr.es/m/cajvsvgus-vcwsy7-kx-gqe__8hvwua4uhyf3gxomxeizqeb...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fb604780114cea6a83f3f6a60e7f51a7185c932b Modified Files

pgsql: Remove 'target' from GroupPathExtraData.

2018-03-29 Thread Robert Haas
Remove 'target' from GroupPathExtraData. It's not needed. Jeevan Chalke Discussion: http://postgr.es/m/CAM2+6=xpwujjmj5zuabtgdob38cemwcpmjkry0qocsqj_v+...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c1de1a3a8b93a61e8264484a10a482156026d12c

pgsql: Rewrite the code that applies scan/join targets to paths.

2018-03-29 Thread Robert Haas
Rewrite the code that applies scan/join targets to paths. If the toplevel scan/join target list is parallel-safe, postpone generating Gather (or Gather Merge) paths until after the toplevel has been adjusted to return it. This (correctly) makes queries with expensive functions in the target list

pgsql: Postpone generate_gather_paths for topmost scan/join rel.

2018-03-29 Thread Robert Haas
Postpone generate_gather_paths for topmost scan/join rel. Don't call generate_gather_paths for the topmost scan/join relation when it is initially populated with paths. Instead, do the work in grouping_planner. By itself, this gains nothing; in fact it loses slightly because we end up calling

pgsql: C comments: "a" <--> "an" corrections

2018-03-29 Thread Bruce Momjian
C comments: "a" <--> "an" corrections Reported-by: Michael Paquier, Abhijit Menon-Sen Discussion: https://postgr.es/m/20180305045854.gb2...@paquier.xyz Author: Michael Paquier, Abhijit Menon-Sen, me Branch -- master Details ---

Re: pgsql: Add documentation for the JIT feature.

2018-03-29 Thread Alvaro Herrera
Andres Freund wrote: > Hi, > > On 2018-03-29 15:20:58 -0300, Alvaro Herrera wrote: > > Andres Freund wrote: > > > > > Could we add INSTALL to the all target in src/docs/sgml? It's a bit > > > awkward that one can build the docs and miss such a mistake. It's fast > > > to build in comparison to

pgsql: README change: update for hash access method

2018-03-29 Thread Bruce Momjian
README change: update for hash access method Reported-by: Thomas Munro, Justin Pryzby Discussion: https://postgr.es/m/CAEepm=1_682z-09dnhj4gkcjaqwk-d6h9oq5ea84t1oqq1-...@mail.gmail.com Branch -- master Details ---

Re: pgsql: Add documentation for the JIT feature.

2018-03-29 Thread Andres Freund
Hi, On 2018-03-29 15:20:58 -0300, Alvaro Herrera wrote: > Andres Freund wrote: > > > Could we add INSTALL to the all target in src/docs/sgml? It's a bit > > awkward that one can build the docs and miss such a mistake. It's fast > > to build in comparison to the rest of the docs, so that doesn't

Re: pgsql: Add documentation for the JIT feature.

2018-03-29 Thread Alvaro Herrera
Andres Freund wrote: > Could we add INSTALL to the all target in src/docs/sgml? It's a bit > awkward that one can build the docs and miss such a mistake. It's fast > to build in comparison to the rest of the docs, so that doesn't seem > like a high price? Maybe it can be tested for in "make

pgsql: Fix incorrect copy/paste in comment

2018-03-29 Thread Magnus Hagander
Fix incorrect copy/paste in comment Author: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8cdc834647b8b1558c10a7d27a3580a32e04c500 Modified Files -- src/test/subscription/t/003_constraints.pl | 2 +- 1

pgsql: Fix typo in comment

2018-03-29 Thread Magnus Hagander
Fix typo in comment Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9778d5c180c06998c315a4ae4753b927e3bc4ea8 Modified Files -- src/bin/pg_dump/pg_backup_custom.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: pgsql: Add casts from jsonb

2018-03-29 Thread Tom Lane
Teodor Sigaev writes: > Hm, it was a random failure? Yeah, whelk seems to be a bit flaky lately. Not very clear why, but it's shown several failures that other BF members didn't. https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=whelk=HEAD Curiously, it's only HEAD

pgsql: Remove unnecessary BufferGetPage() calls in fsm_vacuum_page().

2018-03-29 Thread Tom Lane
Remove unnecessary BufferGetPage() calls in fsm_vacuum_page(). Just noticed that these were quite redundant, since we're holding the page address in a local variable anyway, and we have pin on the buffer throughout. Also improve a comment. Branch -- master Details ---

pgsql: Remove UpdateFreeSpaceMap(), use FreeSpaceMapVacuumRange() inste

2018-03-29 Thread Tom Lane
Remove UpdateFreeSpaceMap(), use FreeSpaceMapVacuumRange() instead. FreeSpaceMapVacuumRange has the same effect, is more efficient if many pages are involved, and makes fewer assumptions about how it's used. Notably, Claudio Freire pointed out that UpdateFreeSpaceMap could fail if the specified

pgsql: C comment: fix wording about shared memory message queue

2018-03-29 Thread Bruce Momjian
C comment: fix wording about shared memory message queue Reported-by: Tels Discussion: https://postgr.es/m/e66e05bc55f5ce904e361ad17a3395ae.squir...@sm.webmail.pair.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bc0021ef09ec709fa20309228ea30ccf07f8b4e6

Re: pgsql: Add casts from jsonb

2018-03-29 Thread Teodor Sigaev
Hm, it was a random failure? Teodor Sigaev wrote: Seems, I broke Windows again, it doesn't like this patch, see https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk=2018-03-29%2013%3A41%3A13 But I don't understand how it could be... Teodor Sigaev wrote: Add casts from jsonb Add

pgsql: While vacuuming a large table, update upper-level FSM data every

2018-03-29 Thread Tom Lane
While vacuuming a large table, update upper-level FSM data every so often. VACUUM updates leaf-level FSM entries immediately after cleaning the corresponding heap blocks. fsmpage.c updates the intra-page search trees on the leaf-level FSM pages when this happens, but it does not touch the

Re: pgsql: Optimize btree insertions for common case of increasing values

2018-03-29 Thread Simon Riggs
On 29 March 2018 at 00:09, Peter Geoghegan wrote: > On Wed, Mar 28, 2018 at 11:56 AM, Peter Geoghegan wrote: >>> Previously, we agreed that P_IGNORE() is required. So I assume no issues >>> there. The other tests seem required too for us to conclusively decide to >>>

Re: pgsql: Add casts from jsonb

2018-03-29 Thread Teodor Sigaev
Seems, I broke Windows again, it doesn't like this patch, see https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk=2018-03-29%2013%3A41%3A13 But I don't understand how it could be... Teodor Sigaev wrote: Add casts from jsonb Add explicit cast from scalar jsonb to all numeric and bool

pgsql: Add casts from jsonb

2018-03-29 Thread Teodor Sigaev
Add casts from jsonb Add explicit cast from scalar jsonb to all numeric and bool types. It would be better to have cast from scalar jsonb to text too but there is already a cast from jsonb to text as just text representation of json. There is no way to have two different casts for the same type's

pgsql: docs: fix INSTALL.xml build by using "standalone-ignore"

2018-03-29 Thread Bruce Momjian
docs: fix INSTALL.xml build by using "standalone-ignore" Was broken by "jit" link. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7fe04ce9203cb0c5332614ec091aab28cf6aeaa8 Modified Files -- doc/src/sgml/installation.sgml | 4 +++- 1 file changed, 3

pgsql: Fix typo in comment

2018-03-29 Thread Magnus Hagander
Fix typo in comment Arthur Zakirov, confirmed by Thomas Munro Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/669820a3d9c359e8d44a26035cb4d675dc542cb4 Modified Files -- src/backend/utils/cache/typcache.c | 2 +- 1 file changed, 1 insertion(+), 1