Re: pgsql: Modified files for MERGE

2018-04-02 Thread Pavan Deolasee
On Tue, Apr 3, 2018 at 2:06 AM, Andres Freund wrote: > > This seems to have turned several animals red: > - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm= > thrips&dt=2018-04-02%2020%3A27%3A28 > use of uint, which isn't a portable type. > Right. > - https://buildfarm.postgresql.org

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Peter Geoghegan
On Mon, Apr 2, 2018 at 1:59 PM, Simon Riggs wrote: > I diagnosed the causal issue as lack of sleep and will try again once > that is cured. I noticed in passing that the grammar description wasn't updated in merge.sgml after I added WITH clause support. I suppose I should have thought of that, bu

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Simon Riggs
On 2 April 2018 at 21:54, Andres Freund wrote: > Hi, > > On 2018-04-02 21:50:28 +0100, Simon Riggs wrote: >> I didn't think it mattered, but clearly does. Reverted before you >> asked. > > I don't think the BF failures were related to the split, though... I > personally think it's fair to take a c

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Andres Freund
Hi, On 2018-04-02 21:50:28 +0100, Simon Riggs wrote: > I didn't think it mattered, but clearly does. Reverted before you > asked. I don't think the BF failures were related to the split, though... I personally think it's fair to take a couple hours to attempt to mop-up post commit issues of a lar

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Simon Riggs
On 2 April 2018 at 21:36, Andres Freund wrote: > Hi, > > On 2018-04-02 20:13:41 +, Simon Riggs wrote: >> Modified files for MERGE > > This is a bit of a weird split. What's the reason behind it? Lack of tea, it appears. I didn't think it mattered, but clearly does. Reverted before you asked.

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Peter Geoghegan
On Mon, Apr 2, 2018 at 1:36 PM, Andres Freund wrote: > - > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=calliphoridae&dt=2018-04-02%2020%3A20%3A01 > looks like copy/read/out/equalfuncs aren't properly filled out A COPY_PARSE_PLAN_TREES run of the regression test seems like a good id

pgsql: doc: document "IS NOT DOCUMENT"

2018-04-02 Thread Bruce Momjian
doc: document "IS NOT DOCUMENT" Reported-by: scott@caseware.com Discussion: https://postgr.es/m/152056505045.4963.16783351661813640...@wrigleys.postgresql.org Author: Euler Taveira Backpatch-through: 9.3 Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: doc: document "IS NOT DOCUMENT"

2018-04-02 Thread Bruce Momjian
doc: document "IS NOT DOCUMENT" Reported-by: scott@caseware.com Discussion: https://postgr.es/m/152056505045.4963.16783351661813640...@wrigleys.postgresql.org Author: Euler Taveira Backpatch-through: 9.3 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: doc: document "IS NOT DOCUMENT"

2018-04-02 Thread Bruce Momjian
doc: document "IS NOT DOCUMENT" Reported-by: scott@caseware.com Discussion: https://postgr.es/m/152056505045.4963.16783351661813640...@wrigleys.postgresql.org Author: Euler Taveira Backpatch-through: 9.3 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: doc: document "IS NOT DOCUMENT"

2018-04-02 Thread Bruce Momjian
doc: document "IS NOT DOCUMENT" Reported-by: scott@caseware.com Discussion: https://postgr.es/m/152056505045.4963.16783351661813640...@wrigleys.postgresql.org Author: Euler Taveira Backpatch-through: 9.3 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Revert "MERGE SQL Command following SQL:2016"

2018-04-02 Thread Simon Riggs
Revert "MERGE SQL Command following SQL:2016" This reverts commit e6597dc3533946b98acba7871bd4ca1f7a3d4c1d. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aa5877bb26347c58a34aee4e460eb1e1123bb096 Modified Files -- doc/src/sgml/ref/merge.sgml

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Andres Freund
Hi, On 2018-04-02 20:13:41 +, Simon Riggs wrote: > Modified files for MERGE This is a bit of a weird split. What's the reason behind it? This seems to have turned several animals red: - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thrips&dt=2018-04-02%2020%3A27%3A28 use of uin

pgsql: Revert "Modified files for MERGE"

2018-04-02 Thread Simon Riggs
Revert "Modified files for MERGE" This reverts commit 354f13855e6381d288dfaa52bcd4f2cb0fd4a5eb. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7cf8a5c302735d193dcf901b87e03e324903c632 Modified Files -- contrib/test_decoding/expected/ddl.out| 46 --

pgsql: Modified files for MERGE

2018-04-02 Thread Simon Riggs
Modified files for MERGE Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/354f13855e6381d288dfaa52bcd4f2cb0fd4a5eb Modified Files -- contrib/test_decoding/expected/ddl.out| 46 contrib/test_decoding/sql/ddl.sql | 16 ++ doc/src/sgml/libpq

pgsql: MERGE SQL Command following SQL:2016

2018-04-02 Thread Simon Riggs
MERGE SQL Command following SQL:2016 MERGE performs actions that modify rows in the target table using a source table or query. MERGE provides a single SQL statement that can conditionally INSERT/UPDATE/DELETE rows a task that would other require multiple PL statements. e.g. MERGE INTO target AS

Re: pgsql: postgres_fdw: Push down partition-wise aggregation.

2018-04-02 Thread Robert Haas
On Mon, Apr 2, 2018 at 1:57 PM, Peter Eisentraut wrote: > On 4/2/18 13:49, Tom Lane wrote: >> Robert Haas writes: >>> postgres_fdw: Push down partition-wise aggregation. >> >> Seems to have broken the docs build. > > fixed Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The En

Re: pgsql: postgres_fdw: Push down partition-wise aggregation.

2018-04-02 Thread Peter Eisentraut
On 4/2/18 13:49, Tom Lane wrote: > Robert Haas writes: >> postgres_fdw: Push down partition-wise aggregation. > > Seems to have broken the docs build. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql: Fix XML syntax in documentation

2018-04-02 Thread Peter Eisentraut
Fix XML syntax in documentation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a92f24fc53a83ed6f3b2188bdc298f1c8a4a91ee Modified Files -- doc/src/sgml/fdwhandler.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: pgsql: postgres_fdw: Push down partition-wise aggregation.

2018-04-02 Thread Tom Lane
Robert Haas writes: > postgres_fdw: Push down partition-wise aggregation. Seems to have broken the docs build. regards, tom lane

pgsql: Fix some dubious WAL-parsing code.

2018-04-02 Thread Tom Lane
Fix some dubious WAL-parsing code. Coverity complained about possible buffer overrun in two places added by commit 1eb6d6527, and AFAICS it's reasonable to worry: even granting that the WAL originator properly truncated the commit GID to GIDSIZE, we should not really bet our lives on that having t

pgsql: psql: Fix \ef, \sf tab completion

2018-04-02 Thread Peter Eisentraut
psql: Fix \ef, \sf tab completion \ef and \sf take any kind of routine, not just normal functions. Author: Pavel Stehule Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05e85d35afb0a58080d6a1a0b582bf8a6471c7f1 Modified Files -- src/bin/psql/tab-comple

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Tom Lane
Peter Eisentraut writes: > On 4/1/18 18:07, Tom Lane wrote: >> 1. Just remove the tests involving inf/nan. As far as I can see, >> there's no explicit handling of these cases in jsonb_plpython, >> so we're not really buying any test coverage of our own code anyway. > That makes sense. OK, done.

pgsql: Remove contrib/jsonb_plpython's tests for infinity and NaN conve

2018-04-02 Thread Tom Lane
Remove contrib/jsonb_plpython's tests for infinity and NaN conversions. These tests don't work reliably with pre-2.6 Python versions, since Python code like float('inf') was not guaranteed to work before that, even granting an IEEE-compliant platform. Since there's no explicit handling of these c

pgsql: Teach configure --with-python to report the Python version numbe

2018-04-02 Thread Tom Lane
Teach configure --with-python to report the Python version number. We already do this for Perl and some other interesting tools, so it seems sensible to do it for Python as well, especially since the sub-release number is never determinable from other configure output and even the major/minor numb

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Peter Eisentraut
On 4/1/18 18:07, Tom Lane wrote: > 1. Just remove the tests involving inf/nan. As far as I can see, > there's no explicit handling of these cases in jsonb_plpython, > so we're not really buying any test coverage of our own code anyway. That makes sense. -- Peter Eisentraut http://w

pgsql: Make be-secure-common.c more consistent for future SSL implement

2018-04-02 Thread Peter Eisentraut
Make be-secure-common.c more consistent for future SSL implementations Recent commit 8a3d9425 has introduced be-secure-common.c, which is aimed at including backend-side APIs that can be used by any SSL implementation. The purpose is similar to fe-secure-common.c for the frontend-side APIs. Howe

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Devrim Gündüz
Hi, On Mon, 2018-04-02 at 10:59 -0400, Tom Lane wrote: > aholehole and arapaima are evidently using the platform-supplied version > on RHEL 5, and locust the platform-supplied version on macOS 10.5.8. Yeah, I'm running arapaima and aholehole, they have stock RHEL 5 packages (Python 2.4) > So wh

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Tom Lane
Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: > On Sun, 2018-04-01 at 18:07 -0400, Tom Lane wrote: >> 4. Move our minimum supported Python version up to 2.6 (from 2.4 >> where it is now). >> >> #4 seems like an overreaction at first sight, but on the other >> hand, I wonder how many people really ca

pgsql: postgres_fdw: Push down partition-wise aggregation.

2018-04-02 Thread Robert Haas
postgres_fdw: Push down partition-wise aggregation. Since commit 7012b132d07c2b4ea15b0b3cb1ea9f3278801d98, postgres_fdw has been able to push down the toplevel aggregation operation to the remote server. Commit e2f1eb0ee30d144628ab523432320f174a2c8966 made it possible to break down the toplevel a