pgsql: Correct pg_recvlogical server version test.

2018-04-25 Thread Noah Misch
Correct pg_recvlogical server version test. The predecessor test boiled down to "PQserverVersion(NULL) >= 10", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f274def85f3

pgsql: Correct pg_recvlogical server version test.

2018-04-25 Thread Noah Misch
Correct pg_recvlogical server version test. The predecessor test boiled down to "PQserverVersion(NULL) >= 10", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f274def85f3

pgsql: Correct pg_recvlogical server version test.

2018-04-25 Thread Noah Misch
Correct pg_recvlogical server version test. The predecessor test boiled down to "PQserverVersion(NULL) >= 10", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f274def85f3

pgsql: Correct pg_recvlogical server version test.

2018-04-25 Thread Noah Misch
Correct pg_recvlogical server version test. The predecessor test boiled down to "PQserverVersion(NULL) >= 10", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f274def85f3

pgsql: Correct pg_recvlogical server version test.

2018-04-25 Thread Noah Misch
Correct pg_recvlogical server version test. The predecessor test boiled down to "PQserverVersion(NULL) >= 10", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f274def85f3

pgsql: Make Catalog.pm's representation of toast and index decls more a

2018-04-25 Thread Tom Lane
Make Catalog.pm's representation of toast and index decls more abstract. Instead of immediately constructing the string we need to emit into the .BKI file, preserve the items we extracted from the header file in a hash. This eases using the info for other purposes. John Naylor (with cosmetic adju

pgsql: Convert unused_oids and duplicate_oids to use Catalog.pm infrast

2018-04-25 Thread Tom Lane
Convert unused_oids and duplicate_oids to use Catalog.pm infrastructure. unused_oids was previously a shell script, which of course didn't work at all on Windows. Also, commit 372728b0d introduced some other portability problems, as complained of by Stas Kelvich. We can improve matters by conver

pgsql: Prevent generation of bogus subquery scan paths.

2018-04-25 Thread Robert Haas
Prevent generation of bogus subquery scan paths. Commit 0927d2f46ddd4cf7d6bf2cc84b3be923e0aedc52 didn't check that consider_parallel was set for the target relation or account for the possibility that required_outer might be non-empty. To prevent future bugs of this ilk, add some assertions to ad

pgsql: Add amcheck missing downlink tests.

2018-04-25 Thread Teodor Sigaev
Add amcheck missing downlink tests. Also use palloc0() for main amcheck state, and adjust a few comments. Somehow I pushed old version of patch in commit 4eaf7eaccb291f5d32d9f05284bfca9c5744de9a, so commit the difference. Peter Geoghegan Branch -- master Details --- https://git.postgre

pgsql: Reindent Perl files with perltidy version 20170521.

2018-04-25 Thread Tom Lane
Reindent Perl files with perltidy version 20170521. Discussion: https://postgr.es/m/CABUevEzK3cNiHZQ18f5tK0guoT+cN_jWeVzhYYxY=r+1q3s...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f04d4ac919b9ae9b57e977523e4b40979aa8b951 Modified Files -

pgsql: Change pgindent/README to specify that we use perltidy version 2

2018-04-25 Thread Tom Lane
Change pgindent/README to specify that we use perltidy version 20170521. Per discussion, this is now the project's standard version. Update the obsolete URL, and explain how to install a specific version. Discussion: https://postgr.es/m/CABUevEzK3cNiHZQ18f5tK0guoT+cN_jWeVzhYYxY=r+1q3s...@mail.gm

pgsql: Add missing and dangling downlink checks to amcheck

2018-04-25 Thread Teodor Sigaev
Add missing and dangling downlink checks to amcheck When bt_index_parent_check() is called with the heapallindexed option, allocate a second Bloom filter to fingerprint block numbers that appear in the downlinks of internal pages. Use Bloom filter probes when walking the B-Tree to detect missing

pgsql: Fix typo

2018-04-25 Thread Magnus Hagander
Fix typo Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7f58f666cdeee8016fd4ec7aa79629c983ecc3bd Modified Files -- doc/src/sgml/jit.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)