On Tue, Jul 17, 2018 at 09:13:28PM -0400, Tom Lane wrote:
> Hm, I'd just tried this on my Mac laptop and saw only the one in
> walsender.c. No objection to the other two though, they might be
> relevant on other platforms.
longfin has turned back to green again, so at least this is fixed now.
--
Michael Paquier writes:
> This attempt made longfin happier for the path patched, but there were a
> couple of other ones which were hidden behind. I got them fixed now,
> which should bring the machine back to green.
Hm, I'd just tried this on my Mac laptop and saw only the one in
walsender.c.
On Wed, Jul 18, 2018 at 09:14:14AM +0900, Michael Paquier wrote:
> Thanks for double-checking, pushed.
This attempt made longfin happier for the path patched, but there were a
couple of other ones which were hidden behind. I got them fixed now,
which should bring the machine back to green.
--
Mic
Fix more portability issues with casts to Size when using off_t
This should tame the beast, as there are no other places where off_t is
used in the new error messages.
Reported again by longfin, which complained about walsender.c while I
spotted the other two ones while double-checking.
Branch
-
On Tue, Jul 17, 2018 at 08:02:43PM -0400, Tom Lane wrote:
> Sounds right to me.
Thanks for double-checking, pushed.
--
Michael
signature.asc
Description: PGP signature
Fix casting in error message for two-phase file
This error from from 811b6e3, which causes compilation warnings with OSX
10.3 and clang.
Reported by Tom Lane, via buildfarm member longfin.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/8bd064f0c7d61c40a8a1179e9d24
Michael Paquier writes:
> On Tue, Jul 17, 2018 at 07:23:04PM -0400, Tom Lane wrote:
>> longfin thinks you missed at least one cast ...
> Hm, I checked that. Just casting to (Size) should do it.
Sounds right to me.
regards, tom lane
On Tue, Jul 17, 2018 at 07:23:04PM -0400, Tom Lane wrote:
> Michael Paquier writes:
> > Rework error messages around file handling
>
> longfin thinks you missed at least one cast ...
Hm, I checked that. Just casting to (Size) should do it. I cannot get
a warning with neither clang nor gcc on D
Michael Paquier writes:
> Rework error messages around file handling
longfin thinks you missed at least one cast ...
regards, tom lane
Rework error messages around file handling
Some error messages related to file handling are using the code path
context to define their state. For example, 2PC-related errors are
referring to "two-phase status files", or "relation mapping file" is
used for catalog-to-filenode mapping, however tho
10 matches
Mail list logo
