pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

2018-07-18 Thread Michael Paquier
Fix print of Path nodes when using OPTIMIZER_DEBUG GatherMergePath (introduced in 10) and CustomPath (introduced in 9.5) have gone missing. The order of the Path nodes was inconsistent with what is listed in nodes.h, so make the order consistent at the same time to ease future checks and addition

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

2018-07-18 Thread Michael Paquier
Fix print of Path nodes when using OPTIMIZER_DEBUG GatherMergePath (introduced in 10) and CustomPath (introduced in 9.5) have gone missing. The order of the Path nodes was inconsistent with what is listed in nodes.h, so make the order consistent at the same time to ease future checks and addition

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

2018-07-18 Thread Michael Paquier
Fix print of Path nodes when using OPTIMIZER_DEBUG GatherMergePath (introduced in 10) and CustomPath (introduced in 9.5) have gone missing. The order of the Path nodes was inconsistent with what is listed in nodes.h, so make the order consistent at the same time to ease future checks and addition

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

2018-07-18 Thread Michael Paquier
Fix print of Path nodes when using OPTIMIZER_DEBUG GatherMergePath (introduced in 10) and CustomPath (introduced in 9.5) have gone missing. The order of the Path nodes was inconsistent with what is listed in nodes.h, so make the order consistent at the same time to ease future checks and addition

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

2018-07-18 Thread Michael Paquier
Fix print of Path nodes when using OPTIMIZER_DEBUG GatherMergePath (introduced in 10) and CustomPath (introduced in 9.5) have gone missing. The order of the Path nodes was inconsistent with what is listed in nodes.h, so make the order consistent at the same time to ease future checks and addition

pgsql: Fix re-parameterize of MergeAppendPath

2018-07-18 Thread Michael Paquier
Fix re-parameterize of MergeAppendPath Instead of MergeAppendPath, MergeAppend nodes were considered. This code is not covered by any tests now, which should be addressed at some point. This is an oversight from f49842d, which introduced partition-wise joins in v11, so back-patch down to that.

pgsql: Fix re-parameterize of MergeAppendPath

2018-07-18 Thread Michael Paquier
Fix re-parameterize of MergeAppendPath Instead of MergeAppendPath, MergeAppend nodes were considered. This code is not covered by any tests now, which should be addressed at some point. This is an oversight from f49842d, which introduced partition-wise joins in v11, so back-patch down to that.

pgsql: Remove race-prone hot_standby_feedback test cases in 001_stream_

2018-07-18 Thread Tom Lane
Remove race-prone hot_standby_feedback test cases in 001_stream_rep.pl. This script supposed that if it turned hot_standby_feedback on and then shut down the standby server, at least one feedback message would be guaranteed to be sent before the standby stops. But there is no such guarantee, if t

pgsql: Remove race-prone hot_standby_feedback test cases in 001_stream_

2018-07-18 Thread Tom Lane
Remove race-prone hot_standby_feedback test cases in 001_stream_rep.pl. This script supposed that if it turned hot_standby_feedback on and then shut down the standby server, at least one feedback message would be guaranteed to be sent before the standby stops. But there is no such guarantee, if t

pgsql: Remove race-prone hot_standby_feedback test cases in 001_stream_

2018-07-18 Thread Tom Lane
Remove race-prone hot_standby_feedback test cases in 001_stream_rep.pl. This script supposed that if it turned hot_standby_feedback on and then shut down the standby server, at least one feedback message would be guaranteed to be sent before the standby stops. But there is no such guarantee, if t

pgsql: Drop the rule against included index columns duplicating key col

2018-07-18 Thread Tom Lane
Drop the rule against included index columns duplicating key columns. The initial version of the included-index-column feature stated that included columns couldn't be the same as any key column of the index. While it'd be pretty silly to do that, since the included column would be entirely redund

pgsql: Drop the rule against included index columns duplicating key col

2018-07-18 Thread Tom Lane
Drop the rule against included index columns duplicating key columns. The initial version of the included-index-column feature stated that included columns couldn't be the same as any key column of the index. While it'd be pretty silly to do that, since the included column would be entirely redund

pgsql: Use a ResourceOwner to track buffer pins in all cases.

2018-07-18 Thread Tom Lane
Use a ResourceOwner to track buffer pins in all cases. Historically, we've allowed auxiliary processes to take buffer pins without tracking them in a ResourceOwner. However, that creates problems for error recovery. In particular, we've seen multiple reports of assertion crashes in the startup p

Re: pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
On 18/07/18 17:25, Alvaro Herrera wrote: I'm curious how you caught the "it's" -> "its" typos. Surely you didn't grep for "it's" ...? I did :-). I didn't read through all of them, though, just fixed a few that caught my eye at a quick glance. - Heikki

Re: pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Alvaro Herrera
On 2018-Jul-18, Heikki Linnakangas wrote: > Fix misc typos, mostly in comments. > > A collection of typos I happened to spot while reading code, as well as > grepping for common mistakes. I'm curious how you caught the "it's" -> "its" typos. Surely you didn't grep for "it's" ...? -- Álvaro He

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- REL9_4_STABLE Details

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- REL_11_STABLE Details

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- REL9_6_STABLE Details

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- REL_10_STABLE Details

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- REL9_3_STABLE Details

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- REL9_5_STABLE Details

pgsql: Fix misc typos, mostly in comments.

2018-07-18 Thread Heikki Linnakangas
Fix misc typos, mostly in comments. A collection of typos I happened to spot while reading code, as well as grepping for common mistakes. Backpatch to all supported versions, as applicable, to avoid conflicts when backporting other commits in the future. Branch -- master Details --- htt