pgsql: Make GUC wal_sender_timeout user-settable

2018-09-21 Thread Michael Paquier
Make GUC wal_sender_timeout user-settable Being able to use a value that can be changed on a connection basis is useful with clusters distributed geographically, and makes failure detection more flexible. A note is added in the documentation about the use of "options" in primary_conninfo, which c

pgsql: Get rid of explicit argument-count markings in tab-complete.c.

2018-09-21 Thread Tom Lane
Get rid of explicit argument-count markings in tab-complete.c. This replaces the "TailMatchesN" macros with just "TailMatches", and likewise "HeadMatchesN" becomes "HeadMatches" and "MatchesN" becomes "Matches". The various COMPLETE_WITH_LISTn macros are reduced to COMPLETE_WITH, and the single-i

pgsql: doc: JIT is enabled by default in PG 12

2018-09-21 Thread Bruce Momjian
doc: JIT is enabled by default in PG 12 JIT was disabled by default in a PG 11 in a separate commit that will normally not appear in the PG 12 git logs. Therefore, create a PG 12 document and mention the fact that JIT is enabled by default in this release. (A similar change in parallelism was m

Re: pgsql: In v11, disable JIT by default (it's still enabled by default in

2018-09-21 Thread Bruce Momjian
On Fri, Sep 21, 2018 at 05:05:54PM -0700, Andres Freund wrote: > Hi, > > On 2018-09-21 20:00:30 -0400, Bruce Momjian wrote: > > On Sat, Sep 15, 2018 at 06:27:42PM -0400, Bruce Momjian wrote: > > > On Sat, Sep 15, 2018 at 09:24:46PM +, Tom Lane wrote: > > > > In v11, disable JIT by default (it'

Re: pgsql: In v11, disable JIT by default (it's still enabled by default in

2018-09-21 Thread Andres Freund
Hi, On 2018-09-21 20:00:30 -0400, Bruce Momjian wrote: > On Sat, Sep 15, 2018 at 06:27:42PM -0400, Bruce Momjian wrote: > > On Sat, Sep 15, 2018 at 09:24:46PM +, Tom Lane wrote: > > > In v11, disable JIT by default (it's still enabled by default in HEAD). > > > > > > Per discussion, JIT isn't

Re: pgsql: In v11, disable JIT by default (it's still enabled by default in

2018-09-21 Thread Bruce Momjian
On Sat, Sep 15, 2018 at 06:27:42PM -0400, Bruce Momjian wrote: > On Sat, Sep 15, 2018 at 09:24:46PM +, Tom Lane wrote: > > In v11, disable JIT by default (it's still enabled by default in HEAD). > > > > Per discussion, JIT isn't quite mature enough to ship enabled-by-default. > > > > I failed

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: docs: remove use of escape strings and use bytea hex output

2018-09-21 Thread Bruce Momjian
docs: remove use of escape strings and use bytea hex output standard_conforming_strings defaulted to 'on' in PG 9.1. bytea_output defaulted to 'hex' in PG 9.0. Reported-by: André Hänsel Discussion: https://postgr.es/m/12e601d447ac$345994a0$9d0cbde0$@webkr.de Backpatch-through: 9.3 Branch

pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION.

2018-09-21 Thread Tom Lane
Fix bogus tab-completion rule for CREATE PUBLICATION. You can't use "FOR TABLE" as a single Matches argument, because readline will consider that input to be two words not one. It's necessary to make the pattern contain two arguments. The case accidentally worked anyway because the words_after_c

pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION.

2018-09-21 Thread Tom Lane
Fix bogus tab-completion rule for CREATE PUBLICATION. You can't use "FOR TABLE" as a single Matches argument, because readline will consider that input to be two words not one. It's necessary to make the pattern contain two arguments. The case accidentally worked anyway because the words_after_c

pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION.

2018-09-21 Thread Tom Lane
Fix bogus tab-completion rule for CREATE PUBLICATION. You can't use "FOR TABLE" as a single Matches argument, because readline will consider that input to be two words not one. It's necessary to make the pattern contain two arguments. The case accidentally worked anyway because the words_after_c

pgsql: Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.

2018-09-21 Thread Tom Lane
Improve tab completion for ANALYZE, EXPLAIN, and VACUUM. Previously, we made no attempt to provide tab completion in these statements' optional parenthesized options lists. This patch teaches psql to do so. To prevent the option completions from being offered after we've already seen a complete

pgsql: Rationalize Query_for_list_of_[relations] query names in tab-com

2018-09-21 Thread Tom Lane
Rationalize Query_for_list_of_[relations] query names in tab-complete.c. The previous convention was to use names based on the set of relkinds being selected for, which was not at all helpful for maintenance, especially since people had been quite inconsistent about whether to change the names whe

pgsql: Use size_t consistently in dsa.{ch}.

2018-09-21 Thread Thomas Munro
Use size_t consistently in dsa.{ch}. Takeshi Ideriha complained that there is a mixture of Size and size_t in dsa.c and corresponding header. Let's use size_t. Back-patch to 10 where dsa.c landed, to make future back-patching easy. Discussion: https://postgr.es/m/4E72940DA2BF16479384A86D54D098

pgsql: Use size_t consistently in dsa.{ch}.

2018-09-21 Thread Thomas Munro
Use size_t consistently in dsa.{ch}. Takeshi Ideriha complained that there is a mixture of Size and size_t in dsa.c and corresponding header. Let's use size_t. Back-patch to 10 where dsa.c landed, to make future back-patching easy. Discussion: https://postgr.es/m/4E72940DA2BF16479384A86D54D098

pgsql: Use size_t consistently in dsa.{ch}.

2018-09-21 Thread Thomas Munro
Use size_t consistently in dsa.{ch}. Takeshi Ideriha complained that there is a mixture of Size and size_t in dsa.c and corresponding header. Let's use size_t. Back-patch to 10 where dsa.c landed, to make future back-patching easy. Discussion: https://postgr.es/m/4E72940DA2BF16479384A86D54D098

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-21 Thread David Steele
On 9/21/18 12:53 AM, Michael Paquier wrote: > On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote: >> 16*M*B, right? If so, that's normal - pg_settings just reports the >> values in the underlying unit - which is XLOG_BLCKSZ, compile-time >> defaulting to 8KB. 8192 * 2048 = 16MB. That's