Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Michael Paquier
On Mon, Oct 22, 2018 at 01:46:49PM +0900, Amit Langote wrote: > On 2018/10/22 13:35, Michael Paquier wrote: >> Amit, Tom, what do you think about the attached? This merges all the >> things proposed. > > Thanks, looks good to me. Committed, and back-patched the part about relispartition to v11.

pgsql: Fix description of pg_class.relispartition in documentation

2018-10-21 Thread Michael Paquier
Fix description of pg_class.relispartition in documentation This missed the fact that indexes can be partitions since 11. Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/20181022031212.gf14...@paquier.xyz Branch -- REL_11_STABLE Details --- https://git.post

pgsql: Clarify descriptions of relhassubclass and relispartition in pg_

2018-10-21 Thread Michael Paquier
Clarify descriptions of relhassubclass and relispartition in pg_class Three places are fixed, one for each author. Reported-by: Tom Lane Author: Tom Lane, Amit Langote, Michael Paquier Discussion: https://postgr.es/m/82470.1540177...@sss.pgh.pa.us Branch -- master Details --- https://gi

Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Amit Langote
On 2018/10/22 13:35, Michael Paquier wrote: > Amit, Tom, what do you think about the attached? This merges all the > things proposed. Thanks, looks good to me. Regards, Amit

Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Michael Paquier
On Sun, Oct 21, 2018 at 11:20:04PM -0400, Tom Lane wrote: > Michael Paquier writes: >> On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote: >>> Seems like this commit should have touched the catalogs.sgml description >>> for that column, as well as the pg_class.h comment for it. Neither of >

Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Tom Lane
Michael Paquier writes: > On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote: >> Seems like this commit should have touched the catalogs.sgml description >> for that column, as well as the pg_class.h comment for it. Neither of >> those are worded in a way that suggests it could be set for n

Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Michael Paquier
On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote: > Michael Paquier writes: >> Set pg_class.relhassubclass for partitioned indexes > > Seems like this commit should have touched the catalogs.sgml description > for that column, as well as the pg_class.h comment for it. Neither of > those

Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Amit Langote
On 2018/10/22 11:59, Tom Lane wrote: > Michael Paquier writes: >> Set pg_class.relhassubclass for partitioned indexes > > Seems like this commit should have touched the catalogs.sgml description > for that column, as well as the pg_class.h comment for it. Neither of > those are worded in a way t

Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Tom Lane
Michael Paquier writes: > Set pg_class.relhassubclass for partitioned indexes Seems like this commit should have touched the catalogs.sgml description for that column, as well as the pg_class.h comment for it. Neither of those are worded in a way that suggests it could be set for non-table relat

pgsql: Set pg_class.relhassubclass for partitioned indexes

2018-10-21 Thread Michael Paquier
Set pg_class.relhassubclass for partitioned indexes Like for relations, switching this parameter is optimistic by turning it on each time a partitioned index gains a partition. So seeing this parameter set to true means that the partitioned index has or has had partitions. The flag cannot be res

pgsql: Fix some grammar errors in bloom.sgml

2018-10-21 Thread Alexander Korotkov
Fix some grammar errors in bloom.sgml Discussion: https://postgr.es/m/CAEepm%3D3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy%2B%3D5A%40mail.gmail.com Reported-by: Thomas Munro Backpatch-through: 9.6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6889428769255253

pgsql: Fix some grammar errors in bloom.sgml

2018-10-21 Thread Alexander Korotkov
Fix some grammar errors in bloom.sgml Discussion: https://postgr.es/m/CAEepm%3D3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy%2B%3D5A%40mail.gmail.com Reported-by: Thomas Munro Backpatch-through: 9.6 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/33df118a73c099e4

pgsql: Fix some grammar errors in bloom.sgml

2018-10-21 Thread Alexander Korotkov
Fix some grammar errors in bloom.sgml Discussion: https://postgr.es/m/CAEepm%3D3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy%2B%3D5A%40mail.gmail.com Reported-by: Thomas Munro Backpatch-through: 9.6 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/31ff51adc855e3ffe8e3c20

pgsql: Fix some grammar errors in bloom.sgml

2018-10-21 Thread Alexander Korotkov
Fix some grammar errors in bloom.sgml Discussion: https://postgr.es/m/CAEepm%3D3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy%2B%3D5A%40mail.gmail.com Reported-by: Thomas Munro Backpatch-through: 9.6 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/28ddee2b02127a0

Re: pgsql: Don't try to test files named with a trailing dot on Windows

2018-10-21 Thread Michael Paquier
On Sun, Oct 21, 2018 at 01:03:35PM +, Andrew Dunstan wrote: > Don't try to test files named with a trailing dot on Windows > > The pg_verify_checksums test tries to create files with corrupt data > named "123." and "123_." But on Windows a file name with a trailing dot > is the same as a file

pgsql: Don't try to test files named with a trailing dot on Windows

2018-10-21 Thread Andrew Dunstan
Don't try to test files named with a trailing dot on Windows The pg_verify_checksums test tries to create files with corrupt data named "123." and "123_." But on Windows a file name with a trailing dot is the same as a file without the trailing dot. In the first case this will create a file with a

Re: pgsql: Silence perlcritic warning about missing return.

2018-10-21 Thread Andrew Dunstan
On 10/19/2018 11:43 PM, Michael Paquier wrote: On Fri, Oct 19, 2018 at 06:00:26PM +, Tom Lane wrote: Silence perlcritic warning about missing return. Per buildfarm member crake. Thanks! I did not know that this was run automatically. It's been running since we improved our perlcriti