pgsql: Remove get_atttypmod()

2018-10-23 Thread Peter Eisentraut
Remove get_atttypmod() This has been unused since 2004. get_atttypetypmodcoll() is often a better alternative. Reviewed-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c903bb7b1c3ce82e21d6bd1af1dc45a58cd88455 Modified Files -- src

pgsql: Remove get_attidentity()

2018-10-23 Thread Peter Eisentraut
Remove get_attidentity() All existing uses can get this information more easily from the relation descriptor, so the detour through the syscache is not necessary. Reviewed-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5d7c703a44101f0d686fb66f

pgsql: Drop const cast from dlsym() calls

2018-10-23 Thread Peter Eisentraut
Drop const cast from dlsym() calls This workaround might be obsolete. We'll see if those "older platforms" mentioned in the comment are still around. Discussion: https://www.postgresql.org/message-id/08adbe4e-38f8-2c73-55f0-591392371687%402ndquadrant.com Branch -- master Details --- h

pgsql: Sprinkle some const decorations

2018-10-23 Thread Peter Eisentraut
Sprinkle some const decorations These mainly help understanding the function signatures better. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/807e4bc828cff0645d2a776604dc7cdc733b2fd3 Modified Files -- src/backend/parser/parse_coerce.c | 8 src