pgsql: Fix up confusion over how to use EXTRA_INSTALL.

2019-01-11 Thread Tom Lane
Fix up confusion over how to use EXTRA_INSTALL. Some makefiles were trying to do this: temp-install: EXTRA_INSTALL=contrib/test_decoding but that no longer works as of commit aa019da52: the macro is now consulted by the checkprep target, one level down, and apparently gmake doesn't propagate suc

pgsql: Fix up confusion over how to use EXTRA_INSTALL.

2019-01-11 Thread Tom Lane
Fix up confusion over how to use EXTRA_INSTALL. Some makefiles were trying to do this: temp-install: EXTRA_INSTALL=contrib/test_decoding but that no longer works as of commit aa019da52: the macro is now consulted by the checkprep target, one level down, and apparently gmake doesn't propagate suc

pgsql: Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...

2019-01-11 Thread Andrew Dunstan
Free pre-modification HeapTuple in ALTER TABLE ... TYPE ... This was an oversight in commit 3b174b1a3. Per offline gripe from Alvaro Herrera Backpatch to release 11. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e33884d4122b56fc0dbff3d8cedd8177334db838 Modified

pgsql: Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...

2019-01-11 Thread Andrew Dunstan
Free pre-modification HeapTuple in ALTER TABLE ... TYPE ... This was an oversight in commit 3b174b1a3. Per offline gripe from Alvaro Herrera Backpatch to release 11. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89d52b9a3e3fab3d6876c997370684a8b1c77f3b M

pgsql: Avoid sharing PARAM_EXEC slots between different levels of NestL

2019-01-11 Thread Tom Lane
Avoid sharing PARAM_EXEC slots between different levels of NestLoop. Up to now, createplan.c attempted to share PARAM_EXEC slots for NestLoopParams across different plan levels, if the same underlying Var was being fed down to different righthand-side subplan trees by different NestLoops. This wa

pgsql: Avoid sharing PARAM_EXEC slots between different levels of NestL

2019-01-11 Thread Tom Lane
Avoid sharing PARAM_EXEC slots between different levels of NestLoop. Up to now, createplan.c attempted to share PARAM_EXEC slots for NestLoopParams across different plan levels, if the same underlying Var was being fed down to different righthand-side subplan trees by different NestLoops. This wa

pgsql: Avoid sharing PARAM_EXEC slots between different levels of NestL

2019-01-11 Thread Tom Lane
Avoid sharing PARAM_EXEC slots between different levels of NestLoop. Up to now, createplan.c attempted to share PARAM_EXEC slots for NestLoopParams across different plan levels, if the same underlying Var was being fed down to different righthand-side subplan trees by different NestLoops. This wa

pgsql: Avoid sharing PARAM_EXEC slots between different levels of NestL

2019-01-11 Thread Tom Lane
Avoid sharing PARAM_EXEC slots between different levels of NestLoop. Up to now, createplan.c attempted to share PARAM_EXEC slots for NestLoopParams across different plan levels, if the same underlying Var was being fed down to different righthand-side subplan trees by different NestLoops. This wa

pgsql: doc: Correct documentation of install-time environment variables

2019-01-11 Thread Peter Eisentraut
doc: Correct documentation of install-time environment variables Since approximately PostgreSQL 10, it is no longer required that environment variables at installation time such as PERL, PYTHON, TCLSH be "full path names", so change that phrasing in the installation instructions. (The exact time

pgsql: doc: Correct documentation of install-time environment variables

2019-01-11 Thread Peter Eisentraut
doc: Correct documentation of install-time environment variables Since approximately PostgreSQL 10, it is no longer required that environment variables at installation time such as PERL, PYTHON, TCLSH be "full path names", so change that phrasing in the installation instructions. (The exact time

pgsql: doc: Correct documentation of install-time environment variables

2019-01-11 Thread Peter Eisentraut
doc: Correct documentation of install-time environment variables Since approximately PostgreSQL 10, it is no longer required that environment variables at installation time such as PERL, PYTHON, TCLSH be "full path names", so change that phrasing in the installation instructions. (The exact time

pgsql: Create INSTALL file using Pandoc

2019-01-11 Thread Peter Eisentraut
Create INSTALL file using Pandoc Replace using lynx with using pandoc. Pandoc creates better looking output and it avoids the delicate locale/encoding issues of lynx because it always uses UTF-8 for both input and output. Note: requires Pandoc >=1.13 Discussion: https://www.postgresql.org/mess

pgsql: Add value 'current' for recovery_target_timeline

2019-01-11 Thread Peter Eisentraut
Add value 'current' for recovery_target_timeline This value represents the default behavior of using the current timeline. Previously, this was represented by an empty string. (Before the removal of recovery.conf, this setting could not be chosen explicitly but was used when recovery_target_time