pgsql: Fix erroneous error reports in snapbuild.c.

2019-02-11 Thread Tom Lane
Fix erroneous error reports in snapbuild.c. It's pretty unhelpful to report the wrong file name in a complaint about syscall failure, but SnapBuildSerialize managed to do that twice in a span of 50 lines. Also fix half a dozen missing or poorly-chosen errcode assignments; that's mostly cosmetic,

pgsql: Fix erroneous error reports in snapbuild.c.

2019-02-11 Thread Tom Lane
Fix erroneous error reports in snapbuild.c. It's pretty unhelpful to report the wrong file name in a complaint about syscall failure, but SnapBuildSerialize managed to do that twice in a span of 50 lines. Also fix half a dozen missing or poorly-chosen errcode assignments; that's mostly cosmetic,

pgsql: Fix erroneous error reports in snapbuild.c.

2019-02-11 Thread Tom Lane
Fix erroneous error reports in snapbuild.c. It's pretty unhelpful to report the wrong file name in a complaint about syscall failure, but SnapBuildSerialize managed to do that twice in a span of 50 lines. Also fix half a dozen missing or poorly-chosen errcode assignments; that's mostly cosmetic,

pgsql: Fix erroneous error reports in snapbuild.c.

2019-02-11 Thread Tom Lane
Fix erroneous error reports in snapbuild.c. It's pretty unhelpful to report the wrong file name in a complaint about syscall failure, but SnapBuildSerialize managed to do that twice in a span of 50 lines. Also fix half a dozen missing or poorly-chosen errcode assignments; that's mostly cosmetic,

pgsql: Fix erroneous error reports in snapbuild.c.

2019-02-11 Thread Tom Lane
Fix erroneous error reports in snapbuild.c. It's pretty unhelpful to report the wrong file name in a complaint about syscall failure, but SnapBuildSerialize managed to do that twice in a span of 50 lines. Also fix half a dozen missing or poorly-chosen errcode assignments; that's mostly cosmetic,

pgsql: Fix erroneous error reports in snapbuild.c.

2019-02-11 Thread Tom Lane
Fix erroneous error reports in snapbuild.c. It's pretty unhelpful to report the wrong file name in a complaint about syscall failure, but SnapBuildSerialize managed to do that twice in a span of 50 lines. Also fix half a dozen missing or poorly-chosen errcode assignments; that's mostly cosmetic,

pgsql: Fix description of WAL record XLOG_PARAMETER_CHANGE

2019-02-11 Thread Michael Paquier
Fix description of WAL record XLOG_PARAMETER_CHANGE max_wal_senders and max_worker_processes got reversed in the output generated because of ea92368. Reported-by: Kevin Hale Boyes Discussion: https://postgr.es/m/CADAecHVAD4=26kax4nj5dbvxqqvjkuwsy+riiinhqqwnzg2...@mail.gmail.com Branch -- ma

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-11 Thread Michael Paquier
On Sat, Feb 09, 2019 at 01:35:52PM -0500, Stephen Frost wrote: > While I agree that we don't really have a formal policy, there are > certainly some who do (or, at least did) seem to care quite a bit about > this and that's why I've been using '--ignore-date' for quite some time > in my workflow: >

pgsql: Fix header inclusion issue.

2019-02-11 Thread Tom Lane
Fix header inclusion issue. partprune.h failed to compile by itself; needs to include partdefs.h. I think I must've broken this in fa2cf164a, though I'd swear I ran the appropriate tests when removing #includes. Anyway, it's very sensible for this file to include partdefs.h, so let's just do tha

pgsql: Clarify docs about limitations of constraint exclusion with part

2019-02-11 Thread Michael Paquier
Clarify docs about limitations of constraint exclusion with partitions The current wording can confuse the reader about constraint exclusion being available at query execution, but this only applies to partition pruning. Reported-by: Shouyu Luo Author: David Rowley Reviewed-by: Chapman Flack, Ami

pgsql: Clarify docs about limitations of constraint exclusion with part

2019-02-11 Thread Michael Paquier
Clarify docs about limitations of constraint exclusion with partitions The current wording can confuse the reader about constraint exclusion being available at query execution, but this only applies to partition pruning. Reported-by: Shouyu Luo Author: David Rowley Reviewed-by: Chapman Flack, Ami

pgsql: Allow extensions to generate lossy index conditions.

2019-02-11 Thread Tom Lane
Allow extensions to generate lossy index conditions. For a long time, indxpath.c has had the ability to extract derived (lossy) index conditions from certain operators such as LIKE. For just as long, it's been obvious that we really ought to make that capability available to extensions. This com

pgsql: Move max_wal_senders out of max_connections for connection slot

2019-02-11 Thread Michael Paquier
Move max_wal_senders out of max_connections for connection slot handling Since its introduction, max_wal_senders is counted as part of max_connections when it comes to define how many connection slots can be used for replication connections with a WAL sender context. This can lead to confusion fo

pgsql: Stamp 9.4.21.

2019-02-11 Thread Tom Lane
Stamp 9.4.21. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4bf9119adf599db7b1ad073606d0f28617d6 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 9.5.16.

2019-02-11 Thread Tom Lane
Stamp 9.5.16. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/394ef2397dd47ffa0fb2c1f51e19a2c8e51bec4d Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 9.6.12.

2019-02-11 Thread Tom Lane
Stamp 9.6.12. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9848bd725e3b021bbe53e606ac9c261079ee82ba Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 10.7.

2019-02-11 Thread Tom Lane
Stamp 10.7. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a093e1444955d6ee1d7cfda68932c19d5613d87a Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 11.2.

2019-02-11 Thread Tom Lane
Stamp 11.2. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6cd404b344f7e27f4d64555bb133f18a758fe851 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

Re: pgsql: Use better comment marker in Autoconf input

2019-02-11 Thread Andrew Dunstan
On Mon, Feb 11, 2019 at 11:46 AM Tom Lane wrote: > > Yup, the buildfarm script only knows to nuke it if "configure" changes. > If you change the critter's buildfarm parameters, or the build > environment, that might require revisiting configure tests, but it won't > happen automatically. I can't

Re: pgsql: Use better comment marker in Autoconf input

2019-02-11 Thread Thomas Munro
On Tue, Feb 12, 2019 at 3:46 AM Tom Lane wrote: > Thomas Munro writes: > > It was using CC="ccache cc" for C, but no explicit CXX. Somehow our > > configure script flipped from finding c++ (the system C++ compiler, > > which is Clang) to finding g++ (an old GCC port I had installed) after > > th

pgsql: Redesign the partition dependency mechanism.

2019-02-11 Thread Tom Lane
Redesign the partition dependency mechanism. The original setup for dependencies of partitioned objects had serious problems: 1. It did not verify that a drop cascading to a partition-child object also cascaded to at least one of the object's partition parents. Now, normally a child object would

pgsql: Fix misleading PG_RE_THROW commentary

2019-02-11 Thread Alvaro Herrera
Fix misleading PG_RE_THROW commentary The old verbiage indicated that PG_RE_THROW is optional, which is not really true. This has confused many people, so it seems worth fixing. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://g

pgsql: Last-minute updates for release notes.

2019-02-11 Thread Tom Lane
Last-minute updates for release notes. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6c9356080c2060bcd4a6cef520aa3d8121940ee7 Modified Files -- doc/src/sgml/release-11.sgml | 13 + 1 file changed, 13 insertions(+)

Re: pgsql: Use better comment marker in Autoconf input

2019-02-11 Thread Tom Lane
Thomas Munro writes: > It was using CC="ccache cc" for C, but no explicit CXX. Somehow our > configure script flipped from finding c++ (the system C++ compiler, > which is Clang) to finding g++ (an old GCC port I had installed) after > that commit, and the resulting .so didn't work too well. I d

pgsql: Translation updates

2019-02-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 2cd47eeb832ed1bb1cbfff285cfc921ca4d07a9d Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/352f9b57cfdf3e8f871474223975ee2c6b725bf7 Modified Files --

pgsql: Translation updates

2019-02-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: da5fe0060d012477d807c1b60f1ff2188947a72f Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ff3ac5903d1f45f3267c45683b0883758e24ead8 Modified Files --

pgsql: Translation updates

2019-02-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: db7a038785d2919e23e222be1ffa1866087fa803 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/968ffb09f24f02e3001a4a9e27c561eb8adb5e4b Modified Files --

pgsql: Translation updates

2019-02-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 82b08ac4d1dfb5febd26bb493d0055cc5d71d513 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d64d05827e5fed5e7bba5b1f659a6f3720298db2 Modified Files --

pgsql: Translation updates

2019-02-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: f3ca37534288ad85c0436fa00755b8aba69e57d3 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/248fd6cb3a9d01348be0fef12f370c453dba8a77 Modified Files --

pgsql: Adjust gratuitously different error message wording

2019-02-11 Thread Peter Eisentraut
Adjust gratuitously different error message wording Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/256fc004afb1eedba10232349c5149c8f41d06a1 Modified Files -- src/backend/commands/lockcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-11 Thread Michael Paquier
On Mon, Feb 11, 2019 at 10:59:20AM +0100, Peter Eisentraut wrote: > Committed that way. Thanks Peter for adjusting the message, I was just going to do it. There was a long weekend here and I had zero access to my laptop, explaining the delay in replying. -- Michael signature.asc Description: PGP

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-11 Thread Peter Eisentraut
On 09/02/2019 16:06, Peter Eisentraut wrote: > On 08/02/2019 11:00, Michael Paquier wrote: >> On Fri, Feb 08, 2019 at 10:41:59AM +0100, Peter Eisentraut wrote: >>> We usually don't use "namespace" in user-facing error messages. Can you >>> change it to say "temporary schema"? >> >> Or just switch

pgsql: Adjust error message

2019-02-11 Thread Peter Eisentraut
Adjust error message We usually don't use "namespace" in user-facing error messages. Also, in master this was replaced by another error message referring to "temporary objects", so we might as well use that here to avoid introducing too many variants. Discussion: https://www.postgresql.org/mess

pgsql: Adjust error message

2019-02-11 Thread Peter Eisentraut
Adjust error message We usually don't use "namespace" in user-facing error messages. Also, in master this was replaced by another error message referring to "temporary objects", so we might as well use that here to avoid introducing too many variants. Discussion: https://www.postgresql.org/mess

pgsql: Remove unused macro

2019-02-11 Thread Peter Eisentraut
Remove unused macro Last use was removed in 2c66f9924c1162bfba27c77004ccf42fb6ea188d. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/78b0cac74dabf879f769ff02a0df83ed90f2d36c Modified Files -- src/backend/utils/adt/format_type.c | 2 -- 1 file changed, 2